You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Mistuke (via GitHub)" <gi...@apache.org> on 2025/02/23 07:53:25 UTC

[I] GLOBAL_ASYNC_QUERIES_CACHE_BACKEND ignores username [superset]

Mistuke opened a new issue, #32353:
URL: https://github.com/apache/superset/issues/32353

   ### Bug description
   
   #30284 removed `GLOBAL_ASYNC_QUERIES_REDIS_CONFIG` for `GLOBAL_ASYNC_QUERIES_CACHE_BACKEND`,
   however `GLOBAL_ASYNC_QUERIES_CACHE_BACKEND` even though it declares `CACHE_REDIS_USER` as a parameter  https://github.com/apache/superset/blob/2c37ddb2f63d216665c8d81232500986281ccfc0/superset/config.py#L1755 never passes the username down to the redis client 
    https://github.com/apache/superset/blob/master/superset/async_events/cache_backend.py#L27 which means the user/password pair is never correct.
   
   With `GLOBAL_ASYNC_QUERIES_REDIS_CONFIG` this was possible to do as it had the ability to pass kwargs directly to the redis client. Which means before this change it was possible to use secure username/password redis, but after this change it's not.
   
   ### Screenshots/recordings
   
   _No response_
   
   ### Superset version
   
   master / latest-dev
   
   ### Python version
   
   3.9
   
   ### Node version
   
   16
   
   ### Browser
   
   Chrome
   
   ### Additional context
   
   _No response_
   
   ### Checklist
   
   - [x] I have searched Superset docs and Slack and didn't find a solution to my problem.
   - [x] I have searched the GitHub issue tracker and didn't find a similar bug report.
   - [x] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] GLOBAL_ASYNC_QUERIES_CACHE_BACKEND ignores username [superset]

Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #32353:
URL: https://github.com/apache/superset/issues/32353#issuecomment-2676690338

   <!-- Greeting -->
   Hey @Mistuke! I'm here to help you with any bugs, questions, or contributions you have for Superset. Let's tackle this together!
   
   <!-- Answer -->
   The issue you're encountering is due to the `GLOBAL_ASYNC_QUERIES_CACHE_BACKEND` configuration not passing the `CACHE_REDIS_USER` parameter to the Redis client, which is necessary for secure username/password authentication. This change occurred when `GLOBAL_ASYNC_QUERIES_REDIS_CONFIG` was removed in favor of the new configuration, which does not support passing the username directly to the Redis client <sup>[[1]](https://github.com/apache/superset/blob/master/superset/config.py)</sup><sup>[[2]](https://github.com/apache/superset/blob/master/superset/async_events/cache_backend.py)</sup>.
   
   To address this, you might consider modifying the `cache_backend.py` file to include the `CACHE_REDIS_USER` parameter when instantiating the Redis client. This would involve updating the instantiation logic to pass the username along with other connection parameters. Alternatively, you could explore using a custom configuration or patch to reintroduce the ability to pass additional keyword arguments, including the username, to the Redis client.
   
   
   <!-- Dosu Comment Footer -->
   *To continue talking to [Dosu](https://dosu.dev), mention @dosu.*
   
   ---
   <sup>Help Dosu learn! Give it feedback: [Great Response](https://app.dosu.dev/response-feedback/b942fe25-613b-47c7-b5fe-e8b84c0bd990?feedback_type=great_response) | [Irrelevant Answer](https://app.dosu.dev/response-feedback/b942fe25-613b-47c7-b5fe-e8b84c0bd990?feedback_type=irrelevant_answer) | [Incorrect Sources](https://app.dosu.dev/response-feedback/b942fe25-613b-47c7-b5fe-e8b84c0bd990?feedback_type=incorrect_sources) | [Too Verbose](https://app.dosu.dev/response-feedback/b942fe25-613b-47c7-b5fe-e8b84c0bd990?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/b942fe25-613b-47c7-b5fe-e8b84c0bd990?feedback_type=hallucination) | [Bug Report](https://app.dosu.dev/response-feedback/b942fe25-613b-47c7-b5fe-e8b84c0bd990?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/b942fe25-613b-47c7-b5fe-e8b84c0bd990?feedback_type=other)</sup>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] GLOBAL_ASYNC_QUERIES_CACHE_BACKEND ignores username [superset]

Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro closed issue #32353: GLOBAL_ASYNC_QUERIES_CACHE_BACKEND ignores username
URL: https://github.com/apache/superset/issues/32353


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org