You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/24 06:00:14 UTC

[GitHub] [airflow] malthe commented on pull request #22475: Make sure finalizers are not skipped during exception handling

malthe commented on pull request #22475:
URL: https://github.com/apache/airflow/pull/22475#issuecomment-1077262263


   @potiuk but isn't using `tempfile.TemporaryDirectory` without entering the context manager simply a mistake? I don't think one should rely on the finalizer behavior in order to close such resources.
   
   That said, this is much better (exiting outside of the try/finally block) – but why are we even having a try/finally-block at all.
   
   The exception clause catches everything.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org