You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Yukang-Lian (via GitHub)" <gi...@apache.org> on 2026/05/28 08:01:15 UTC
[PR] [fix](be fe) Pick #62263 and #61647 into branch-4.0 [doris]
Yukang-Lian opened a new pull request, #63816:
URL: https://github.com/apache/doris/pull/63816
### What problem does this PR solve?
Issue Number: None
Related PR: #62263, #61647
Problem Summary: This PR picks two approved changes into `branch-4.0`:
- #62263: use segment footer `raw_data_bytes` for first-time vertical compaction batch-size estimation, with focused BE unit coverage.
- #61647: avoid delete quorum stalls when delete push tasks fail before enough successful replicas return, with FE unit coverage.
### Release note
None
### Check List (For Author)
- Test:
- `PATH="/mnt/disk2/lianyukang/ldb_toolchain_v16/bin:$PATH" ./build-support/clang-format.sh`
- `PATH="/mnt/disk2/lianyukang/ldb_toolchain_v16/bin:$PATH" ./build-support/check-format.sh`
- `./run-fe-ut.sh --run org.apache.doris.load.DeleteJobTest,org.apache.doris.master.MasterImplDeleteTaskTest`
- `./run-be-ut.sh --run --filter=VerticalCompactionTest.TestFirstCompactionUsesFooterEstimation:VerticalCompactionTest.TestFooterRawDataBytesAccuracy:VerticalCompactionTest.TestFooterRawDataBytesNullableSparse`
- `build-support/run-clang-tidy.sh` is not present on this `branch-4.0` checkout. I attempted manual `clang-tidy -p be/ut_build_ASAN` on the touched C++ files; the unfiltered run failed on existing branch-wide tidy findings and a current v26 toolchain `stddef.h` lookup error, so it was not a usable changed-line signal.
- Behavior changed: Yes. This backports the behavior from #62263 and #61647 to `branch-4.0`.
- Does this need documentation: No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.0: [fix](be fe) pick #62263 #61647 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63816:
URL: https://github.com/apache/doris/pull/63816#issuecomment-4563469516
# BE Regression && UT Coverage Report
Increment line coverage `89.42% (93/104)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63816_d66c535a57e184d435ccf5db22e90cf53910092e_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63816_d66c535a57e184d435ccf5db22e90cf53910092e_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.46% (25513/35700) |
| Line Coverage | 54.30% (270260/497724) |
| Region Coverage | 51.81% (223633/431625) |
| Branch Coverage | 53.27% (96305/180791) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be fe) Pick #62263 and #61647 into branch-4.0 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63816:
URL: https://github.com/apache/doris/pull/63816#issuecomment-4561928949
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.0: [fix](be fe) pick #62263 #61647 [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #63816:
URL: https://github.com/apache/doris/pull/63816#issuecomment-4561972349
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.0: [fix](be fe) pick #62263 #61647 [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #63816:
URL: https://github.com/apache/doris/pull/63816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org