You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/22 11:55:38 UTC
[GitHub] [apisix] Yullin opened a new pull request #4467: Apache master
Yullin opened a new pull request #4467:
URL: https://github.com/apache/apisix/pull/4467
### What this PR does / why we need it:
<!--- Add access_log config item in config.yaml -->
<!--- #4302 . -->
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yullin commented on pull request #4467: Add access_log config item in config.yaml
Posted by GitBox <gi...@apache.org>.
Yullin commented on pull request #4467:
URL: https://github.com/apache/apisix/pull/4467#issuecomment-866572270
I had fixed those issues, how can I continue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yullin commented on pull request #4467: feat: extend current access log configuration
Posted by GitBox <gi...@apache.org>.
Yullin commented on pull request #4467:
URL: https://github.com/apache/apisix/pull/4467#issuecomment-872870633
Please check again, Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yullin commented on pull request #4467: feat: extend current access log configuration
Posted by GitBox <gi...@apache.org>.
Yullin commented on pull request #4467:
URL: https://github.com/apache/apisix/pull/4467#issuecomment-871349499
> @Yullin
> You can push another commit to your apache-master branch instead of creating new PR like #4471
OK, Sorry for that, I had a little confusion about the PR operation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4467: Add access_log config item in config.yaml
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4467:
URL: https://github.com/apache/apisix/pull/4467#discussion_r656181284
##########
File path: conf/config-default.yaml
##########
@@ -169,9 +169,30 @@ nginx_config: # config for render the template to generate n
http:
enable_access_log: true # enable access log or not, default true
- access_log: "logs/access.log"
- access_log_format: "$remote_addr - $remote_user [$time_local] $http_host \"$request\" $status $body_bytes_sent $request_time \"$http_referer\" \"$http_user_agent\" $upstream_addr $upstream_status $upstream_response_time \"$upstream_scheme://$upstream_host$upstream_uri\""
- access_log_format_escape: default # allows setting json or default characters escaping in variables
+ # access_log_format: "$remote_addr - $remote_user [$time_local] $http_host \"$request\" $status $body_bytes_sent $request_time \"$http_referer\" \"$http_user_agent\" $upstream_addr $upstream_status $upstream_response_time \"$upstream_scheme://$upstream_host$upstream_uri\""
+ # access_log: "logs/access.log"
+ # access_log_format_escape: default # allows setting json or default characters escaping in variables
+ access_log:
Review comment:
We can't accept a break change, the new change should be compatible with the old style, like:
https://github.com/apache/apisix/blob/2707fda3eb7b23d995ac23ecf4a17000dd765855/apisix/cli/ops.lua#L410
##########
File path: conf/config-default.yaml
##########
@@ -169,9 +169,30 @@ nginx_config: # config for render the template to generate n
http:
enable_access_log: true # enable access log or not, default true
- access_log: "logs/access.log"
- access_log_format: "$remote_addr - $remote_user [$time_local] $http_host \"$request\" $status $body_bytes_sent $request_time \"$http_referer\" \"$http_user_agent\" $upstream_addr $upstream_status $upstream_response_time \"$upstream_scheme://$upstream_host$upstream_uri\""
- access_log_format_escape: default # allows setting json or default characters escaping in variables
+ # access_log_format: "$remote_addr - $remote_user [$time_local] $http_host \"$request\" $status $body_bytes_sent $request_time \"$http_referer\" \"$http_user_agent\" $upstream_addr $upstream_status $upstream_response_time \"$upstream_scheme://$upstream_host$upstream_uri\""
+ # access_log: "logs/access.log"
+ # access_log_format_escape: default # allows setting json or default characters escaping in variables
+ access_log:
+ -
+ log_type: "local" # local disk log storage
+ log_format: "$remote_addr - $remote_user [$time_local] $http_host \"$request\" $status $body_bytes_sent $request_time \"$http_referer\" \"$http_user_agent\" $upstream_addr $upstream_status $upstream_response_time \"$upstream_scheme://$upstream_host$upstream_uri\""
+ log_format_name: "main_local"
+ log_format_escape: "default" # allows setting json or default characters escaping in variables
+ log_path: "logs/access.log" # disk storage path
+ log_buffer: 16384
+ log_flush: 3
+ -
+ log_type: "syslog" # send log to remote syslog
Review comment:
Need to comment out the syslog version by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on pull request #4467: feat: extend current access log configuration
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #4467:
URL: https://github.com/apache/apisix/pull/4467#issuecomment-951786052
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] github-actions[bot] closed pull request #4467: feat: extend current access log configuration
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #4467:
URL: https://github.com/apache/apisix/pull/4467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #4467: Add access_log config item in config.yaml
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #4467:
URL: https://github.com/apache/apisix/pull/4467#issuecomment-866627695
@Yullin
You can push another commit to your apache-master branch instead of creating new PR like https://github.com/apache/apisix/pull/4471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on pull request #4467: feat: extend current access log configuration
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #4467:
URL: https://github.com/apache/apisix/pull/4467#issuecomment-927720936
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org