You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by hn...@apache.org on 2022/04/01 09:09:44 UTC
[myfaces-tobago] 01/02: fix: arrow down on dropdown component
This is an automated email from the ASF dual-hosted git repository.
hnoeth pushed a commit to branch tobago-5.x
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git
commit d58c244a84ae9f4e28c16ddac2a4f2445d149302
Author: Henning Noeth <hn...@apache.org>
AuthorDate: Fri Apr 1 10:31:46 2022 +0200
fix: arrow down on dropdown component
* use correct Bootstrap CSS class
* adjust test
Issue: TOBAGO-2123
---
.../tobago/internal/renderkit/renderer/SelectOneChoiceRenderer.java | 2 +-
.../test/resources/renderer/selectOneChoice/selectOneChoiceLabel.html | 4 ++--
tobago-theme/src/main/scss/_tobago.scss | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectOneChoiceRenderer.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectOneChoiceRenderer.java
index 81c4faa..589f6af 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectOneChoiceRenderer.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectOneChoiceRenderer.java
@@ -80,7 +80,7 @@ public class SelectOneChoiceRenderer<T extends AbstractUISelectOneChoice> extend
writer.writeAttribute(HtmlAttributes.TABINDEX, component.getTabIndex());
writer.writeClassAttribute(
- isInside(facesContext, HtmlElements.TOBAGO_IN) ? BootstrapClass.FORM_SELECT : BootstrapClass.FORM_CONTROL,
+ BootstrapClass.FORM_SELECT,
BootstrapClass.borderColor(ComponentUtils.getMaximumSeverity(component)),
component.getCustomClass());
if (title != null) {
diff --git a/tobago-core/src/test/resources/renderer/selectOneChoice/selectOneChoiceLabel.html b/tobago-core/src/test/resources/renderer/selectOneChoice/selectOneChoiceLabel.html
index 6d75f42..768d82b 100644
--- a/tobago-core/src/test/resources/renderer/selectOneChoice/selectOneChoiceLabel.html
+++ b/tobago-core/src/test/resources/renderer/selectOneChoice/selectOneChoiceLabel.html
@@ -17,9 +17,9 @@
<tobago-select-one-choice id='id' class='tobago-label-container tobago-auto-spacing'>
<label for='id::field' class='col-form-label'>label</label>
- <select id='id::field' name='id' class='form-control'>
+ <select id='id::field' name='id' class='form-select'>
<option value=''>Stratocaster
</option>
<option value=''>Telecaster
</option></select>
-</tobago-select-one-choice>
\ No newline at end of file
+</tobago-select-one-choice>
diff --git a/tobago-theme/src/main/scss/_tobago.scss b/tobago-theme/src/main/scss/_tobago.scss
index 29567f9..7d25742 100644
--- a/tobago-theme/src/main/scss/_tobago.scss
+++ b/tobago-theme/src/main/scss/_tobago.scss
@@ -400,7 +400,7 @@ tobago-flex-layout {
}
> {
- .form-control, .form-control-plaintext,
+ .form-control, .form-select, .form-control-plaintext,
.input-group, .tobago-messages-container {
flex: 1 0 0px;
}