[jira] [Commented] (HIVE-18084) Upgrade checkstyle version to support lambdas

["Adam Szita (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-18084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255536#comment-16255536 ] 

Adam Szita commented on HIVE-18084:
-----------------------------------

I have found that upgrading to version 2.15 will take care of our problem with lambdas and it also doesn't introduce much difference in results.

I ran checkstyle on Hive with both versions and diffed the results. Among the differences the most frequent entries seen are like:

{{warning: method def rparen at indentation level 6 not at correct indentation, 2}}
vs
{{warning: 'method def rparen' have incorrect indentation level 6, expected level should be 2.}}
so no semantical difference..

The next big difference category is related to files containing lambdas, these files were completely skipped before, and now they obviously generate a lot of checkstyle warnings.

The rest I think is irrelevant, I uploaded the whole diff here: [^diff.txt].

(Note that storage-api module produces a lot of errors (>5k), that is because it's missing checkstyle configs, I'll address that in another jira..)

[~alangates] please let me know what you think.

> Upgrade checkstyle version to support lambdas
> ---------------------------------------------
>
>                 Key: HIVE-18084
>                 URL: https://issues.apache.org/jira/browse/HIVE-18084
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Adam Szita
>            Assignee: Adam Szita
>         Attachments: HIVE-18084.0.patch, diff.txt
>
>
> Current version does not support lambdas in source files so it skips them. We need to upgrade checkstyle version to fix this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)