You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Philippe Mouawad <ph...@gmail.com> on 2019/03/08 20:53:19 UTC

Re: Release 5.1.1

Hello Milamber, Felix,
If you are still ok to release, could you test the HTML report generation
feature on your side ?
I have completed  tests on my side.

Thanks





On Thu, Feb 28, 2019 at 8:53 PM Felix Schumacher <
felix.schumacher@internetallee.de> wrote:

>
> Am 28.02.19 um 07:48 schrieb Milamber:
> > Philippe,
> >
> > If that needed, then we can try to create the RC1 for 5.1.1 the
> > weekend of 9th march?
>
> Would be OK with me.
>
>   Felix
>
>
> >
> > Milamber
> >
> > On 25/02/2019 17:13, Philippe Mouawad wrote:
> >> Hello,
> >> Second reason:
> >> https://bz.apache.org/bugzilla/show_bug.cgi?id=63207
> >>
> >> Regards
> >>
> >> On Sat, Feb 23, 2019 at 2:49 PM Philippe Mouawad
> >> <ph...@gmail.com>
> >> wrote:
> >>
> >>> Hello,
> >>> There is a regression since 5.0 that was only reported after release
> >>> of 5.1
> >>>
> >>> It's 63198 and affects two graphs in HTML report.
> >>>
> >>> IMO, we should release a minor version for it as it affects an
> >>> important
> >>> component of JMeter.
> >>>
> >>> What's your opinion ?
> >>>
> >>> Regards
> >>> Philippe
> >>>
> >>
> >
>


-- 
Cordialement.
Philippe Mouawad.

Re: Release 5.1.1

Posted by Philippe Mouawad <ph...@gmail.com>.
Thanks Felix

On Saturday, March 9, 2019, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:

>
> Am 09.03.19 um 09:30 schrieb Philippe Mouawad:
>
>> Hello Felix,
>> Ok in this case I am not sure I’ll have time to fix it this weekend.
>> If anybody wants to they’re welcome.
>>
>
> I am looking at it.
>
> Felix
>
>
>> Regards
>>
>> On Saturday, March 9, 2019, Felix Schumacher <
>> felix.schumacher@internetallee.de> wrote:
>>
>>
>>> Am 9. März 2019 00:05:50 MEZ schrieb Philippe Mouawad <
>>> philippe.mouawad@gmail.com>:
>>>
>>>> On Sat, Mar 9, 2019 at 12:04 AM sebb <se...@gmail.com> wrote:
>>>>
>>>> On Fri, 8 Mar 2019 at 22:37, Philippe Mouawad
>>>>> <ph...@gmail.com> wrote:
>>>>>
>>>>>> The Window build is failing due to separator being different
>>>>>>
>>>>> between
>>>>
>>>>> Linux
>>>>>
>>>>>> and Windows.
>>>>>> It's a false positive
>>>>>>
>>>>> Surely the test should be able to run OK on either Windows or Linux?
>>>>>
>>>>> Seems to me this a bug in the test.
>>>>>
>>>>> That's what I am saying
>>>> Bug is in path comparison
>>>>
>>> I read sebb's answer as: the test code has to be fixed before a release.
>>>
>>> Felix
>>>
>>> On Fri, Mar 8, 2019 at 9:53 PM Philippe Mouawad <
>>>>>>
>>>>> philippe.mouawad@gmail.com>
>>>>>
>>>>>> wrote:
>>>>>>
>>>>>> Hello Milamber, Felix,
>>>>>>> If you are still ok to release, could you test the HTML report
>>>>>>>
>>>>>> generation
>>>>>
>>>>>> feature on your side ?
>>>>>>> I have completed  tests on my side.
>>>>>>>
>>>>>>> Thanks
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Thu, Feb 28, 2019 at 8:53 PM Felix Schumacher <
>>>>>>> felix.schumacher@internetallee.de> wrote:
>>>>>>>
>>>>>>> Am 28.02.19 um 07:48 schrieb Milamber:
>>>>>>>>
>>>>>>>>> Philippe,
>>>>>>>>>
>>>>>>>>> If that needed, then we can try to create the RC1 for 5.1.1
>>>>>>>>>
>>>>>>>> the
>>>>
>>>>> weekend of 9th march?
>>>>>>>>>
>>>>>>>> Would be OK with me.
>>>>>>>>
>>>>>>>>    Felix
>>>>>>>>
>>>>>>>>
>>>>>>>> Milamber
>>>>>>>>>
>>>>>>>>> On 25/02/2019 17:13, Philippe Mouawad wrote:
>>>>>>>>>
>>>>>>>>>> Hello,
>>>>>>>>>> Second reason:
>>>>>>>>>> https://bz.apache.org/bugzilla/show_bug.cgi?id=63207
>>>>>>>>>>
>>>>>>>>>> Regards
>>>>>>>>>>
>>>>>>>>>> On Sat, Feb 23, 2019 at 2:49 PM Philippe Mouawad
>>>>>>>>>> <ph...@gmail.com>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>> Hello,
>>>>>>>>>>> There is a regression since 5.0 that was only reported after
>>>>>>>>>>>
>>>>>>>>>> release
>>>>>
>>>>>> of 5.1
>>>>>>>>>>>
>>>>>>>>>>> It's 63198 and affects two graphs in HTML report.
>>>>>>>>>>>
>>>>>>>>>>> IMO, we should release a minor version for it as it affects
>>>>>>>>>>>
>>>>>>>>>> an
>>>>
>>>>> important
>>>>>>>>>>> component of JMeter.
>>>>>>>>>>>
>>>>>>>>>>> What's your opinion ?
>>>>>>>>>>>
>>>>>>>>>>> Regards
>>>>>>>>>>> Philippe
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>> --
>>>>>>> Cordialement.
>>>>>>> Philippe Mouawad.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>> Cordialement.
>>>>>> Philippe Mouawad.
>>>>>>
>>>>>
>>

-- 
Cordialement.
Philippe Mouawad.

Re: Release 5.1.1

Posted by Felix Schumacher <fe...@internetallee.de>.
Am 09.03.19 um 09:30 schrieb Philippe Mouawad:
> Hello Felix,
> Ok in this case I am not sure I’ll have time to fix it this weekend.
> If anybody wants to they’re welcome.

I am looking at it.

Felix

>
> Regards
>
> On Saturday, March 9, 2019, Felix Schumacher <
> felix.schumacher@internetallee.de> wrote:
>
>>
>> Am 9. März 2019 00:05:50 MEZ schrieb Philippe Mouawad <
>> philippe.mouawad@gmail.com>:
>>> On Sat, Mar 9, 2019 at 12:04 AM sebb <se...@gmail.com> wrote:
>>>
>>>> On Fri, 8 Mar 2019 at 22:37, Philippe Mouawad
>>>> <ph...@gmail.com> wrote:
>>>>> The Window build is failing due to separator being different
>>> between
>>>> Linux
>>>>> and Windows.
>>>>> It's a false positive
>>>> Surely the test should be able to run OK on either Windows or Linux?
>>>>
>>>> Seems to me this a bug in the test.
>>>>
>>> That's what I am saying
>>> Bug is in path comparison
>> I read sebb's answer as: the test code has to be fixed before a release.
>>
>> Felix
>>
>>>>> On Fri, Mar 8, 2019 at 9:53 PM Philippe Mouawad <
>>>> philippe.mouawad@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> Hello Milamber, Felix,
>>>>>> If you are still ok to release, could you test the HTML report
>>>> generation
>>>>>> feature on your side ?
>>>>>> I have completed  tests on my side.
>>>>>>
>>>>>> Thanks
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Thu, Feb 28, 2019 at 8:53 PM Felix Schumacher <
>>>>>> felix.schumacher@internetallee.de> wrote:
>>>>>>
>>>>>>> Am 28.02.19 um 07:48 schrieb Milamber:
>>>>>>>> Philippe,
>>>>>>>>
>>>>>>>> If that needed, then we can try to create the RC1 for 5.1.1
>>> the
>>>>>>>> weekend of 9th march?
>>>>>>> Would be OK with me.
>>>>>>>
>>>>>>>    Felix
>>>>>>>
>>>>>>>
>>>>>>>> Milamber
>>>>>>>>
>>>>>>>> On 25/02/2019 17:13, Philippe Mouawad wrote:
>>>>>>>>> Hello,
>>>>>>>>> Second reason:
>>>>>>>>> https://bz.apache.org/bugzilla/show_bug.cgi?id=63207
>>>>>>>>>
>>>>>>>>> Regards
>>>>>>>>>
>>>>>>>>> On Sat, Feb 23, 2019 at 2:49 PM Philippe Mouawad
>>>>>>>>> <ph...@gmail.com>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> Hello,
>>>>>>>>>> There is a regression since 5.0 that was only reported after
>>>> release
>>>>>>>>>> of 5.1
>>>>>>>>>>
>>>>>>>>>> It's 63198 and affects two graphs in HTML report.
>>>>>>>>>>
>>>>>>>>>> IMO, we should release a minor version for it as it affects
>>> an
>>>>>>>>>> important
>>>>>>>>>> component of JMeter.
>>>>>>>>>>
>>>>>>>>>> What's your opinion ?
>>>>>>>>>>
>>>>>>>>>> Regards
>>>>>>>>>> Philippe
>>>>>>>>>>
>>>>>>
>>>>>> --
>>>>>> Cordialement.
>>>>>> Philippe Mouawad.
>>>>>>
>>>>>>
>>>>>>
>>>>> --
>>>>> Cordialement.
>>>>> Philippe Mouawad.
>

Re: Release 5.1.1

Posted by Philippe Mouawad <ph...@gmail.com>.
Hello Felix,
Ok in this case I am not sure I’ll have time to fix it this weekend.
If anybody wants to they’re welcome.

Regards

On Saturday, March 9, 2019, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:

>
>
> Am 9. März 2019 00:05:50 MEZ schrieb Philippe Mouawad <
> philippe.mouawad@gmail.com>:
> >On Sat, Mar 9, 2019 at 12:04 AM sebb <se...@gmail.com> wrote:
> >
> >> On Fri, 8 Mar 2019 at 22:37, Philippe Mouawad
> >> <ph...@gmail.com> wrote:
> >> >
> >> > The Window build is failing due to separator being different
> >between
> >> Linux
> >> > and Windows.
> >> > It's a false positive
> >>
> >> Surely the test should be able to run OK on either Windows or Linux?
> >>
> >> Seems to me this a bug in the test.
> >>
> >That's what I am saying
> >Bug is in path comparison
>
> I read sebb's answer as: the test code has to be fixed before a release.
>
> Felix
>
> >
> >>
> >> > On Fri, Mar 8, 2019 at 9:53 PM Philippe Mouawad <
> >> philippe.mouawad@gmail.com>
> >> > wrote:
> >> >
> >> > > Hello Milamber, Felix,
> >> > > If you are still ok to release, could you test the HTML report
> >> generation
> >> > > feature on your side ?
> >> > > I have completed  tests on my side.
> >> > >
> >> > > Thanks
> >> > >
> >> > >
> >> > >
> >> > >
> >> > >
> >> > > On Thu, Feb 28, 2019 at 8:53 PM Felix Schumacher <
> >> > > felix.schumacher@internetallee.de> wrote:
> >> > >
> >> > >>
> >> > >> Am 28.02.19 um 07:48 schrieb Milamber:
> >> > >> > Philippe,
> >> > >> >
> >> > >> > If that needed, then we can try to create the RC1 for 5.1.1
> >the
> >> > >> > weekend of 9th march?
> >> > >>
> >> > >> Would be OK with me.
> >> > >>
> >> > >>   Felix
> >> > >>
> >> > >>
> >> > >> >
> >> > >> > Milamber
> >> > >> >
> >> > >> > On 25/02/2019 17:13, Philippe Mouawad wrote:
> >> > >> >> Hello,
> >> > >> >> Second reason:
> >> > >> >> https://bz.apache.org/bugzilla/show_bug.cgi?id=63207
> >> > >> >>
> >> > >> >> Regards
> >> > >> >>
> >> > >> >> On Sat, Feb 23, 2019 at 2:49 PM Philippe Mouawad
> >> > >> >> <ph...@gmail.com>
> >> > >> >> wrote:
> >> > >> >>
> >> > >> >>> Hello,
> >> > >> >>> There is a regression since 5.0 that was only reported after
> >> release
> >> > >> >>> of 5.1
> >> > >> >>>
> >> > >> >>> It's 63198 and affects two graphs in HTML report.
> >> > >> >>>
> >> > >> >>> IMO, we should release a minor version for it as it affects
> >an
> >> > >> >>> important
> >> > >> >>> component of JMeter.
> >> > >> >>>
> >> > >> >>> What's your opinion ?
> >> > >> >>>
> >> > >> >>> Regards
> >> > >> >>> Philippe
> >> > >> >>>
> >> > >> >>
> >> > >> >
> >> > >>
> >> > >
> >> > >
> >> > > --
> >> > > Cordialement.
> >> > > Philippe Mouawad.
> >> > >
> >> > >
> >> > >
> >> >
> >> > --
> >> > Cordialement.
> >> > Philippe Mouawad.
> >>
>


-- 
Cordialement.
Philippe Mouawad.

Re: Release 5.1.1

Posted by sebb <se...@gmail.com>.
On Sat, 9 Mar 2019 at 08:08, Felix Schumacher
<fe...@internetallee.de> wrote:
>
>
>
> Am 9. März 2019 00:05:50 MEZ schrieb Philippe Mouawad <ph...@gmail.com>:
> >On Sat, Mar 9, 2019 at 12:04 AM sebb <se...@gmail.com> wrote:
> >
> >> On Fri, 8 Mar 2019 at 22:37, Philippe Mouawad
> >> <ph...@gmail.com> wrote:
> >> >
> >> > The Window build is failing due to separator being different
> >between
> >> Linux
> >> > and Windows.
> >> > It's a false positive
> >>
> >> Surely the test should be able to run OK on either Windows or Linux?
> >>
> >> Seems to me this a bug in the test.
> >>
> >That's what I am saying
> >Bug is in path comparison
>
> I read sebb's answer as: the test code has to be fixed before a release.

Yes, that's what I meant.

I read Philippe's mail as implying that nothing needed to be done.

However I now see it can be read differently.

> Felix
>
> >
> >>
> >> > On Fri, Mar 8, 2019 at 9:53 PM Philippe Mouawad <
> >> philippe.mouawad@gmail.com>
> >> > wrote:
> >> >
> >> > > Hello Milamber, Felix,
> >> > > If you are still ok to release, could you test the HTML report
> >> generation
> >> > > feature on your side ?
> >> > > I have completed  tests on my side.
> >> > >
> >> > > Thanks
> >> > >
> >> > >
> >> > >
> >> > >
> >> > >
> >> > > On Thu, Feb 28, 2019 at 8:53 PM Felix Schumacher <
> >> > > felix.schumacher@internetallee.de> wrote:
> >> > >
> >> > >>
> >> > >> Am 28.02.19 um 07:48 schrieb Milamber:
> >> > >> > Philippe,
> >> > >> >
> >> > >> > If that needed, then we can try to create the RC1 for 5.1.1
> >the
> >> > >> > weekend of 9th march?
> >> > >>
> >> > >> Would be OK with me.
> >> > >>
> >> > >>   Felix
> >> > >>
> >> > >>
> >> > >> >
> >> > >> > Milamber
> >> > >> >
> >> > >> > On 25/02/2019 17:13, Philippe Mouawad wrote:
> >> > >> >> Hello,
> >> > >> >> Second reason:
> >> > >> >> https://bz.apache.org/bugzilla/show_bug.cgi?id=63207
> >> > >> >>
> >> > >> >> Regards
> >> > >> >>
> >> > >> >> On Sat, Feb 23, 2019 at 2:49 PM Philippe Mouawad
> >> > >> >> <ph...@gmail.com>
> >> > >> >> wrote:
> >> > >> >>
> >> > >> >>> Hello,
> >> > >> >>> There is a regression since 5.0 that was only reported after
> >> release
> >> > >> >>> of 5.1
> >> > >> >>>
> >> > >> >>> It's 63198 and affects two graphs in HTML report.
> >> > >> >>>
> >> > >> >>> IMO, we should release a minor version for it as it affects
> >an
> >> > >> >>> important
> >> > >> >>> component of JMeter.
> >> > >> >>>
> >> > >> >>> What's your opinion ?
> >> > >> >>>
> >> > >> >>> Regards
> >> > >> >>> Philippe
> >> > >> >>>
> >> > >> >>
> >> > >> >
> >> > >>
> >> > >
> >> > >
> >> > > --
> >> > > Cordialement.
> >> > > Philippe Mouawad.
> >> > >
> >> > >
> >> > >
> >> >
> >> > --
> >> > Cordialement.
> >> > Philippe Mouawad.
> >>

Re: Release 5.1.1

Posted by Felix Schumacher <fe...@internetallee.de>.

Am 9. März 2019 00:05:50 MEZ schrieb Philippe Mouawad <ph...@gmail.com>:
>On Sat, Mar 9, 2019 at 12:04 AM sebb <se...@gmail.com> wrote:
>
>> On Fri, 8 Mar 2019 at 22:37, Philippe Mouawad
>> <ph...@gmail.com> wrote:
>> >
>> > The Window build is failing due to separator being different
>between
>> Linux
>> > and Windows.
>> > It's a false positive
>>
>> Surely the test should be able to run OK on either Windows or Linux?
>>
>> Seems to me this a bug in the test.
>>
>That's what I am saying
>Bug is in path comparison

I read sebb's answer as: the test code has to be fixed before a release.

Felix 

>
>>
>> > On Fri, Mar 8, 2019 at 9:53 PM Philippe Mouawad <
>> philippe.mouawad@gmail.com>
>> > wrote:
>> >
>> > > Hello Milamber, Felix,
>> > > If you are still ok to release, could you test the HTML report
>> generation
>> > > feature on your side ?
>> > > I have completed  tests on my side.
>> > >
>> > > Thanks
>> > >
>> > >
>> > >
>> > >
>> > >
>> > > On Thu, Feb 28, 2019 at 8:53 PM Felix Schumacher <
>> > > felix.schumacher@internetallee.de> wrote:
>> > >
>> > >>
>> > >> Am 28.02.19 um 07:48 schrieb Milamber:
>> > >> > Philippe,
>> > >> >
>> > >> > If that needed, then we can try to create the RC1 for 5.1.1
>the
>> > >> > weekend of 9th march?
>> > >>
>> > >> Would be OK with me.
>> > >>
>> > >>   Felix
>> > >>
>> > >>
>> > >> >
>> > >> > Milamber
>> > >> >
>> > >> > On 25/02/2019 17:13, Philippe Mouawad wrote:
>> > >> >> Hello,
>> > >> >> Second reason:
>> > >> >> https://bz.apache.org/bugzilla/show_bug.cgi?id=63207
>> > >> >>
>> > >> >> Regards
>> > >> >>
>> > >> >> On Sat, Feb 23, 2019 at 2:49 PM Philippe Mouawad
>> > >> >> <ph...@gmail.com>
>> > >> >> wrote:
>> > >> >>
>> > >> >>> Hello,
>> > >> >>> There is a regression since 5.0 that was only reported after
>> release
>> > >> >>> of 5.1
>> > >> >>>
>> > >> >>> It's 63198 and affects two graphs in HTML report.
>> > >> >>>
>> > >> >>> IMO, we should release a minor version for it as it affects
>an
>> > >> >>> important
>> > >> >>> component of JMeter.
>> > >> >>>
>> > >> >>> What's your opinion ?
>> > >> >>>
>> > >> >>> Regards
>> > >> >>> Philippe
>> > >> >>>
>> > >> >>
>> > >> >
>> > >>
>> > >
>> > >
>> > > --
>> > > Cordialement.
>> > > Philippe Mouawad.
>> > >
>> > >
>> > >
>> >
>> > --
>> > Cordialement.
>> > Philippe Mouawad.
>>

Re: Release 5.1.1

Posted by Philippe Mouawad <ph...@gmail.com>.
On Sat, Mar 9, 2019 at 12:04 AM sebb <se...@gmail.com> wrote:

> On Fri, 8 Mar 2019 at 22:37, Philippe Mouawad
> <ph...@gmail.com> wrote:
> >
> > The Window build is failing due to separator being different between
> Linux
> > and Windows.
> > It's a false positive
>
> Surely the test should be able to run OK on either Windows or Linux?
>
> Seems to me this a bug in the test.
>
That's what I am saying
Bug is in path comparison

>
> > On Fri, Mar 8, 2019 at 9:53 PM Philippe Mouawad <
> philippe.mouawad@gmail.com>
> > wrote:
> >
> > > Hello Milamber, Felix,
> > > If you are still ok to release, could you test the HTML report
> generation
> > > feature on your side ?
> > > I have completed  tests on my side.
> > >
> > > Thanks
> > >
> > >
> > >
> > >
> > >
> > > On Thu, Feb 28, 2019 at 8:53 PM Felix Schumacher <
> > > felix.schumacher@internetallee.de> wrote:
> > >
> > >>
> > >> Am 28.02.19 um 07:48 schrieb Milamber:
> > >> > Philippe,
> > >> >
> > >> > If that needed, then we can try to create the RC1 for 5.1.1 the
> > >> > weekend of 9th march?
> > >>
> > >> Would be OK with me.
> > >>
> > >>   Felix
> > >>
> > >>
> > >> >
> > >> > Milamber
> > >> >
> > >> > On 25/02/2019 17:13, Philippe Mouawad wrote:
> > >> >> Hello,
> > >> >> Second reason:
> > >> >> https://bz.apache.org/bugzilla/show_bug.cgi?id=63207
> > >> >>
> > >> >> Regards
> > >> >>
> > >> >> On Sat, Feb 23, 2019 at 2:49 PM Philippe Mouawad
> > >> >> <ph...@gmail.com>
> > >> >> wrote:
> > >> >>
> > >> >>> Hello,
> > >> >>> There is a regression since 5.0 that was only reported after
> release
> > >> >>> of 5.1
> > >> >>>
> > >> >>> It's 63198 and affects two graphs in HTML report.
> > >> >>>
> > >> >>> IMO, we should release a minor version for it as it affects an
> > >> >>> important
> > >> >>> component of JMeter.
> > >> >>>
> > >> >>> What's your opinion ?
> > >> >>>
> > >> >>> Regards
> > >> >>> Philippe
> > >> >>>
> > >> >>
> > >> >
> > >>
> > >
> > >
> > > --
> > > Cordialement.
> > > Philippe Mouawad.
> > >
> > >
> > >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
>


-- 
Cordialement.
Philippe Mouawad.

Re: Release 5.1.1

Posted by sebb <se...@gmail.com>.
On Fri, 8 Mar 2019 at 22:37, Philippe Mouawad
<ph...@gmail.com> wrote:
>
> The Window build is failing due to separator being different between Linux
> and Windows.
> It's a false positive

Surely the test should be able to run OK on either Windows or Linux?

Seems to me this a bug in the test.

> On Fri, Mar 8, 2019 at 9:53 PM Philippe Mouawad <ph...@gmail.com>
> wrote:
>
> > Hello Milamber, Felix,
> > If you are still ok to release, could you test the HTML report generation
> > feature on your side ?
> > I have completed  tests on my side.
> >
> > Thanks
> >
> >
> >
> >
> >
> > On Thu, Feb 28, 2019 at 8:53 PM Felix Schumacher <
> > felix.schumacher@internetallee.de> wrote:
> >
> >>
> >> Am 28.02.19 um 07:48 schrieb Milamber:
> >> > Philippe,
> >> >
> >> > If that needed, then we can try to create the RC1 for 5.1.1 the
> >> > weekend of 9th march?
> >>
> >> Would be OK with me.
> >>
> >>   Felix
> >>
> >>
> >> >
> >> > Milamber
> >> >
> >> > On 25/02/2019 17:13, Philippe Mouawad wrote:
> >> >> Hello,
> >> >> Second reason:
> >> >> https://bz.apache.org/bugzilla/show_bug.cgi?id=63207
> >> >>
> >> >> Regards
> >> >>
> >> >> On Sat, Feb 23, 2019 at 2:49 PM Philippe Mouawad
> >> >> <ph...@gmail.com>
> >> >> wrote:
> >> >>
> >> >>> Hello,
> >> >>> There is a regression since 5.0 that was only reported after release
> >> >>> of 5.1
> >> >>>
> >> >>> It's 63198 and affects two graphs in HTML report.
> >> >>>
> >> >>> IMO, we should release a minor version for it as it affects an
> >> >>> important
> >> >>> component of JMeter.
> >> >>>
> >> >>> What's your opinion ?
> >> >>>
> >> >>> Regards
> >> >>> Philippe
> >> >>>
> >> >>
> >> >
> >>
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
> >
> >
> >
>
> --
> Cordialement.
> Philippe Mouawad.

Re: Release 5.1.1

Posted by Philippe Mouawad <ph...@gmail.com>.
The Window build is failing due to separator being different between Linux
and Windows.
It's a false positive

On Fri, Mar 8, 2019 at 9:53 PM Philippe Mouawad <ph...@gmail.com>
wrote:

> Hello Milamber, Felix,
> If you are still ok to release, could you test the HTML report generation
> feature on your side ?
> I have completed  tests on my side.
>
> Thanks
>
>
>
>
>
> On Thu, Feb 28, 2019 at 8:53 PM Felix Schumacher <
> felix.schumacher@internetallee.de> wrote:
>
>>
>> Am 28.02.19 um 07:48 schrieb Milamber:
>> > Philippe,
>> >
>> > If that needed, then we can try to create the RC1 for 5.1.1 the
>> > weekend of 9th march?
>>
>> Would be OK with me.
>>
>>   Felix
>>
>>
>> >
>> > Milamber
>> >
>> > On 25/02/2019 17:13, Philippe Mouawad wrote:
>> >> Hello,
>> >> Second reason:
>> >> https://bz.apache.org/bugzilla/show_bug.cgi?id=63207
>> >>
>> >> Regards
>> >>
>> >> On Sat, Feb 23, 2019 at 2:49 PM Philippe Mouawad
>> >> <ph...@gmail.com>
>> >> wrote:
>> >>
>> >>> Hello,
>> >>> There is a regression since 5.0 that was only reported after release
>> >>> of 5.1
>> >>>
>> >>> It's 63198 and affects two graphs in HTML report.
>> >>>
>> >>> IMO, we should release a minor version for it as it affects an
>> >>> important
>> >>> component of JMeter.
>> >>>
>> >>> What's your opinion ?
>> >>>
>> >>> Regards
>> >>> Philippe
>> >>>
>> >>
>> >
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>

-- 
Cordialement.
Philippe Mouawad.

Re: Release 5.1.1

Posted by Philippe Mouawad <ph...@gmail.com>.
Hi,
Since it’s close to 5.1 and mostly a bug fix, 5.1.1 is ok.

Usually our X.Y version are major ones, here it’s not.



Regards

On Saturday, March 9, 2019, Milamber <mi...@apache.org> wrote:

> Hello,
>
> Next version will be 5.1.1 or 5.2 ?
>
> The new Html report generation works on my machine (Linux Debian 9 with
> Oracle Java 8 and Java 11)
>
> But the green color on the Generate button isn't very beautiful (see:
> https://i.imgur.com/L6rW2fZ.png)
>
> Milamber
>
> On 08/03/2019 21:53, Philippe Mouawad wrote:
>
>> Hello Milamber, Felix,
>> If you are still ok to release, could you test the HTML report generation
>> feature on your side ?
>> I have completed  tests on my side.
>>
>> Thanks
>>
>>
>>
>>
>>
>> On Thu, Feb 28, 2019 at 8:53 PM Felix Schumacher <
>> felix.schumacher@internetallee.de> wrote:
>>
>> Am 28.02.19 um 07:48 schrieb Milamber:
>>>
>>>> Philippe,
>>>>
>>>> If that needed, then we can try to create the RC1 for 5.1.1 the
>>>> weekend of 9th march?
>>>>
>>> Would be OK with me.
>>>
>>>    Felix
>>>
>>>
>>> Milamber
>>>>
>>>> On 25/02/2019 17:13, Philippe Mouawad wrote:
>>>>
>>>>> Hello,
>>>>> Second reason:
>>>>> https://bz.apache.org/bugzilla/show_bug.cgi?id=63207
>>>>>
>>>>> Regards
>>>>>
>>>>> On Sat, Feb 23, 2019 at 2:49 PM Philippe Mouawad
>>>>> <ph...@gmail.com>
>>>>> wrote:
>>>>>
>>>>> Hello,
>>>>>> There is a regression since 5.0 that was only reported after release
>>>>>> of 5.1
>>>>>>
>>>>>> It's 63198 and affects two graphs in HTML report.
>>>>>>
>>>>>> IMO, we should release a minor version for it as it affects an
>>>>>> important
>>>>>> component of JMeter.
>>>>>>
>>>>>> What's your opinion ?
>>>>>>
>>>>>> Regards
>>>>>> Philippe
>>>>>>
>>>>>>
>>
>

-- 
Cordialement.
Philippe Mouawad.

Re: Release 5.1.1

Posted by Milamber <mi...@apache.org>.
Looks good now with image. Thank you

On 09/03/2019 15:42, Philippe Mouawad wrote:
> Indeed it looks bad.
>
> The idea was to show error.
> I tried to improve it.
> A gif for throbber would be more clear but I don't have item
>
> Regards
>
>
>
>
>
> On Sat, Mar 9, 2019 at 2:59 PM Felix Schumacher <
> felix.schumacher@internetallee.de> wrote:
>
>> Am 09.03.19 um 14:48 schrieb Milamber:
>>> Hello,
>>>
>>> Next version will be 5.1.1 or 5.2 ?
>>>
>>> The new Html report generation works on my machine (Linux Debian 9
>>> with Oracle Java 8 and Java 11)
>>>
>>> But the green color on the Generate button isn't very beautiful (see:
>>> https://i.imgur.com/L6rW2fZ.png)
>> I would say, it is rather unreadable. Do we really have to use colors
>> there?
>>
>> Felix
>>
>>> Milamber
>>>
>>> On 08/03/2019 21:53, Philippe Mouawad wrote:
>>>> Hello Milamber, Felix,
>>>> If you are still ok to release, could you test the HTML report
>>>> generation
>>>> feature on your side ?
>>>> I have completed  tests on my side.
>>>>
>>>> Thanks
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> On Thu, Feb 28, 2019 at 8:53 PM Felix Schumacher <
>>>> felix.schumacher@internetallee.de> wrote:
>>>>
>>>>> Am 28.02.19 um 07:48 schrieb Milamber:
>>>>>> Philippe,
>>>>>>
>>>>>> If that needed, then we can try to create the RC1 for 5.1.1 the
>>>>>> weekend of 9th march?
>>>>> Would be OK with me.
>>>>>
>>>>>     Felix
>>>>>
>>>>>
>>>>>> Milamber
>>>>>>
>>>>>> On 25/02/2019 17:13, Philippe Mouawad wrote:
>>>>>>> Hello,
>>>>>>> Second reason:
>>>>>>> https://bz.apache.org/bugzilla/show_bug.cgi?id=63207
>>>>>>>
>>>>>>> Regards
>>>>>>>
>>>>>>> On Sat, Feb 23, 2019 at 2:49 PM Philippe Mouawad
>>>>>>> <ph...@gmail.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Hello,
>>>>>>>> There is a regression since 5.0 that was only reported after release
>>>>>>>> of 5.1
>>>>>>>>
>>>>>>>> It's 63198 and affects two graphs in HTML report.
>>>>>>>>
>>>>>>>> IMO, we should release a minor version for it as it affects an
>>>>>>>> important
>>>>>>>> component of JMeter.
>>>>>>>>
>>>>>>>> What's your opinion ?
>>>>>>>>
>>>>>>>> Regards
>>>>>>>> Philippe
>>>>>>>>
>


Re: Release 5.1.1

Posted by Philippe Mouawad <ph...@gmail.com>.
Indeed it looks bad.

The idea was to show error.
I tried to improve it.
A gif for throbber would be more clear but I don't have item

Regards





On Sat, Mar 9, 2019 at 2:59 PM Felix Schumacher <
felix.schumacher@internetallee.de> wrote:

>
> Am 09.03.19 um 14:48 schrieb Milamber:
> > Hello,
> >
> > Next version will be 5.1.1 or 5.2 ?
> >
> > The new Html report generation works on my machine (Linux Debian 9
> > with Oracle Java 8 and Java 11)
> >
> > But the green color on the Generate button isn't very beautiful (see:
> > https://i.imgur.com/L6rW2fZ.png)
>
> I would say, it is rather unreadable. Do we really have to use colors
> there?
>
> Felix
>
> >
> > Milamber
> >
> > On 08/03/2019 21:53, Philippe Mouawad wrote:
> >> Hello Milamber, Felix,
> >> If you are still ok to release, could you test the HTML report
> >> generation
> >> feature on your side ?
> >> I have completed  tests on my side.
> >>
> >> Thanks
> >>
> >>
> >>
> >>
> >>
> >> On Thu, Feb 28, 2019 at 8:53 PM Felix Schumacher <
> >> felix.schumacher@internetallee.de> wrote:
> >>
> >>> Am 28.02.19 um 07:48 schrieb Milamber:
> >>>> Philippe,
> >>>>
> >>>> If that needed, then we can try to create the RC1 for 5.1.1 the
> >>>> weekend of 9th march?
> >>> Would be OK with me.
> >>>
> >>>    Felix
> >>>
> >>>
> >>>> Milamber
> >>>>
> >>>> On 25/02/2019 17:13, Philippe Mouawad wrote:
> >>>>> Hello,
> >>>>> Second reason:
> >>>>> https://bz.apache.org/bugzilla/show_bug.cgi?id=63207
> >>>>>
> >>>>> Regards
> >>>>>
> >>>>> On Sat, Feb 23, 2019 at 2:49 PM Philippe Mouawad
> >>>>> <ph...@gmail.com>
> >>>>> wrote:
> >>>>>
> >>>>>> Hello,
> >>>>>> There is a regression since 5.0 that was only reported after release
> >>>>>> of 5.1
> >>>>>>
> >>>>>> It's 63198 and affects two graphs in HTML report.
> >>>>>>
> >>>>>> IMO, we should release a minor version for it as it affects an
> >>>>>> important
> >>>>>> component of JMeter.
> >>>>>>
> >>>>>> What's your opinion ?
> >>>>>>
> >>>>>> Regards
> >>>>>> Philippe
> >>>>>>
> >>
> >
>


-- 
Cordialement.
Philippe Mouawad.

Re: Release 5.1.1

Posted by Felix Schumacher <fe...@internetallee.de>.
Am 09.03.19 um 14:48 schrieb Milamber:
> Hello,
>
> Next version will be 5.1.1 or 5.2 ?
>
> The new Html report generation works on my machine (Linux Debian 9 
> with Oracle Java 8 and Java 11)
>
> But the green color on the Generate button isn't very beautiful (see: 
> https://i.imgur.com/L6rW2fZ.png)

I would say, it is rather unreadable. Do we really have to use colors there?

Felix

>
> Milamber
>
> On 08/03/2019 21:53, Philippe Mouawad wrote:
>> Hello Milamber, Felix,
>> If you are still ok to release, could you test the HTML report 
>> generation
>> feature on your side ?
>> I have completed  tests on my side.
>>
>> Thanks
>>
>>
>>
>>
>>
>> On Thu, Feb 28, 2019 at 8:53 PM Felix Schumacher <
>> felix.schumacher@internetallee.de> wrote:
>>
>>> Am 28.02.19 um 07:48 schrieb Milamber:
>>>> Philippe,
>>>>
>>>> If that needed, then we can try to create the RC1 for 5.1.1 the
>>>> weekend of 9th march?
>>> Would be OK with me.
>>>
>>>    Felix
>>>
>>>
>>>> Milamber
>>>>
>>>> On 25/02/2019 17:13, Philippe Mouawad wrote:
>>>>> Hello,
>>>>> Second reason:
>>>>> https://bz.apache.org/bugzilla/show_bug.cgi?id=63207
>>>>>
>>>>> Regards
>>>>>
>>>>> On Sat, Feb 23, 2019 at 2:49 PM Philippe Mouawad
>>>>> <ph...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> Hello,
>>>>>> There is a regression since 5.0 that was only reported after release
>>>>>> of 5.1
>>>>>>
>>>>>> It's 63198 and affects two graphs in HTML report.
>>>>>>
>>>>>> IMO, we should release a minor version for it as it affects an
>>>>>> important
>>>>>> component of JMeter.
>>>>>>
>>>>>> What's your opinion ?
>>>>>>
>>>>>> Regards
>>>>>> Philippe
>>>>>>
>>
>

Re: Release 5.1.1

Posted by Milamber <mi...@apache.org>.
Hello,

Next version will be 5.1.1 or 5.2 ?

The new Html report generation works on my machine (Linux Debian 9 with 
Oracle Java 8 and Java 11)

But the green color on the Generate button isn't very beautiful (see: 
https://i.imgur.com/L6rW2fZ.png)

Milamber

On 08/03/2019 21:53, Philippe Mouawad wrote:
> Hello Milamber, Felix,
> If you are still ok to release, could you test the HTML report generation
> feature on your side ?
> I have completed  tests on my side.
>
> Thanks
>
>
>
>
>
> On Thu, Feb 28, 2019 at 8:53 PM Felix Schumacher <
> felix.schumacher@internetallee.de> wrote:
>
>> Am 28.02.19 um 07:48 schrieb Milamber:
>>> Philippe,
>>>
>>> If that needed, then we can try to create the RC1 for 5.1.1 the
>>> weekend of 9th march?
>> Would be OK with me.
>>
>>    Felix
>>
>>
>>> Milamber
>>>
>>> On 25/02/2019 17:13, Philippe Mouawad wrote:
>>>> Hello,
>>>> Second reason:
>>>> https://bz.apache.org/bugzilla/show_bug.cgi?id=63207
>>>>
>>>> Regards
>>>>
>>>> On Sat, Feb 23, 2019 at 2:49 PM Philippe Mouawad
>>>> <ph...@gmail.com>
>>>> wrote:
>>>>
>>>>> Hello,
>>>>> There is a regression since 5.0 that was only reported after release
>>>>> of 5.1
>>>>>
>>>>> It's 63198 and affects two graphs in HTML report.
>>>>>
>>>>> IMO, we should release a minor version for it as it affects an
>>>>> important
>>>>> component of JMeter.
>>>>>
>>>>> What's your opinion ?
>>>>>
>>>>> Regards
>>>>> Philippe
>>>>>
>