You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by "mihaibudiu (via GitHub)" <gi...@apache.org> on 2025/05/16 17:06:15 UTC

Re: [PR] [CALCITE-7017] Incorrect subquery rewriting in join conditions when j… [calcite]

mihaibudiu commented on code in PR #4382:
URL: https://github.com/apache/calcite/pull/4382#discussion_r2093408443


##########
core/src/main/java/org/apache/calcite/rel/rules/SubQueryRemoveRule.java:
##########
@@ -926,6 +923,11 @@ private static void matchJoin(SubQueryRemoveRule rule, RelOptRuleCall call) {
     if (inputIntersectsLeftSide) {
       builder.push(join.getLeft());
 
+      final RelOptUtil.Logic logic =

Review Comment:
   this code could use a little comment.
   (I am not familiar with this part of the code...)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org