You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/01 12:28:25 UTC

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2259: Remove fallibility from RLEEncoder (#2226)

tustvold commented on code in PR #2259:
URL: https://github.com/apache/arrow-rs/pull/2259#discussion_r934471293


##########
parquet/src/encodings/rle.rs:
##########
@@ -132,23 +132,21 @@ impl RleEncoder {
     }
 
     /// Encodes `value`, which must be representable with `bit_width` bits.
-    /// Returns true if the value fits in buffer, false if it doesn't, or

Review Comment:
   I am very happy to see this gone, it made for a very confusing interface imo



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org