[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #958: SCB-2176 Fix: raise err 'etcdserver: request too large' when list dep-queue key

[GitBox <gi...@apache.org>]

tianxiaoliang commented on a change in pull request #958:
URL: https://github.com/apache/servicecomb-service-center/pull/958#discussion_r620810005



##########
File path: server/core/backend/common.go
##########
@@ -90,7 +90,7 @@ func registerInnerTypes() {
 			WithInitSize(100).WithParser(proto.DependencyRuleParser)))
 	DependencyQueue = Store().MustInstall(NewAddOn("DEPENDENCY_QUEUE",
 		discovery.Configure().WithPrefix(core.GetServiceDependencyQueueRootKey("")).
-			WithInitSize(100).WithParser(proto.DependencyQueueParser)))
+			WithInitSize(100).WithPageSize(1500).WithParser(proto.DependencyQueueParser)))

Review comment:
       magic number，我觉得这个才是defaultxxxx

##########
File path: server/plugin/discovery/common.go
##########
@@ -23,4 +23,6 @@ import (
 const (
 	DefaultTimeout       = 30 * time.Second
 	DefaultCacheInitSize = 100
+	// grpc does not allow to transport a large body more then 4MB in a request
+	DefaultPageSize = 4096

Review comment:
       那这个是不是应该叫MaxPageSize或者DefaultMaxPageSize




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org