[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1346: DISPATCH-2235: Dump time delay before lock is acquired

[GitBox <gi...@apache.org>]

kgiusti commented on a change in pull request #1346:
URL: https://github.com/apache/qpid-dispatch/pull/1346#discussion_r694994166



##########
File path: src/router_core/forwarder.c
##########
@@ -154,7 +154,9 @@ qdr_delivery_t *qdr_forward_new_delivery_CT(qdr_core_t *core, qdr_delivery_t *in
     out_dlv->delivery_id = next_delivery_id();
     out_dlv->link_id     = out_link->identity;
     out_dlv->conn_id     = out_link->conn_id;
-    out_dlv->dispo_lock  = sys_mutex();
+    char name[64];
+    snprintf(name, sizeof(name), "delivery-%"PRIu32, out_dlv->delivery_id);

Review comment:
       It's probably overkill, especially for this lock which is hardly used.
   In fact we probably want to avoid storing the mutex name (strdup call) when we're not explicitly debugging the locks.
   Update coming soon...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org