You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by mike-tutkowski <gi...@git.apache.org> on 2016/05/21 03:08:15 UTC

[GitHub] cloudstack pull request: Hyper-V communication broken by change in...

GitHub user mike-tutkowski opened a pull request:

    https://github.com/apache/cloudstack/pull/1556

    Hyper-V communication broken by change in variable names

    Change variable names back to fix communication with Hyper-V Agent:
    
    https://issues.apache.org/jira/browse/CLOUDSTACK-9383

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-tutkowski/cloudstack change-var-names-back

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1556.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1556
    
----
commit a538e78bdb5af7dc2009dfc34f9c00d5f0d7ada7
Author: Mike Tutkowski <mi...@solidfire.com>
Date:   2016-05-21T02:56:57Z

    Removing \u201c_\u201d from the front of member variables in \u201cCommand\u201d classes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Hyper-V communication broken by change in...

Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1556#issuecomment-220811376
  
    
    
    ### CI RESULTS
    
    ```
    Tests Run: 85
      Skipped: 0
       Failed: 1
       Errors: 1
     Duration: 11h 00m 25s
    ```
    
    **Summary of the problem(s):**
    ```
    ERROR: Test to verify access to loadbalancer haproxy admin stats page
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 854, in tearDown
        raise Exception("Cleanup failed with %s" % e)
    Exception: Cleanup failed with Job failed: {jobprocstatus : 0, created : u'2016-05-21T11:09:36+0200', jobresult : {errorcode : 530, errortext : u'Failed to delete network'}, cmd : u'org.apache.cloudstack.api.command.user.network.DeleteNetworkCmd', userid : u'eabb1fa0-1f04-11e6-9252-5254001daa61', jobstatus : 2, jobid : u'3f774cb0-c0b7-433e-9442-e27c4134c1e7', jobresultcode : 530, jobresulttype : u'object', jobinstancetype : u'Network', accountid : u'eabb0890-1f04-11e6-9252-5254001daa61'}
    ----------------------------------------------------------------------
    Additional details in: /tmp/MarvinLogs/test_network_CCYW7Z/results.txt
    ```
    
    ```
    FAIL: Test destroy(expunge) Virtual Machine
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/data/git/cs1/cloudstack/test/integration/smoke/test_vm_life_cycle.py", line 646, in test_09_expunge_vm
        self.assertEqual(list_vm_response,None,"Check Expunged virtual machine is in listVirtualMachines response")
    AssertionError: Check Expunged virtual machine is in listVirtualMachines response
    ----------------------------------------------------------------------
    Additional details in: /tmp/MarvinLogs/test_vpc_routers_90CD36/results.txt
    ```
    
    
    
    **Associated Uploads**
    
    **`/tmp/MarvinLogs/DeployDataCenter__May_21_2016_05_37_14_WSLJYQ:`**
    * [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/DeployDataCenter__May_21_2016_05_37_14_WSLJYQ/dc_entries.obj)
    * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/DeployDataCenter__May_21_2016_05_37_14_WSLJYQ/failed_plus_exceptions.txt)
    * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/DeployDataCenter__May_21_2016_05_37_14_WSLJYQ/runinfo.txt)
    
    **`/tmp/MarvinLogs/test_network_CCYW7Z:`**
    * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/test_network_CCYW7Z/failed_plus_exceptions.txt)
    * [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/test_network_CCYW7Z/results.txt)
    * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/test_network_CCYW7Z/runinfo.txt)
    
    **`/tmp/MarvinLogs/test_vpc_routers_90CD36:`**
    * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/test_vpc_routers_90CD36/failed_plus_exceptions.txt)
    * [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/test_vpc_routers_90CD36/results.txt)
    * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/test_vpc_routers_90CD36/runinfo.txt)
    
    
    Uploads will be available until `2016-07-22 02:00:00 +0200 CEST`
    
    *Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Hyper-V communication broken by change in...

Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1556#issuecomment-221277292
  
    This is a clean run.  The errors here are not related to this PR.  I will merge this.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Hyper-V communication broken by change in...

Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1556#issuecomment-221159616
  
    
    
    ### CI RESULTS
    
    ```
    Tests Run: 85
      Skipped: 0
       Failed: 1
       Errors: 1
     Duration: 10h 51m 43s
    ```
    
    **Summary of the problem(s):**
    ```
    FAIL: Test destroy(expunge) Virtual Machine
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/data/git/cs1/cloudstack/test/integration/smoke/test_vm_life_cycle.py", line 646, in test_09_expunge_vm
        self.assertEqual(list_vm_response,None,"Check Expunged virtual machine is in listVirtualMachines response")
    AssertionError: Check Expunged virtual machine is in listVirtualMachines response
    ----------------------------------------------------------------------
    Additional details in: /tmp/MarvinLogs/test_vpc_routers_FSAZNE/results.txt
    ```
    
    ```
    ERROR: Test to verify access to loadbalancer haproxy admin stats page
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 854, in tearDown
        raise Exception("Cleanup failed with %s" % e)
    Exception: Cleanup failed with Job failed: {jobprocstatus : 0, created : u'2016-05-22T12:00:18+0200', jobresult : {errorcode : 530, errortext : u'Failed to delete network'}, cmd : u'org.apache.cloudstack.api.command.user.network.DeleteNetworkCmd', userid : u'2fac0d9d-1fd2-11e6-93b7-5254001daa61', jobstatus : 2, jobid : u'6cc5cc63-3184-4087-8888-4c51a659c9f1', jobresultcode : 530, jobresulttype : u'object', jobinstancetype : u'Network', accountid : u'2fabf773-1fd2-11e6-93b7-5254001daa61'}
    ----------------------------------------------------------------------
    Additional details in: /tmp/MarvinLogs/test_network_XMCT4W/results.txt
    ```
    
    
    
    **Associated Uploads**
    
    **`/tmp/MarvinLogs/DeployDataCenter__May_22_2016_06_06_04_MNRZVU:`**
    * [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/DeployDataCenter__May_22_2016_06_06_04_MNRZVU/dc_entries.obj)
    * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/DeployDataCenter__May_22_2016_06_06_04_MNRZVU/failed_plus_exceptions.txt)
    * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/DeployDataCenter__May_22_2016_06_06_04_MNRZVU/runinfo.txt)
    
    **`/tmp/MarvinLogs/test_network_XMCT4W:`**
    * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/test_network_XMCT4W/failed_plus_exceptions.txt)
    * [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/test_network_XMCT4W/results.txt)
    * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/test_network_XMCT4W/runinfo.txt)
    
    **`/tmp/MarvinLogs/test_vpc_routers_FSAZNE:`**
    * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/test_vpc_routers_FSAZNE/failed_plus_exceptions.txt)
    * [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/test_vpc_routers_FSAZNE/results.txt)
    * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/test_vpc_routers_FSAZNE/runinfo.txt)
    
    
    Uploads will be available until `2016-07-24 02:00:00 +0200 CEST`
    
    *Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Hyper-V communication broken by change in...

Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1556#issuecomment-221277026
  
    
    
    ### CI RESULTS
    
    ```
    Tests Run: 82
      Skipped: 0
       Failed: 0
       Errors: 3
     Duration: 8h 11m 34s
    ```
    
    **Summary of the problem(s):**
    ```
    ERROR: test suite for <class 'integration.smoke.test_vpc_vpn.TestRVPCSite2SiteVpn'>
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
        self.setUp()
      File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
        self.setupContext(ancestor)
      File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
        try_run(context, names)
      File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
        return func()
      File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 835, in setUpClass
        cls.template.download(cls.apiclient)
      File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in download
        elif 'Downloaded' in template.status:
    TypeError: argument of type 'NoneType' is not iterable
    ----------------------------------------------------------------------
    Additional details in: /tmp/MarvinLogs/test_network_71Q19A/results.txt
    ```
    
    ```
    ERROR: test suite for <class 'integration.smoke.test_vpc_vpn.TestVpcRemoteAccessVpn'>
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
        self.setUp()
      File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
        self.setupContext(ancestor)
      File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
        try_run(context, names)
      File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
        return func()
      File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 293, in setUpClass
        cls.template.download(cls.apiclient)
      File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in download
        elif 'Downloaded' in template.status:
    TypeError: argument of type 'NoneType' is not iterable
    ----------------------------------------------------------------------
    Additional details in: /tmp/MarvinLogs/test_network_71Q19A/results.txt
    ```
    
    ```
    ERROR: test suite for <class 'integration.smoke.test_vpc_vpn.TestVpcSite2SiteVpn'>
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
        self.setUp()
      File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
        self.setupContext(ancestor)
      File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
        try_run(context, names)
      File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
        return func()
      File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 472, in setUpClass
        cls.template.download(cls.apiclient)
      File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in download
        elif 'Downloaded' in template.status:
    TypeError: argument of type 'NoneType' is not iterable
    ----------------------------------------------------------------------
    Additional details in: /tmp/MarvinLogs/test_network_71Q19A/results.txt
    ```
    
    
    
    **Associated Uploads**
    
    **`/tmp/MarvinLogs/DeployDataCenter__May_24_2016_06_32_26_Y962ID:`**
    * [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/DeployDataCenter__May_24_2016_06_32_26_Y962ID/dc_entries.obj)
    * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/DeployDataCenter__May_24_2016_06_32_26_Y962ID/failed_plus_exceptions.txt)
    * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/DeployDataCenter__May_24_2016_06_32_26_Y962ID/runinfo.txt)
    
    **`/tmp/MarvinLogs/test_network_71Q19A:`**
    * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/test_network_71Q19A/failed_plus_exceptions.txt)
    * [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/test_network_71Q19A/results.txt)
    * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/test_network_71Q19A/runinfo.txt)
    
    **`/tmp/MarvinLogs/test_vpc_routers_X3MOBD:`**
    * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/test_vpc_routers_X3MOBD/failed_plus_exceptions.txt)
    * [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/test_vpc_routers_X3MOBD/results.txt)
    * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1556/tmp/MarvinLogs/test_vpc_routers_X3MOBD/runinfo.txt)
    
    
    Uploads will be available until `2016-07-24 02:00:00 +0200 CEST`
    
    *Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Hyper-V communication broken by change in...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/1556


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Hyper-V communication broken by change in...

Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1556#issuecomment-221159792
  
    I ran CI again hoping to clear up those errors and I got the same ones again.  I don't think they are related to this PR, but twice in a row concerns me a bit.  I will run another set...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Hyper-V communication broken by change in...

Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:

    https://github.com/apache/cloudstack/pull/1556#issuecomment-221202485
  
    Simple changes. LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Hyper-V communication broken by change in...

Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1556#issuecomment-220785566
  
    Given our discussion on mailing list and code review, LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---