You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/05 20:04:08 UTC

[GitHub] [arrow] AlenkaF opened a new pull request, #14294: ARROW-14280: [Doc] R package Architectural Overview

AlenkaF opened a new pull request, #14294:
URL: https://github.com/apache/arrow/pull/14294

   This PR adds an architectural overview of the R package to the New Contributor's Guide.
   
   ![Screenshot 2022-10-03 at 15 09 23](https://user-images.githubusercontent.com/16418547/193584498-90fc9605-c082-4f28-9556-a862676e5e97.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jonkeane commented on a diff in pull request #14294: ARROW-14280: [Doc] R package Architectural Overview

Posted by GitBox <gi...@apache.org>.
jonkeane commented on code in PR #14294:
URL: https://github.com/apache/arrow/pull/14294#discussion_r992297781


##########
docs/source/developers/guide/architectural_overview.rst:
##########
@@ -39,5 +39,31 @@ For an Architectural Overview of Arrow's libraries please
 refer to:
 
 - :ref:`py_arch_overview`
-- R package Architectural Overview (in progress, see
-  `issue ARROW-14280 <https://issues.apache.org/jira/browse/ARROW-14280>`_)
+- R package Architecture can be found on this page.
+
+
+R package Architectural Overview
+--------------------------------
+
+.. figure:: /developers/images/R_architectural_overview.png
+   :alt: Main parts of R package architecture: dplyr-*,
+         dplyr-funcs*, tools, tests and src/.
+
+* The ``r/R/dplyr-*`` files define the verbs used in a regular
+  dplyr syntax on Arrow objects.
+* The ``r/R/dplyr-funcs*`` files define bindings to Arrow C++
+  functions that can be used with already defined dplyr verbs.
+* All the C++ code connected to the R package lives in ``arrow/r/src``.
+  It also includes C++ code which connects libarrow (the Arrow C++
+  library) and the R code in package.
+* If libarrow source package is bundled with R package using

Review Comment:
   ```suggestion
   * If the libarrow source package is bundled with R package using
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] AlenkaF commented on pull request #14294: ARROW-14280: [Doc] R package Architectural Overview

Posted by GitBox <gi...@apache.org>.
AlenkaF commented on PR #14294:
URL: https://github.com/apache/arrow/pull/14294#issuecomment-1274830369

   @thisisnic would be great to have your final review also 🙏 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] AlenkaF merged pull request #14294: ARROW-14280: [Doc] R package Architectural Overview

Posted by GitBox <gi...@apache.org>.
AlenkaF merged PR #14294:
URL: https://github.com/apache/arrow/pull/14294


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #14294: ARROW-14280: [Doc] R package Architectural Overview

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14294:
URL: https://github.com/apache/arrow/pull/14294#issuecomment-1265416776

   :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #14294: ARROW-14280: [Doc] R package Architectural Overview

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14294:
URL: https://github.com/apache/arrow/pull/14294#issuecomment-1278415547

   Benchmark runs are scheduled for baseline = 02c671a3791d5f92d3ad0260396e2ee9c286670f and contender = 6d815a4d96aa63a732aa50e50242a99bea22c9c3. 6d815a4d96aa63a732aa50e50242a99bea22c9c3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2d835d77b6ec4da3a5a0778e9ff9e154...9470f9ec36074d0eabd104338b0083d5/)
   [Failed :arrow_down:0.0% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ee061ab59f0c4b769ae554ddb9665117...347b85c61ca74d2d81b32ca09cdefe2d/)
   [Failed :arrow_down:0.27% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/ec3f2a9b2f3949cd88189c4ba6be8bdd...9f75aad5bb19455c88a8d3e2f1da75f7/)
   [Finished :arrow_down:0.14% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1c38b8a14d674ffbbdf2fac096978927...c290bba6f2974a0a8c4f2907860037c9/)
   Buildkite builds:
   [Finished] [`6d815a4d` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1683)
   [Failed] [`6d815a4d` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1702)
   [Failed] [`6d815a4d` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1685)
   [Finished] [`6d815a4d` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1696)
   [Finished] [`02c671a3` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1682)
   [Failed] [`02c671a3` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1701)
   [Failed] [`02c671a3` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1684)
   [Finished] [`02c671a3` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1695)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #14294: ARROW-14280: [Doc] R package Architectural Overview

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14294:
URL: https://github.com/apache/arrow/pull/14294#issuecomment-1265416728

   https://issues.apache.org/jira/browse/ARROW-14280


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] AlenkaF commented on pull request #14294: ARROW-14280: [Doc] R package Architectural Overview

Posted by GitBox <gi...@apache.org>.
AlenkaF commented on PR #14294:
URL: https://github.com/apache/arrow/pull/14294#issuecomment-1274492120

   @jonkeane I think I have addressed all of you comments and the PR should be ready for another round of review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org