[GitHub] [iceberg] pvary commented on a change in pull request #1407: Hive: HiveIcebergOutputFormat first implementation - WIP

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #1407:
URL: https://github.com/apache/iceberg/pull/1407#discussion_r481327405



##########
File path: mr/src/main/java/org/apache/iceberg/mr/HiveSerDeConfig.java
##########
@@ -25,9 +25,9 @@
 import org.apache.iceberg.catalog.TableIdentifier;
 import org.apache.iceberg.expressions.Expression;
 
-public class InputFormatConfig {
+public final class HiveSerDeConfig {

Review comment:
       Added new constant to it:
   - _iceberg.mr.write.file.format_ - this is definitely not an InputFormatConfig :). Renaming at that time seemed like a good idea. Shall I create a new class instead? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org