You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "amogh-jahagirdar (via GitHub)" <gi...@apache.org> on 2023/02/13 00:40:29 UTC
[GitHub] [iceberg] amogh-jahagirdar opened a new pull request, #6815: API: Revert to using stephenc findbugs dependency for Nullable
amogh-jahagirdar opened a new pull request, #6815:
URL: https://github.com/apache/iceberg/pull/6815
Reverts to using stephenc findbugs dependency for Nullable based on @rdblue comment here: https://github.com/apache/iceberg/pull/6598/files#r1103888557
cc @danielcweeks since there is a differing view based off of https://github.com/apache/iceberg/pull/6598#discussion_r1096213570 . In the current PR, we're reverting back to using the stephenc dependency, because it appears the javax one from com.google.code.findbugs:jsr305 is banned. Let me know your thoughts on reverting this!
To add a third option: It seems like the stephenc findbugs dependency has Nullable marked as deprecated, and based off https://stackoverflow.com/questions/19030954/cant-find-nullable-inside-javax-annotation spotbugs is the newer reccomended library to get the javax.annotation but this still just has a dependency on com.google.code.findbugs:jsr305.
CC: @jackye1995 who is managing the release for 1.2.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] amogh-jahagirdar closed pull request #6815: API: Revert to using stephenc findbugs dependency for Nullable
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar closed pull request #6815: API: Revert to using stephenc findbugs dependency for Nullable
URL: https://github.com/apache/iceberg/pull/6815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 merged pull request #6815: API: Revert to using stephenc findbugs dependency for Nullable
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 merged PR #6815:
URL: https://github.com/apache/iceberg/pull/6815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #6815: API: Revert to using stephenc findbugs dependency for Nullable
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on PR #6815:
URL: https://github.com/apache/iceberg/pull/6815#issuecomment-1428484151
Thanks for the fix and the quick reviews!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6815: API: Revert to using stephenc findbugs dependency for Nullable
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on code in PR #6815:
URL: https://github.com/apache/iceberg/pull/6815#discussion_r1105298332
##########
api/src/main/java/org/apache/iceberg/view/SQLViewRepresentation.java:
##########
@@ -18,8 +18,8 @@
*/
package org.apache.iceberg.view;
+import edu.umd.cs.findbugs.annotations.Nullable;
import java.util.List;
-import javax.annotation.Nullable;
Review Comment:
It just defines the edu.umd one. https://github.com/stephenc/findbugs-annotations/blob/master/src/main/java/edu/umd/cs/findbugs/annotations/Nullable.java#L39 actually it seems like its deprecated and recommends using javax which as far as I can tell can only come from com.google.code.findbugs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on pull request #6815: API: Revert to using stephenc findbugs dependency for Nullable
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on PR #6815:
URL: https://github.com/apache/iceberg/pull/6815#issuecomment-1434587642
@amogh-jahagirdar, @rdblue:
we have the below compile warning because of the findbugs dependency removal.
<img width="554" alt="image" src="https://user-images.githubusercontent.com/5889404/219656305-a906b689-9db2-48c9-a588-76b61d19ccf3.png">
```
> Task :iceberg-api:compileJava
warning: unknown enum constant When.UNKNOWN
reason: class file for javax.annotation.meta.When not found
unknown enum constant When.UNKNOWN
warning: unknown enum constant When.UNKNOWN
reason: class file for javax.annotation.meta.When not found
warning: unknown enum constant When.UNKNOWN
reason: class file for javax.annotation.meta.When not found
warning: unknown enum constant When.UNKNOWN
reason: class file for javax.annotation.meta.When not found
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #6815: API: Revert to using stephenc findbugs dependency for Nullable
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on code in PR #6815:
URL: https://github.com/apache/iceberg/pull/6815#discussion_r1104897667
##########
api/src/main/java/org/apache/iceberg/view/SQLViewRepresentation.java:
##########
@@ -18,8 +18,8 @@
*/
package org.apache.iceberg.view;
+import edu.umd.cs.findbugs.annotations.Nullable;
import java.util.List;
-import javax.annotation.Nullable;
Review Comment:
Doesn't the stephenc library define this annotation? Or is it just the edu.umd one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org