You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Kaj Kandler (JIRA)" <ji...@apache.org> on 2006/06/26 00:13:29 UTC

[jira] Created: (COCOON-1869) MailMessageSender.java eats exception chain - which does not allow for proper dubuging and logging

MailMessageSender.java eats exception chain - which does not allow for proper dubuging and logging
--------------------------------------------------------------------------------------------------

         Key: COCOON-1869
         URL: http://issues.apache.org/jira/browse/COCOON-1869
     Project: Cocoon
        Type: Bug

  Components: Blocks: Mail  
    Versions: 2.1.9    
    Reporter: Kaj Kandler


line 448 eats the chain of exceptions, which is bad for finding bugs and misconfiguration. 

It should better read:

        } catch (MessagingException me) {
            throw me;

or 

        } catch (MessagingException me) {
            throw me; // new MessagingException(me.getMessage(),me);

or be eliminated all together, following the principle, if you can't do anything about an exception and don't need to aggregate it, because of API design, don't catch it in the first place!




-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (COCOON-1869) MailMessageSender.java eats exception chain

Posted by "Jörg Heinicke (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1869?page=all ]

Jörg Heinicke closed COCOON-1869.
---------------------------------

    Fix Version/s: 2.2-dev (Current SVN)
                   2.1.10-dev (current SVN)
       Resolution: Fixed

> MailMessageSender.java eats exception chain
> -------------------------------------------
>
>                 Key: COCOON-1869
>                 URL: http://issues.apache.org/jira/browse/COCOON-1869
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Mail
>    Affects Versions: 2.1.9
>            Reporter: Kaj Kandler
>         Assigned To: Jörg Heinicke
>             Fix For: 2.2-dev (Current SVN), 2.1.10-dev (current SVN)
>
>
> line 448 eats the chain of exceptions, which is bad for finding bugs and misconfiguration. 
> It should better read:
>         } catch (MessagingException me) {
>             throw me;
> or 
>         } catch (MessagingException me) {
>             throw me; // new MessagingException(me.getMessage(),me);
> or be eliminated all together, following the principle, if you can't do anything about an exception and don't need to aggregate it, because of API design, don't catch it in the first place!

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Updated: (COCOON-1869) MailMessageSender.java eats exception chain

Posted by "Jörg Heinicke (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1869?page=all ]

Jörg Heinicke updated COCOON-1869:
----------------------------------

     Summary: MailMessageSender.java eats exception chain  (was: MailMessageSender.java eats exception chain - which does not allow for proper dubuging and logging)
    Assignee: Jörg Heinicke

> MailMessageSender.java eats exception chain
> -------------------------------------------
>
>                 Key: COCOON-1869
>                 URL: http://issues.apache.org/jira/browse/COCOON-1869
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Mail
>    Affects Versions: 2.1.9
>            Reporter: Kaj Kandler
>         Assigned To: Jörg Heinicke
>             Fix For: 2.2-dev (Current SVN), 2.1.10-dev (current SVN)
>
>
> line 448 eats the chain of exceptions, which is bad for finding bugs and misconfiguration. 
> It should better read:
>         } catch (MessagingException me) {
>             throw me;
> or 
>         } catch (MessagingException me) {
>             throw me; // new MessagingException(me.getMessage(),me);
> or be eliminated all together, following the principle, if you can't do anything about an exception and don't need to aggregate it, because of API design, don't catch it in the first place!

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira