Re: [PR] refactor: Removes the deprecated DASHBOARD_NATIVE_FILTERS feature flag [superset]

["geido (via GitHub)" <gi...@apache.org>]

geido commented on code in PR #26329:
URL: https://github.com/apache/superset/pull/26329#discussion_r1443106598


##########
superset-frontend/src/dataMask/actions.ts:
##########
@@ -74,9 +74,9 @@ export function updateDataMask(
   dataMask: DataMask,
 ): UpdateDataMask {
   // Only apply data mask if one of the relevant features is enabled
-  const isFeatureFlagActive =
-    isFeatureEnabled(FeatureFlag.DASHBOARD_NATIVE_FILTERS) ||
-    isFeatureEnabled(FeatureFlag.DASHBOARD_CROSS_FILTERS);
+  const isFeatureFlagActive = isFeatureEnabled(

Review Comment:
   Same comment as above 



##########
superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/pagination.tsx:
##########
@@ -24,23 +24,23 @@ import {
 import { FeatureFlag, isFeatureEnabled, t } from '@superset-ui/core';
 import { PAGE_SIZE_OPTIONS } from '../../consts';
 
-export const serverPaginationControlSetRow: ControlSetRow =

Review Comment:
   @michael-s-molina I am not too sure about this change. It seems that server_pagination should be shown by default now as the  `DASHBOARD_NATIVE_FILTERS` is also by default



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org