[jira] Closed: (TAP5-1203) Use of @Contribute annotation does not work properly with marker annotations

["Howard M. Lewis Ship (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TAP5-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1203.
--------------------------------------

    Fix Version/s: 5.2.0
       Resolution: Fixed

> Use of @Contribute annotation does not work properly with marker annotations
> ----------------------------------------------------------------------------
>
>                 Key: TAP5-1203
>                 URL: https://issues.apache.org/jira/browse/TAP5-1203
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-ioc
>    Affects Versions: 5.2.0
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.2.0
>
>
> @Contribute is a great idea, but there are two problems (as discussed on the mailing list)
> 1) Marker annotations on the contribute method should be simple annotation, not wrapped inside @Marker, i.e.:
> @Contribute(NameListHolder.class)
> @BlueMarker
> public void contributeBlueNames(...)
> 2) The comparison of marker annotations on the contribution method to the marker annotations for the service is slightly off. It was done with equals(), but it should be that the service contains all maker annotations from the contribution method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.