[GitHub] [calcite] NobiGo commented on a diff in pull request #3295: [CALCITE-5701] Add NAMED_STRUCT function (enabled in Spark library)

["NobiGo (via GitHub)" <gi...@apache.org>]

NobiGo commented on code in PR #3295:
URL: https://github.com/apache/calcite/pull/3295#discussion_r1252564958


##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##########
@@ -656,6 +658,7 @@ Builder populate2() {
           new PeriodNameImplementor("monthName",
               BuiltInMethod.MONTHNAME_WITH_TIMESTAMP,
               BuiltInMethod.MONTHNAME_WITH_DATE));
+

Review Comment:
   Unrelated changes, Please remove them.



##########
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableInterpretable.java:
##########
@@ -126,7 +126,8 @@ public static Bindable toBindable(Map<String, Object> parameters,
       }
     } catch (Exception e) {
       throw Helper.INSTANCE.wrap("Error while compiling generated Java code:\n"
-          + s, e);

Review Comment:
   This is unrelated changes about this ISSUE, If you think this message needs to improve, Please log a new issue in Jira.



##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##########
@@ -3270,6 +3276,31 @@ private static class ValueConstructorImplementor
                       Expressions.box(value))));
         }
         return lyst;
+
+      case STRUCT_CONSTRUCTOR:
+

Review Comment:
   In order to keep the code style unified, Please remove empty lines.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org