You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by hl...@apache.org on 2009/04/03 18:33:50 UTC
svn commit: r761719 - in
/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal:
renderers/RequestRenderer.java test/TestableRequestImpl.java
Author: hlship
Date: Fri Apr 3 16:33:49 2009
New Revision: 761719
URL: http://svn.apache.org/viewvc?rev=761719&view=rev
Log:
TAP5-621: When using PageTester, an exception in the page is hidden by an exception rendering the exception report page
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/renderers/RequestRenderer.java
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/test/TestableRequestImpl.java
Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/renderers/RequestRenderer.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/renderers/RequestRenderer.java?rev=761719&r1=761718&r2=761719&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/renderers/RequestRenderer.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/renderers/RequestRenderer.java Fri Apr 3 16:33:49 2009
@@ -73,10 +73,10 @@
parameters(request, writer);
headers(request, writer);
- context(request, writer);
+ context(writer);
}
- private void context(Request request, MarkupWriter writer)
+ private void context(MarkupWriter writer)
{
List<String> attributeNames = context.getAttributeNames();
Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/test/TestableRequestImpl.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/test/TestableRequestImpl.java?rev=761719&r1=761718&r2=761719&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/test/TestableRequestImpl.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/test/TestableRequestImpl.java Fri Apr 3 16:33:49 2009
@@ -14,15 +14,15 @@
package org.apache.tapestry5.internal.test;
+import org.apache.tapestry5.ioc.annotations.Inject;
import org.apache.tapestry5.ioc.internal.util.CollectionFactory;
import org.apache.tapestry5.ioc.internal.util.InternalUtils;
-import org.apache.tapestry5.ioc.annotations.Inject;
import org.apache.tapestry5.services.Session;
+import java.util.ArrayList;
import java.util.List;
import java.util.Locale;
import java.util.Map;
-import java.util.ArrayList;
public class TestableRequestImpl implements TestableRequest
{
@@ -216,9 +216,12 @@
attributes.put(name, value);
}
+ /**
+ * Returns "localhost" which is sufficient for testing purposes.
+ */
public String getServerName()
{
- return nyi("getServerName");
+ return "localhost";
}
/**