You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/09/27 03:01:54 UTC

Review Request 14358: Build against different SASL versions.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14358/
-----------------------------------------------------------

Review request for mesos, Ben Mahler, Vinod Kone, and Vinson Lee.


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  src/sasl/auxprop.hpp 44e773ca7e10b3134a5eb3111f9d72728187f915 
  src/sasl/auxprop.cpp 9547cc880938161af79fcfa736b079503064af2f 

Diff: https://reviews.apache.org/r/14358/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman


Re: Review Request 14358: Build against different SASL versions.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14358/#review26428
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Sept. 27, 2013, 1:01 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14358/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2013, 1:01 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Vinod Kone, and Vinson Lee.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/sasl/auxprop.hpp 44e773ca7e10b3134a5eb3111f9d72728187f915 
>   src/sasl/auxprop.cpp 9547cc880938161af79fcfa736b079503064af2f 
> 
> Diff: https://reviews.apache.org/r/14358/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request 14358: Build against different SASL versions.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14358/#review26427
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Sept. 27, 2013, 1:01 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14358/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2013, 1:01 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Vinod Kone, and Vinson Lee.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/sasl/auxprop.hpp 44e773ca7e10b3134a5eb3111f9d72728187f915 
>   src/sasl/auxprop.cpp 9547cc880938161af79fcfa736b079503064af2f 
> 
> Diff: https://reviews.apache.org/r/14358/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request 14358: Build against different SASL versions.

Posted by Vinson Lee <vl...@freedesktop.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14358/#review26426
-----------------------------------------------------------

Ship it!


Reviewed-by: Vinson Lee <vl...@twitter.com>

- Vinson Lee


On Sept. 27, 2013, 1:01 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14358/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2013, 1:01 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Vinod Kone, and Vinson Lee.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/sasl/auxprop.hpp 44e773ca7e10b3134a5eb3111f9d72728187f915 
>   src/sasl/auxprop.cpp 9547cc880938161af79fcfa736b079503064af2f 
> 
> Diff: https://reviews.apache.org/r/14358/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>