[GitHub] MaxGekk commented on a change in pull request #23936: [SPARK-27031][SQL] Avoid double formatting in timestampToString

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #23936: [SPARK-27031][SQL] Avoid double formatting in timestampToString
URL: https://github.com/apache/spark/pull/23936#discussion_r261838368
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TimestampFormatter.scala
 ##########
 @@ -81,4 +81,9 @@ object TimestampFormatter {
   def apply(timeZone: TimeZone): TimestampFormatter = {
     apply(defaultPattern, timeZone, defaultLocale)
   }
+
+  val fractionPattern = "fraction-pattern"
 
 Review comment:
   I think it is better to move it to the private object `DateTimeFormatterHelper`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org