You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/30 00:43:51 UTC
[GitHub] [airflow] potiuk opened a new pull request #15081: Finish quarantine for test_should_force_kill_process
potiuk opened a new pull request #15081:
URL: https://github.com/apache/airflow/pull/15081
Changing the test to check actual PID of the process to kill
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #15081: Finish quarantine for test_should_force_kill_process
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #15081:
URL: https://github.com/apache/airflow/pull/15081#discussion_r603936974
##########
File path: tests/utils/test_process_utils.py
##########
@@ -136,23 +136,21 @@ def test_should_kill_process(self):
num_process = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().count("\n")
assert before_num_process == num_process
- @pytest.mark.quarantined
def test_should_force_kill_process(self):
- before_num_process = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().count("\n")
process = multiprocessing.Process(target=my_sleep_subprocess_with_signals, args=())
process.start()
sleep(0)
- num_process = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().count("\n")
- assert before_num_process + 1 == num_process
+ all_processes = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().splitlines()
+ assert str(process.pid) in map(lambda x: x.strip(), all_processes)
Review comment:
Crap. Thanks for the explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15081: Finish quarantine for test_should_force_kill_process
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15081:
URL: https://github.com/apache/airflow/pull/15081#issuecomment-810648867
very small - removes a test from quarantine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #15081: Finish quarantine for test_should_force_kill_process
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #15081:
URL: https://github.com/apache/airflow/pull/15081#discussion_r603907146
##########
File path: tests/utils/test_process_utils.py
##########
@@ -136,23 +136,21 @@ def test_should_kill_process(self):
num_process = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().count("\n")
assert before_num_process == num_process
- @pytest.mark.quarantined
def test_should_force_kill_process(self):
- before_num_process = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().count("\n")
process = multiprocessing.Process(target=my_sleep_subprocess_with_signals, args=())
process.start()
sleep(0)
- num_process = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().count("\n")
- assert before_num_process + 1 == num_process
+ all_processes = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().splitlines()
+ assert str(process.pid) in map(lambda x: x.strip(), all_processes)
Review comment:
That would not work. The returned values do not have EOL. They are prefixed with spaces:
```
1
2
234333
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #15081: Finish quarantine for test_should_force_kill_process
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #15081:
URL: https://github.com/apache/airflow/pull/15081#discussion_r603936974
##########
File path: tests/utils/test_process_utils.py
##########
@@ -136,23 +136,21 @@ def test_should_kill_process(self):
num_process = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().count("\n")
assert before_num_process == num_process
- @pytest.mark.quarantined
def test_should_force_kill_process(self):
- before_num_process = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().count("\n")
process = multiprocessing.Process(target=my_sleep_subprocess_with_signals, args=())
process.start()
sleep(0)
- num_process = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().count("\n")
- assert before_num_process + 1 == num_process
+ all_processes = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().splitlines()
+ assert str(process.pid) in map(lambda x: x.strip(), all_processes)
Review comment:
Ouch. Thanks for the explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15081: Finish quarantine for test_should_force_kill_process
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15081:
URL: https://github.com/apache/airflow/pull/15081#issuecomment-812328110
Anyone :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #15081: Finish quarantine for test_should_force_kill_process
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #15081:
URL: https://github.com/apache/airflow/pull/15081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #15081: Finish quarantine for test_should_force_kill_process
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #15081:
URL: https://github.com/apache/airflow/pull/15081#discussion_r603795541
##########
File path: tests/utils/test_process_utils.py
##########
@@ -136,23 +136,21 @@ def test_should_kill_process(self):
num_process = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().count("\n")
assert before_num_process == num_process
- @pytest.mark.quarantined
def test_should_force_kill_process(self):
- before_num_process = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().count("\n")
process = multiprocessing.Process(target=my_sleep_subprocess_with_signals, args=())
process.start()
sleep(0)
- num_process = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().count("\n")
- assert before_num_process + 1 == num_process
+ all_processes = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().splitlines()
+ assert str(process.pid) in map(lambda x: x.strip(), all_processes)
Review comment:
Would this work?
```suggestion
all_processes = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().splitlines(keepends=False)
assert str(process.pid) in all_processes
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15081: Finish quarantine for test_should_force_kill_process
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15081:
URL: https://github.com/apache/airflow/pull/15081#issuecomment-812834545
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #15081: Finish quarantine for test_should_force_kill_process
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #15081:
URL: https://github.com/apache/airflow/pull/15081#discussion_r603907146
##########
File path: tests/utils/test_process_utils.py
##########
@@ -136,23 +136,21 @@ def test_should_kill_process(self):
num_process = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().count("\n")
assert before_num_process == num_process
- @pytest.mark.quarantined
def test_should_force_kill_process(self):
- before_num_process = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().count("\n")
process = multiprocessing.Process(target=my_sleep_subprocess_with_signals, args=())
process.start()
sleep(0)
- num_process = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().count("\n")
- assert before_num_process + 1 == num_process
+ all_processes = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().splitlines()
+ assert str(process.pid) in map(lambda x: x.strip(), all_processes)
Review comment:
That would not work. The returned values do not have EOL. They are prefixed with spaces: " 1" for example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #15081: Finish quarantine for test_should_force_kill_process
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #15081:
URL: https://github.com/apache/airflow/pull/15081#discussion_r603907146
##########
File path: tests/utils/test_process_utils.py
##########
@@ -136,23 +136,21 @@ def test_should_kill_process(self):
num_process = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().count("\n")
assert before_num_process == num_process
- @pytest.mark.quarantined
def test_should_force_kill_process(self):
- before_num_process = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().count("\n")
process = multiprocessing.Process(target=my_sleep_subprocess_with_signals, args=())
process.start()
sleep(0)
- num_process = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().count("\n")
- assert before_num_process + 1 == num_process
+ all_processes = subprocess.check_output(["ps", "-ax", "-o", "pid="]).decode().splitlines()
+ assert str(process.pid) in map(lambda x: x.strip(), all_processes)
Review comment:
That would not work. The returned values do not have EOL. They are prefixed with spaces: ` 1` for example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org