You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Dandandan (via GitHub)" <gi...@apache.org> on 2026/08/15 20:49:14 UTC
[PR] fix(scheduler): drop an executor's cached gRPC client when it is removed [datafusion-ballista]
Dandandan opened a new pull request, #2310:
URL: https://github.com/apache/datafusion-ballista/pull/2310
`ExecutorManager` caches an `ExecutorGrpcClient` per executor in `self.clients`, but nothing ever removes an entry: the map is only inserted into by `get_client` and read back. `remove_executor` drops the executor from the cluster state and leaves the client behind.
Because an executor id is a fresh uuid per executor process, a client left in the map is never looked up again. It is not dropped either, so the scheduler retains the client and its `Channel` for as long as it runs. A cluster with executor churn (autoscaling, preemption, restarts) therefore accumulates one dead client per executor that has ever registered.
Remove the cached client in `remove_executor`, before delegating to the cluster state so that it goes even if that call fails. Every removal path already funnels through here, as `SchedulerState::remove_executor` documents.
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix(scheduler): drop an executor's cached gRPC client when it is removed [datafusion-ballista]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan merged PR #2310:
URL: https://github.com/apache/datafusion-ballista/pull/2310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org