You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Matt Benson <gu...@yahoo.com> on 2009/03/15 19:40:41 UTC
Re: svn commit: r754584 - in /commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder: ToStringBuilder.java ToStringStyle.java
I suppose it depends whether we want the reflect stuff ported from [beanutils]. Personally I'd say yes, but since the same code exists, more-or-less, in another component it's not _critical_.
-Matt
--- On Sun, 3/15/09, Henri Yandell <fl...@gmail.com> wrote:
> From: Henri Yandell <fl...@gmail.com>
> Subject: Re: svn commit: r754584 - in /commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder: ToStringBuilder.java ToStringStyle.java
> To: "Commons Developers List" <de...@commons.apache.org>
> Date: Sunday, March 15, 2009, 1:29 PM
> Matt - if we did keep a 2.x branch,
> would the POST-2.4 branch be of
> value, or should we be branching from the 2.4 tag?
>
> Hen
>
> On Sun, Mar 15, 2009 at 11:20 AM, Henri Yandell <fl...@gmail.com>
> wrote:
> > We can branch 2.4 if needed.
> >
> > The biggest choice is whether we attempt to fix bugs
> in both, while
> > reserving changes and new features for the 3.0
> branch.
> >
> > Ideally wed have the 2.4 one going, but that would be
> quite a cultural
> > development change from the usual 1 trunk way we do
> things. I'm
> > expecting us not to do anything unless we have a
> serious enough bug
> > that requires change.
> >
> > For example LANG-331... no real solution and I'm
> expecting that this
> > needs to be resolved as a known-issue.
> >
> > Hen
> >
> > On Sun, Mar 15, 2009 at 4:52 AM, sebb <se...@gmail.com>
> wrote:
> >> I assumed it was where the next 2.x release would
> come from.
> >>
> >> Or will there be no further releases supporting
> versions of Java prior to 1.5?
> >>
> >> On 15/03/2009, Matt Benson <gu...@yahoo.com>
> wrote:
> >>>
> >>> Are we still using this branch? I created
> it for work on the reflect subpackage but later merged back
> to trunk... :|
> >>>
> >>> -Matt
> >>>
> >>> --- On Sat, 3/14/09, sebb@apache.org
> <se...@apache.org>
> wrote:
> >>>
> >>> > From: sebb@apache.org
> <se...@apache.org>
> >>> > Subject: svn commit: r754584 - in
> /commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder:
> ToStringBuilder.java ToStringStyle.java
> >>> > To: commits@commons.apache.org
> >>> > Date: Saturday, March 14, 2009, 8:43
> PM
> >>> > Author: sebb
> >>> > Date: Sun Mar 15 01:43:20 2009
> >>> > New Revision: 754584
> >>> >
> >>> > URL: http://svn.apache.org/viewvc?rev=754584&view=rev
> >>> > Log:
> >>> > Replace deprecated method calls to
> appendIdentityToString
> >>> > with identityToString
> >>> >
> >>> > Modified:
> >>> >
> >>> >
> commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
> >>> >
> >>> >
> commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
> >>> >
> >>> > Modified:
> >>> >
> commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
> >>> > URL: http://svn.apache.org/viewvc/commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java?rev=754584&r1=754583&r2=754584&view=diff
> >>> >
> ==============================================================================
> >>> > ---
> >>> >
> commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
> >>> > (original)
> >>> > +++
> >>> >
> commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
> >>> > Sun Mar 15 01:43:20 2009
> >>> > @@ -945,7 +945,7 @@
> >>> > * @since 2.0
> >>> > */
> >>> > public ToStringBuilder
> >>> > appendAsObjectToString(Object object)
> {
> >>> > -
> >>> >
> ObjectUtils.appendIdentityToString(this.getStringBuffer(),
> >>> > object);
> >>> > +
> >>> >
> ObjectUtils.identityToString(this.getStringBuffer(),
> >>> > object);
> >>> > return this;
> >>> > }
> >>> >
> >>> >
> >>> > Modified:
> >>> >
> commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
> >>> > URL: http://svn.apache.org/viewvc/commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java?rev=754584&r1=754583&r2=754584&view=diff
> >>> >
> ==============================================================================
> >>> > ---
> >>> >
> commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
> >>> > (original)
> >>> > +++
> >>> >
> commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
> >>> > Sun Mar 15 01:43:20 2009
> >>> > @@ -562,7 +562,7 @@
> >>> > * @since 2.2
> >>> > */
> >>> > protected void
> >>> > appendCyclicObject(StringBuffer buffer,
> String fieldName,
> >>> > Object value) {
> >>> > -
> >>> >
> ObjectUtils.appendIdentityToString(buffer,
> >>> > value);
> >>> > +
> >>> >
> ObjectUtils.identityToString(buffer,
> >>> > value);
> >>> > }
> >>> >
> >>> > /**
> >>> >
> >>> >
> >>> >
> >>>
> >>>
> >>>
> >>>
> >>>
> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >>> For additional commands, e-mail: dev-help@commons.apache.org
> >>>
> >>>
> >>
> >>
> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r754584 - in /commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder:
ToStringBuilder.java ToStringStyle.java
Posted by Henri Yandell <fl...@gmail.com>.
I'm thinking no then. Personally I wouldn't want to be developing a
parallel 2.x with new features, just putting in major bugfixes on a
2.x if we feel the need.
On Sun, Mar 15, 2009 at 11:40 AM, Matt Benson <gu...@yahoo.com> wrote:
>
> I suppose it depends whether we want the reflect stuff ported from [beanutils]. Personally I'd say yes, but since the same code exists, more-or-less, in another component it's not _critical_.
>
> -Matt
>
> --- On Sun, 3/15/09, Henri Yandell <fl...@gmail.com> wrote:
>
>> From: Henri Yandell <fl...@gmail.com>
>> Subject: Re: svn commit: r754584 - in /commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder: ToStringBuilder.java ToStringStyle.java
>> To: "Commons Developers List" <de...@commons.apache.org>
>> Date: Sunday, March 15, 2009, 1:29 PM
>> Matt - if we did keep a 2.x branch,
>> would the POST-2.4 branch be of
>> value, or should we be branching from the 2.4 tag?
>>
>> Hen
>>
>> On Sun, Mar 15, 2009 at 11:20 AM, Henri Yandell <fl...@gmail.com>
>> wrote:
>> > We can branch 2.4 if needed.
>> >
>> > The biggest choice is whether we attempt to fix bugs
>> in both, while
>> > reserving changes and new features for the 3.0
>> branch.
>> >
>> > Ideally wed have the 2.4 one going, but that would be
>> quite a cultural
>> > development change from the usual 1 trunk way we do
>> things. I'm
>> > expecting us not to do anything unless we have a
>> serious enough bug
>> > that requires change.
>> >
>> > For example LANG-331... no real solution and I'm
>> expecting that this
>> > needs to be resolved as a known-issue.
>> >
>> > Hen
>> >
>> > On Sun, Mar 15, 2009 at 4:52 AM, sebb <se...@gmail.com>
>> wrote:
>> >> I assumed it was where the next 2.x release would
>> come from.
>> >>
>> >> Or will there be no further releases supporting
>> versions of Java prior to 1.5?
>> >>
>> >> On 15/03/2009, Matt Benson <gu...@yahoo.com>
>> wrote:
>> >>>
>> >>> Are we still using this branch? I created
>> it for work on the reflect subpackage but later merged back
>> to trunk... :|
>> >>>
>> >>> -Matt
>> >>>
>> >>> --- On Sat, 3/14/09, sebb@apache.org
>> <se...@apache.org>
>> wrote:
>> >>>
>> >>> > From: sebb@apache.org
>> <se...@apache.org>
>> >>> > Subject: svn commit: r754584 - in
>> /commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder:
>> ToStringBuilder.java ToStringStyle.java
>> >>> > To: commits@commons.apache.org
>> >>> > Date: Saturday, March 14, 2009, 8:43
>> PM
>> >>> > Author: sebb
>> >>> > Date: Sun Mar 15 01:43:20 2009
>> >>> > New Revision: 754584
>> >>> >
>> >>> > URL: http://svn.apache.org/viewvc?rev=754584&view=rev
>> >>> > Log:
>> >>> > Replace deprecated method calls to
>> appendIdentityToString
>> >>> > with identityToString
>> >>> >
>> >>> > Modified:
>> >>> >
>> >>> >
>> commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
>> >>> >
>> >>> >
>> commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
>> >>> >
>> >>> > Modified:
>> >>> >
>> commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
>> >>> > URL: http://svn.apache.org/viewvc/commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java?rev=754584&r1=754583&r2=754584&view=diff
>> >>> >
>> ==============================================================================
>> >>> > ---
>> >>> >
>> commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
>> >>> > (original)
>> >>> > +++
>> >>> >
>> commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
>> >>> > Sun Mar 15 01:43:20 2009
>> >>> > @@ -945,7 +945,7 @@
>> >>> > * @since 2.0
>> >>> > */
>> >>> > public ToStringBuilder
>> >>> > appendAsObjectToString(Object object)
>> {
>> >>> > -
>> >>> >
>> ObjectUtils.appendIdentityToString(this.getStringBuffer(),
>> >>> > object);
>> >>> > +
>> >>> >
>> ObjectUtils.identityToString(this.getStringBuffer(),
>> >>> > object);
>> >>> > return this;
>> >>> > }
>> >>> >
>> >>> >
>> >>> > Modified:
>> >>> >
>> commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
>> >>> > URL: http://svn.apache.org/viewvc/commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java?rev=754584&r1=754583&r2=754584&view=diff
>> >>> >
>> ==============================================================================
>> >>> > ---
>> >>> >
>> commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
>> >>> > (original)
>> >>> > +++
>> >>> >
>> commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
>> >>> > Sun Mar 15 01:43:20 2009
>> >>> > @@ -562,7 +562,7 @@
>> >>> > * @since 2.2
>> >>> > */
>> >>> > protected void
>> >>> > appendCyclicObject(StringBuffer buffer,
>> String fieldName,
>> >>> > Object value) {
>> >>> > -
>> >>> >
>> ObjectUtils.appendIdentityToString(buffer,
>> >>> > value);
>> >>> > +
>> >>> >
>> ObjectUtils.identityToString(buffer,
>> >>> > value);
>> >>> > }
>> >>> >
>> >>> > /**
>> >>> >
>> >>> >
>> >>> >
>> >>>
>> >>>
>> >>>
>> >>>
>> >>>
>> ---------------------------------------------------------------------
>> >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> >>> For additional commands, e-mail: dev-help@commons.apache.org
>> >>>
>> >>>
>> >>
>> >>
>> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> >> For additional commands, e-mail: dev-help@commons.apache.org
>> >>
>> >>
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org