You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "the8thC (via GitHub)" <gi...@apache.org> on 2023/03/01 18:40:58 UTC
[GitHub] [spark] the8thC opened a new pull request, #40236: [SPARK-38735][SQL][Tests] Add tests for the error class: INTERNAL_ERROR
the8thC opened a new pull request, #40236:
URL: https://github.com/apache/spark/pull/40236
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR aims to add tests for the error class INTERNAL_ERROR to QueryExecutionErrorsSuite
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
The changes improve test coverage, and document expected error messages in tests
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
By running the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] the8thC commented on pull request #40236: [SPARK-38735][SQL][TESTS] Add tests for the error class: INTERNAL_ERROR
Posted by "the8thC (via GitHub)" <gi...@apache.org>.
the8thC commented on PR #40236:
URL: https://github.com/apache/spark/pull/40236#issuecomment-1462470101
@MaxGekk No, I don't, but I've just requested one using "selfserve". Is that the right way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #40236: [SPARK-38735][SQL][TESTS] Add tests for the error class: INTERNAL_ERROR
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #40236:
URL: https://github.com/apache/spark/pull/40236#issuecomment-1462661054
> @MaxGekk No, I don't, but I've just requested one using "selfserve". Is that the right way?
Yep, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #40236: [SPARK-38735][SQL][Tests] Add tests for the error class: INTERNAL_ERROR
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #40236:
URL: https://github.com/apache/spark/pull/40236#issuecomment-1454045008
Just FYI and really not a big deal, we typically use upper-cased "TESTS" or "TEST" for PR title when the change only includes the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] the8thC commented on a diff in pull request #40236: [SPARK-38735][SQL][TESTS] Add tests for the error class: INTERNAL_ERROR
Posted by "the8thC (via GitHub)" <gi...@apache.org>.
the8thC commented on code in PR #40236:
URL: https://github.com/apache/spark/pull/40236#discussion_r1125670340
##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala:
##########
@@ -765,6 +770,58 @@ class QueryExecutionErrorsSuite
)
}
}
+
+ test("INTERNAL_ERROR: Calling eval on Unevaluable expression") {
+ val e = intercept[SparkException] {
+ Parameter("foo").eval()
+ }
+ checkError(
+ exception = e,
+ errorClass = "INTERNAL_ERROR",
+ parameters = Map("message" -> "Cannot evaluate expression: parameter(foo)"),
+ sqlState = "XX000")
+ }
+
+ test("INTERNAL_ERROR: Calling doGenCode on unresolved") {
+ val e = intercept[SparkException] {
+ val ctx = new CodegenContext
+ Grouping(Parameter("foo")).genCode(ctx)
+ }
+ checkError(
+ exception = e,
+ errorClass = "INTERNAL_ERROR",
+ parameters = Map(
+ "message" -> ("Cannot generate code for expression: " +
+ "grouping(parameter(foo))")),
+ sqlState = "XX000")
+ }
+
+ test("INTERNAL_ERROR: Calling terminate on UnresolvedGenerator") {
+ val e = intercept[SparkException] {
+ UnresolvedGenerator(FunctionIdentifier("foo"), Seq.empty).terminate()
+ }
+ checkError(
+ exception = e,
+ errorClass = "INTERNAL_ERROR",
+ parameters = Map("message" -> "Cannot terminate expression: 'foo()"),
+ sqlState = "XX000")
+ }
+
+ test("INTERNAL_ERROR: Initializing JavaBean with non existing method") {
+ val e = intercept[SparkException] {
+ val initializeWithNonexistingMethod = InitializeJavaBean(
+ Literal.fromObject(new java.util.LinkedList[Int]),
+ Map("nonexistent" -> Literal(1)))
+ initializeWithNonexistingMethod.eval()
+ }
+ checkError(
+ exception = e,
+ errorClass = "INTERNAL_ERROR",
+ parameters = Map(
+ "message" -> ("""A method named "nonexistent" is not declared in """ +
+ "any enclosing class nor any supertype")),
+ sqlState = "XX000")
Review Comment:
@itholic Yes, thank you. I actually noticed that there's already a test present for this error in RateStreamProviderSuite.scala:
https://github.com/apache/spark/blob/edafe266144c5c70852491fef9bb6907a001b286/sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamProviderSuite.scala#L217-L237
I'm not sure if it makes sense to move it or do anything more at all with this error, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #40236: [SPARK-38735][SQL][TESTS] Add tests for the error class: INTERNAL_ERROR
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #40236:
URL: https://github.com/apache/spark/pull/40236#issuecomment-1462661888
+1, LGTM. Merging to master.
Thank you, @the8thC and @itholic for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #40236: [SPARK-38735][SQL][TESTS] Add tests for the error class: INTERNAL_ERROR
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #40236: [SPARK-38735][SQL][TESTS] Add tests for the error class: INTERNAL_ERROR
URL: https://github.com/apache/spark/pull/40236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] the8thC commented on pull request #40236: [SPARK-38735][SQL][Tests] Add tests for the error class: INTERNAL_ERROR
Posted by "the8thC (via GitHub)" <gi...@apache.org>.
the8thC commented on PR #40236:
URL: https://github.com/apache/spark/pull/40236#issuecomment-1453042684
@MaxGekk Can you take a look at this please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #40236: [SPARK-38735][SQL][Tests] Add tests for the error class: INTERNAL_ERROR
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #40236:
URL: https://github.com/apache/spark/pull/40236#discussion_r1124931668
##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala:
##########
@@ -765,6 +770,58 @@ class QueryExecutionErrorsSuite
)
}
}
+
+ test("INTERNAL_ERROR: Calling eval on Unevaluable expression") {
+ val e = intercept[SparkException] {
+ Parameter("foo").eval()
+ }
+ checkError(
+ exception = e,
+ errorClass = "INTERNAL_ERROR",
+ parameters = Map("message" -> "Cannot evaluate expression: parameter(foo)"),
+ sqlState = "XX000")
+ }
+
+ test("INTERNAL_ERROR: Calling doGenCode on unresolved") {
+ val e = intercept[SparkException] {
+ val ctx = new CodegenContext
+ Grouping(Parameter("foo")).genCode(ctx)
+ }
+ checkError(
+ exception = e,
+ errorClass = "INTERNAL_ERROR",
+ parameters = Map(
+ "message" -> ("Cannot generate code for expression: " +
+ "grouping(parameter(foo))")),
+ sqlState = "XX000")
+ }
+
+ test("INTERNAL_ERROR: Calling terminate on UnresolvedGenerator") {
+ val e = intercept[SparkException] {
+ UnresolvedGenerator(FunctionIdentifier("foo"), Seq.empty).terminate()
+ }
+ checkError(
+ exception = e,
+ errorClass = "INTERNAL_ERROR",
+ parameters = Map("message" -> "Cannot terminate expression: 'foo()"),
+ sqlState = "XX000")
+ }
+
+ test("INTERNAL_ERROR: Initializing JavaBean with non existing method") {
+ val e = intercept[SparkException] {
+ val initializeWithNonexistingMethod = InitializeJavaBean(
+ Literal.fromObject(new java.util.LinkedList[Int]),
+ Map("nonexistent" -> Literal(1)))
+ initializeWithNonexistingMethod.eval()
+ }
+ checkError(
+ exception = e,
+ errorClass = "INTERNAL_ERROR",
+ parameters = Map(
+ "message" -> ("""A method named "nonexistent" is not declared in """ +
+ "any enclosing class nor any supertype")),
+ sqlState = "XX000")
Review Comment:
Seems like maybe we have one more `INTERNAL_ERROR` in `QueryExecutionErrors` ?
```scala
def incorrectEndOffset(rowsPerSecond: Long,
maxSeconds: Long,
endSeconds: Long): Throwable = {
SparkException.internalError(
s"Max offset with ${rowsPerSecond.toString} rowsPerSecond is ${maxSeconds.toString}, " +
s"but it's ${endSeconds.toString} now.")
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #40236: [SPARK-38735][SQL][TESTS] Add tests for the error class: INTERNAL_ERROR
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #40236:
URL: https://github.com/apache/spark/pull/40236#discussion_r1125682909
##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala:
##########
@@ -765,6 +770,58 @@ class QueryExecutionErrorsSuite
)
}
}
+
+ test("INTERNAL_ERROR: Calling eval on Unevaluable expression") {
+ val e = intercept[SparkException] {
+ Parameter("foo").eval()
+ }
+ checkError(
+ exception = e,
+ errorClass = "INTERNAL_ERROR",
+ parameters = Map("message" -> "Cannot evaluate expression: parameter(foo)"),
+ sqlState = "XX000")
+ }
+
+ test("INTERNAL_ERROR: Calling doGenCode on unresolved") {
+ val e = intercept[SparkException] {
+ val ctx = new CodegenContext
+ Grouping(Parameter("foo")).genCode(ctx)
+ }
+ checkError(
+ exception = e,
+ errorClass = "INTERNAL_ERROR",
+ parameters = Map(
+ "message" -> ("Cannot generate code for expression: " +
+ "grouping(parameter(foo))")),
+ sqlState = "XX000")
+ }
+
+ test("INTERNAL_ERROR: Calling terminate on UnresolvedGenerator") {
+ val e = intercept[SparkException] {
+ UnresolvedGenerator(FunctionIdentifier("foo"), Seq.empty).terminate()
+ }
+ checkError(
+ exception = e,
+ errorClass = "INTERNAL_ERROR",
+ parameters = Map("message" -> "Cannot terminate expression: 'foo()"),
+ sqlState = "XX000")
+ }
+
+ test("INTERNAL_ERROR: Initializing JavaBean with non existing method") {
+ val e = intercept[SparkException] {
+ val initializeWithNonexistingMethod = InitializeJavaBean(
+ Literal.fromObject(new java.util.LinkedList[Int]),
+ Map("nonexistent" -> Literal(1)))
+ initializeWithNonexistingMethod.eval()
+ }
+ checkError(
+ exception = e,
+ errorClass = "INTERNAL_ERROR",
+ parameters = Map(
+ "message" -> ("""A method named "nonexistent" is not declared in """ +
+ "any enclosing class nor any supertype")),
+ sqlState = "XX000")
Review Comment:
It's fine if it's already tested :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] the8thC commented on pull request #40236: [SPARK-38735][SQL][Tests] Add tests for the error class: INTERNAL_ERROR
Posted by "the8thC (via GitHub)" <gi...@apache.org>.
the8thC commented on PR #40236:
URL: https://github.com/apache/spark/pull/40236#issuecomment-1451377823
The build is failing due to formatting issues, but due to older code: should I patch it all in this PR or create a separate one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #40236: [SPARK-38735][SQL][TESTS] Add tests for the error class: INTERNAL_ERROR
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #40236:
URL: https://github.com/apache/spark/pull/40236#issuecomment-1462664558
@the8thC Congratulations with your first contribution to Apache Spark!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #40236: [SPARK-38735][SQL][TESTS] Add tests for the error class: INTERNAL_ERROR
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #40236:
URL: https://github.com/apache/spark/pull/40236#issuecomment-1462210586
@the8thC Do you have an account of OSS JIRA (https://issues.apache.org/jira/browse/SPARK-38735)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org