You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@libcloud.apache.org by elesbom <gi...@git.apache.org> on 2018/09/24 16:40:33 UTC

[GitHub] libcloud pull request #1240: [LIBCLOUD-1014] Accept tags when create a snaps...

GitHub user elesbom opened a pull request:

    https://github.com/apache/libcloud/pull/1240

    [LIBCLOUD-1014] Accept tags when create a snapshot

    ## Accept tags when create snapshot
    
    ### Description
     In my aws account have a lot of snapshots of many different projects. To organize that, i need to create tags in my snapshots. Looking the method [create_volume_snapshot](https://libcloud.readthedocs.io/en/latest/compute/drivers/ec2.html#libcloud.compute.drivers.ec2.BaseEC2NodeDriver.create_volume_snapshot) i can't create tags. This pull request allow you pass tags to snapshot. Link for [jira](https://issues.apache.org/jira/browse/LIBCLOUD-1014)
    
    ### Status
    - done, ready for review
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [ ] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/elesbom/libcloud LIBCLOUD-1014_tags_for_snapshot

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1240.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1240
    
----
commit 53d2b2c2044f910cde13e6660590545559d5870a
Author: elesbom <ra...@...>
Date:   2018-09-24T16:18:42Z

    [LIBCLOUD-1014] Accept metadata when create a snapshot

----


---

[GitHub] libcloud pull request #1240: [LIBCLOUD-1014] Accept tags when create a snaps...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/libcloud/pull/1240


---