[GitHub] spark pull request #21122: [SPARK-24017] [SQL] Refactor ExternalCatalog to b...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21122#discussion_r185967201
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala ---
    @@ -31,10 +30,16 @@ import org.apache.spark.util.ListenerBus
      *
      * Implementations should throw [[NoSuchDatabaseException]] when databases don't exist.
      */
    -abstract class ExternalCatalog
    -  extends ListenerBus[ExternalCatalogEventListener, ExternalCatalogEvent] {
    +trait ExternalCatalog {
       import CatalogTypes.TablePartitionSpec
     
    +  // Returns the underlying catalog class (e.g., HiveExternalCatalog).
    +  def unwrapped: ExternalCatalog = this
    --- End diff --
    
    Sure, let us get rid of it from this interface. We can do it in ExternalCatalogWithListener.scala


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org