You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/14 00:11:01 UTC
[GitHub] [incubator-nuttx] acassis opened a new pull request #3052: Add support to LCD ST7789 on STM32F4Discovery
acassis opened a new pull request #3052:
URL: https://github.com/apache/incubator-nuttx/pull/3052
## Summary
Modify the ST7789 driver to allow change X/Y resolution
and
Add support to LCD ST7789 on STM32F4Discovery
## Impact
Only on ST7789 and STM32F4Discovery
## Testing
Tested on STM32F4Discovery
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3052: Add support to LCD ST7789 on STM32F4Discovery
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #3052:
URL: https://github.com/apache/incubator-nuttx/pull/3052#discussion_r593891872
##########
File path: boards/arm/stm32/stm32f4discovery/src/stm32_spi.c
##########
@@ -196,9 +199,11 @@ uint8_t stm32_spi1status(FAR struct spi_dev_s *dev, uint32_t devid)
#endif
#ifdef CONFIG_STM32_SPI2
-void stm32_spi2select(FAR struct spi_dev_s *dev, uint32_t devid, bool selected)
+void stm32_spi2select(FAR struct spi_dev_s *dev, uint32_t devid,
+ bool selected)
{
- spiinfo("devid: %d CS: %s\n", (int)devid, selected ? "assert" : "de-assert");
+ spiinfo("devid: %d CS: %s\n", (int)devid, selected ? "assert" : \
Review comment:
ditto
##########
File path: boards/arm/stm32/stm32f4discovery/src/stm32_spi.c
##########
@@ -133,9 +134,11 @@ void weak_function stm32_spidev_initialize(void)
****************************************************************************/
#ifdef CONFIG_STM32_SPI1
-void stm32_spi1select(FAR struct spi_dev_s *dev, uint32_t devid, bool selected)
+void stm32_spi1select(FAR struct spi_dev_s *dev, uint32_t devid,
+ bool selected)
{
- spiinfo("devid: %d CS: %s\n", (int)devid, selected ? "assert" : "de-assert");
+ spiinfo("devid: %d CS: %s\n", (int)devid, selected ? "assert" : \
Review comment:
```suggestion
spiinfo("devid: %d CS: %s\n", (int)devid, selected ? "assert" :
```
##########
File path: boards/arm/stm32/stm32f4discovery/src/stm32_spi.c
##########
@@ -239,9 +244,11 @@ uint8_t stm32_spi2status(FAR struct spi_dev_s *dev, uint32_t devid)
#endif
#ifdef CONFIG_STM32_SPI3
-void stm32_spi3select(FAR struct spi_dev_s *dev, uint32_t devid, bool selected)
+void stm32_spi3select(FAR struct spi_dev_s *dev, uint32_t devid,
+ bool selected)
{
- spiinfo("devid: %d CS: %s\n", (int)devid, selected ? "assert" : "de-assert");
+ spiinfo("devid: %d CS: %s\n", (int)devid, selected ? "assert" : \
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3052: Add support to LCD ST7789 on STM32F4Discovery
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #3052:
URL: https://github.com/apache/incubator-nuttx/pull/3052
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #3052: Add support to LCD ST7789 on STM32F4Discovery
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3052:
URL: https://github.com/apache/incubator-nuttx/pull/3052#issuecomment-798957249
Thank you @xiaoxiang781216 fixed and squashed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org