[jira] [Commented] (SLING-2523) Improve the JCR Installer

["Bertrand Delacretaz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402070#comment-13402070 ] 

Bertrand Delacretaz commented on SLING-2523:
--------------------------------------------

> ...it would be nice if the jcr installer waits befire reporting changes from an observation event and looks if there is not another observation event coming in "right after"...

IIRC this is exactly the reason for the current design where an observation event just sets a flag or timer, and a separate thread acts on it only if no events have been received in a given amount of time.

(I'm not saying the current design needs to stay as is, but there might be some good things in it ;-)
                
> Improve the JCR Installer
> -------------------------
>
>                 Key: SLING-2523
>                 URL: https://issues.apache.org/jira/browse/SLING-2523
>             Project: Sling
>          Issue Type: Improvement
>          Components: Installer
>    Affects Versions: JCR Installer 3.1.4
>            Reporter: Carsten Ziegeler
>
> The current implementation has some drawbacks: 
> - it registers several observation listeners
> - to handle deletes it has to register even more listeners
> - observation events are just used as markers and there is a polling thread running continously to check for changed markers and then rescan a sub tree in the repository
> - changes are not reported to the OSGi installer in one method call
> I think we can simplify and improve the implementation by
> - just registering a single observation listener for root and then do simple path matching operations
> - use the observation events to detect what has changed
> - report the changes in a single method call
> In addition it would be nice if the jcr installer waits befire reporting changes from an observation event and looks if there is not another observation event coming in "right after". This could improve situations where changes are not done by a single save but by a serious of saves

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira