You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafodion.apache.org by su...@apache.org on 2017/04/11 18:23:46 UTC

[1/2] incubator-trafodion git commit: [TRAFODION-2586] UPSERT USING LOAD running slower than UPSERT with transactions disabled

Repository: incubator-trafodion
Updated Branches:
  refs/heads/master 322fddace -> aa47bdd90


[TRAFODION-2586] UPSERT USING LOAD running slower than UPSERT with transactions disabled

Showplan indicates problem is likely in initial queue length. Particularly for rowset upserts that are used for trickle loading, the number of rows in each statement si not sufficient for the queue resize to kick in.


Project: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/commit/7430548e
Tree: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/tree/7430548e
Diff: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/diff/7430548e

Branch: refs/heads/master
Commit: 7430548e6e81d5a064461ef72ea26744920d4426
Parents: 0c88f43
Author: Suresh Subbiah <su...@apache.org>
Authored: Tue Apr 11 05:38:13 2017 +0000
Committer: Suresh Subbiah <su...@apache.org>
Committed: Tue Apr 11 05:38:13 2017 +0000

----------------------------------------------------------------------
 core/sql/generator/GenRelUpdate.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-trafodion/blob/7430548e/core/sql/generator/GenRelUpdate.cpp
----------------------------------------------------------------------
diff --git a/core/sql/generator/GenRelUpdate.cpp b/core/sql/generator/GenRelUpdate.cpp
index dfdcb40..1698ea2 100644
--- a/core/sql/generator/GenRelUpdate.cpp
+++ b/core/sql/generator/GenRelUpdate.cpp
@@ -2691,8 +2691,9 @@ short HbaseInsert::codeGen(Generator *generator)
   queue_index downqueuelength = (queue_index)getDefault(GEN_DP2I_SIZE_DOWN);
   Int32 numBuffers = getDefault(GEN_DP2I_NUM_BUFFERS);
 
-  if (getInsertType() == Insert::VSBB_INSERT_USER &&
-              generator->oltOptInfo()->multipleRowsReturned())
+  if ((getInsertType() == Insert::VSBB_INSERT_USER || // covers upsert
+       getInsertType() == Insert::UPSERT_LOAD)  && // covers upsert using load and bulk load
+      generator->oltOptInfo()->multipleRowsReturned())
   {
     downqueuelength = getDefault(HBASE_ROWSET_VSBB_SIZE);
     queue_index dq = 1;


[2/2] incubator-trafodion git commit: Merge [TRAFODION-2586] PR-1059 UPSERT USING LOAD running slower than UPSERT

Posted by su...@apache.org.
Merge [TRAFODION-2586] PR-1059 UPSERT USING LOAD running slower than UPSERT


Project: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/commit/aa47bdd9
Tree: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/tree/aa47bdd9
Diff: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/diff/aa47bdd9

Branch: refs/heads/master
Commit: aa47bdd902d2fb3e55931345bfef6cd8d97b2430
Parents: 322fdda 7430548
Author: Suresh Subbiah <su...@apache.org>
Authored: Tue Apr 11 18:23:33 2017 +0000
Committer: Suresh Subbiah <su...@apache.org>
Committed: Tue Apr 11 18:23:33 2017 +0000

----------------------------------------------------------------------
 core/sql/generator/GenRelUpdate.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------