[jira] [Comment Edited] (KAFKA-5846) Use singleton NoOpConsumerRebalanceListener in subscribe() call where listener is not specified

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191405#comment-16191405 ] 

Ted Yu edited comment on KAFKA-5846 at 11/5/17 3:32 AM:
--------------------------------------------------------

Patch looks good.


was (Author: yuzhihong@gmail.com):
Patch looks good .

> Use singleton NoOpConsumerRebalanceListener in subscribe() call where listener is not specified
> -----------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-5846
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5846
>             Project: Kafka
>          Issue Type: Task
>            Reporter: Ted Yu
>            Assignee: Kamal Chandraprakash
>            Priority: Minor
>
> Currently KafkaConsumer creates instance of NoOpConsumerRebalanceListener for each subscribe() call where ConsumerRebalanceListener is not specified:
> {code}
>     public void subscribe(Pattern pattern) {
>         subscribe(pattern, new NoOpConsumerRebalanceListener());
> {code}
> We can create a singleton NoOpConsumerRebalanceListener to be used in such scenarios.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)