[jira] [Comment Edited] (SLING-2883) deal with - eg encode - "/" in property names (was: proper encode properties - and filter anything like jcr:created...)

["Stefan Egli (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667682#comment-13667682 ] 

Stefan Egli edited comment on SLING-2883 at 5/27/13 10:28 AM:
--------------------------------------------------------------

PropertyProvider.PROPERTY_PROPERTIES already states that  
  "A property name must only contain alphanumeric characters plus ., _, -."

Hence there's no need to handle anything else indeed.

Except what is better is to filter out any invalid properties (at bindPropertyProvider time) and issue a warn instead. Plus dont deliver 'jcr:created' and 'jcr:createdBy' in the InstanceDescription property getters..
                
      was (Author: egli):
    PropertyProvider.PROPERTY_PROPERTIES already states that  
  "A property name must only contain alphanumeric characters plus ., _, -."

Hence there's no need to handle anything else indeed.

Except what is better is to filter out any invalid properties (and bindPropertyProvider time) and issue a warn instead. Plus dont deliver 'jcr:created' and 'jcr:createdBy' in the InstanceDescription property getters..
                  
> deal with - eg encode - "/" in property names (was: proper encode properties - and filter anything like jcr:created...)
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: SLING-2883
>                 URL: https://issues.apache.org/jira/browse/SLING-2883
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: Discovery Impl 1.0.0
>            Reporter: Stefan Egli
>            Assignee: Stefan Egli
>            Priority: Minor
>
> properties provided by PropertyProviders in discovery.impl are currently handed 1:1 as name (key) to jcr/repository. This will not work for special characters. A proper encoding must be implemented.
> Similarly, any jcr name including ':' (eg 'jcr:created' etc) must not be treated as a property and not be made visible to the users of the discovery.api - the filter done as a hotfix in SLING-2880 is not sufficient.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira