[GitHub] [qpid-proton] gemmellr commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

[GitBox <gi...@apache.org>]

gemmellr commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r616479712



##########
File path: cpp/src/sender.cpp
##########
@@ -64,10 +64,18 @@ namespace {
 uint64_t tag_counter = 0;

Review comment:
       @jiridanek Is the C++ binding sender actually considered thread-safe? I definitely didnt believe it to be, I think none of them are, and the C stuff its calling underneath certainly isnt. If its not then the tag generation doesnt seem a concern. The [pre-existing] approach used clearly isnt thread safe, multiple threads cant safely pre-/post-increment a simple shared value without some protection, but thats fine if it isnt intended or needed to be. The link usage in the send method also appears unprotected to my [admittedly C++ oblivious] eyes, which would mean its all inherently unsafe anyway, and duplicate tags is likely on the lesser end of issues that could come up in there.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org