You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/22 01:58:51 UTC

[GitHub] [spark] viirya opened a new pull request #29513: [SPARK-32646][SQL][BRANCH-3.0] ORC predicate pushdown should work with case-insensitive analysis

viirya opened a new pull request #29513:
URL: https://github.com/apache/spark/pull/29513


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   This PR proposes to fix ORC predicate pushdown under case-insensitive analysis case. The field names in pushed down predicates don't need to match in exact letter case with physical field names in ORC files, if we enable case-insensitive analysis.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   Currently ORC predicate pushdown doesn't work with case-insensitive analysis. A predicate "a < 0" cannot pushdown to ORC file with field name "A" under case-insensitive analysis.
   
   But Parquet predicate pushdown works with this case. We should make ORC predicate pushdown work with case-insensitive analysis too.
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   Yes, after this PR, under case-insensitive analysis, ORC predicate pushdown will work.
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   
   Unit tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29513: [SPARK-32646][SQL][3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678950575






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678604799






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya edited a comment on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
viirya edited a comment on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678719209


   Err.. I think these tests are already failed in current branch-3.0 branch. Please see https://github.com/apache/spark/pull/29517. I created SPARK-32689 to track it.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678604380


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29513: [SPARK-32646][SQL][3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-679071996


   **[Test build #127832 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127832/testReport)** for PR 29513 at commit [`a19e523`](https://github.com/apache/spark/commit/a19e523a02b7ef39213aabb130d554839a50beeb).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `  case class OrcPrimitiveField(fieldName: String, fieldType: DataType)`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678678563






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678579099






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678603622






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29513: [SPARK-32646][SQL][3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678897328






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678678436


   **[Test build #127785 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127785/testReport)** for PR 29513 at commit [`a19e523`](https://github.com/apache/spark/commit/a19e523a02b7ef39213aabb130d554839a50beeb).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678644204


   **[Test build #127780 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127780/testReport)** for PR 29513 at commit [`a19e523`](https://github.com/apache/spark/commit/a19e523a02b7ef39213aabb130d554839a50beeb).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678673436






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678677947


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on pull request #29513: [SPARK-32646][SQL][3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-679633036


   Thanks! @cloud-fan


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678606156


   **[Test build #127771 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127771/testReport)** for PR 29513 at commit [`a19e523`](https://github.com/apache/spark/commit/a19e523a02b7ef39213aabb130d554839a50beeb).
    * This patch **fails due to an unknown error code, -9**.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `  case class OrcPrimitiveField(fieldName: String, fieldType: DataType)`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678703535


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678678436


   **[Test build #127785 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127785/testReport)** for PR 29513 at commit [`a19e523`](https://github.com/apache/spark/commit/a19e523a02b7ef39213aabb130d554839a50beeb).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678579099






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29513: [SPARK-32646][SQL][3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-679072948






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29513: [SPARK-32646][SQL][3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678950009


   **[Test build #127832 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127832/testReport)** for PR 29513 at commit [`a19e523`](https://github.com/apache/spark/commit/a19e523a02b7ef39213aabb130d554839a50beeb).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678606174






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29513: [SPARK-32646][SQL][3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678897328






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678644334






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678678563






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29513: [SPARK-32646][SQL][3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678950575






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29513: [SPARK-32646][SQL][3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678947245






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678644204


   **[Test build #127780 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127780/testReport)** for PR 29513 at commit [`a19e523`](https://github.com/apache/spark/commit/a19e523a02b7ef39213aabb130d554839a50beeb).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya edited a comment on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
viirya edited a comment on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678719209


   Err.. I think these tests are already failed in current branch-3.0 and master branches. Please see https://github.com/apache/spark/pull/29517. I created SPARK-32689 to track it.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678673350


   **[Test build #127780 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127780/testReport)** for PR 29513 at commit [`a19e523`](https://github.com/apache/spark/commit/a19e523a02b7ef39213aabb130d554839a50beeb).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `  case class OrcPrimitiveField(fieldName: String, fieldType: DataType)`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678604706


   **[Test build #127771 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127771/testReport)** for PR 29513 at commit [`a19e523`](https://github.com/apache/spark/commit/a19e523a02b7ef39213aabb130d554839a50beeb).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678603462


   **[Test build #127770 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127770/testReport)** for PR 29513 at commit [`a19e523`](https://github.com/apache/spark/commit/a19e523a02b7ef39213aabb130d554839a50beeb).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `  case class OrcPrimitiveField(fieldName: String, fieldType: DataType)`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678606174


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678578964


   **[Test build #127770 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127770/testReport)** for PR 29513 at commit [`a19e523`](https://github.com/apache/spark/commit/a19e523a02b7ef39213aabb130d554839a50beeb).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678604706


   **[Test build #127771 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127771/testReport)** for PR 29513 at commit [`a19e523`](https://github.com/apache/spark/commit/a19e523a02b7ef39213aabb130d554839a50beeb).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678703535






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on pull request #29513: [SPARK-32646][SQL][3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678947355


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29513: [SPARK-32646][SQL][3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-679072948






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678673439


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127780/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29513: [SPARK-32646][SQL][3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678947067


   **[Test build #127828 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127828/testReport)** for PR 29513 at commit [`a19e523`](https://github.com/apache/spark/commit/a19e523a02b7ef39213aabb130d554839a50beeb).
    * This patch **fails due to an unknown error code, -9**.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `  case class OrcPrimitiveField(fieldName: String, fieldType: DataType)`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678703448


   **[Test build #127785 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127785/testReport)** for PR 29513 at commit [`a19e523`](https://github.com/apache/spark/commit/a19e523a02b7ef39213aabb130d554839a50beeb).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `  case class OrcPrimitiveField(fieldName: String, fieldType: DataType)`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678719209


   Err.. I think these tests are already failed in current branch-3.0 branch. Please see https://github.com/apache/spark/pull/29517. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan closed pull request #29513: [SPARK-32646][SQL][3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #29513:
URL: https://github.com/apache/spark/pull/29513


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678578964


   **[Test build #127770 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127770/testReport)** for PR 29513 at commit [`a19e523`](https://github.com/apache/spark/commit/a19e523a02b7ef39213aabb130d554839a50beeb).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678673436


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678703538


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127785/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678710381


   Not sure if these errors are related.
   
   E.g., for `org.apache.spark.sql.hive.execution.HiveSerDeReadWriteSuite.Read/Write Hive PARQUET serde table`, this is the query plan:
   
   ```
   == Parsed Logical Plan ==
   'UnresolvedRelation [hive_serde]
   
   == Analyzed Logical Plan ==
   c1: date
   SubqueryAlias spark_catalog.default.hive_serde
   +- HiveTableRelation `default`.`hive_serde`, org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe, [c1#40752]
   
   == Optimized Logical Plan ==
   HiveTableRelation `default`.`hive_serde`, org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe, [c1#40752]
   
   == Physical Plan ==
   Scan hive default.hive_serde [c1#40752], HiveTableRelation `default`.`hive_serde`, org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe, [c1#40752]
   ```
   
   ORC unrelated and no pushdown predicate.
   
   Btw, I cannot reproduce the errors locally.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29513: [SPARK-32646][SQL][3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678897095


   **[Test build #127828 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127828/testReport)** for PR 29513 at commit [`a19e523`](https://github.com/apache/spark/commit/a19e523a02b7ef39213aabb130d554839a50beeb).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678606177


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127771/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678604799






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678643534


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29513: [SPARK-32646][SQL][3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678947245






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #29513: [SPARK-32646][SQL][3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678897095


   **[Test build #127828 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127828/testReport)** for PR 29513 at commit [`a19e523`](https://github.com/apache/spark/commit/a19e523a02b7ef39213aabb130d554839a50beeb).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on pull request #29513: [SPARK-32646][SQL][3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-679213540


   Passed hive-2.3 and hive-1.2 tests. This is ready for review now. Basically this is similar to #29457 but for 3.0 we don't have ORC nested predicate pushdown, so #29457 cannot directly backport.
   
   cc @dongjoon-hyun @cloud-fan @HyukjinKwon 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #29513: [SPARK-32646][SQL][3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678950009


   **[Test build #127832 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127832/testReport)** for PR 29513 at commit [`a19e523`](https://github.com/apache/spark/commit/a19e523a02b7ef39213aabb130d554839a50beeb).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #29513: [SPARK-32646][SQL][3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-679614653


   thanks, merging to 3.0!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678644334






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on pull request #29513: [SPARK-32646][SQL][3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678896440


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29513: [SPARK-32646][SQL][BRANCH-3.0] ORC predicate pushdown should work with case-insensitive analysis

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29513:
URL: https://github.com/apache/spark/pull/29513#issuecomment-678603622






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org