You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/19 03:26:31 UTC

[GitHub] [flink] xinbinhuang commented on pull request #17873: [FLINK-25009][CLI] Output slotSharingGroup as part of JsonGraph

xinbinhuang commented on PR #17873:
URL: https://github.com/apache/flink/pull/17873#issuecomment-1159608446

   @twalthr Thank you so much for providing the context. I agree that change fields or remove fields (i.e. change the name) should be extra careful. How about adding a new field? I believe an extra field is less a concept as JSON are generally accessed by looking up keys like a HashMap.
   
   I think `slotSharingGroup` is a useful information to better understand the topology of the job and help debugging & tuning. IMO, this extra information outweighs  the minor risk of breaking down stream systems. I see 3 options here.
   - accepts the PR and release in 1.16 
   - change the PR s.t. the `slot_sharing_group` is only added in the CLI output JSON plan but not in the SQL output.
   - reject the PR: no `slot_sharing_group` info in either CLI or SQL plan output.
   
   WDYT? @twalthr @MartijnVisser 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org