[GitHub] [tvm] jcf94 commented on pull request #7313: [AutoSchedule] Sparse dense tuning support with custom sketch rule

[GitBox <gi...@apache.org>]

jcf94 commented on pull request #7313:
URL: https://github.com/apache/tvm/pull/7313#issuecomment-789492629


   > According to our offline discussion,
   > 
   > 1. Update the type of `SearchTaskNode::task_inputs`.  Change it from `Map<String, runtime::NDArray>` to `Array<String>`, so we only need to store nd arrays in one place. We can query it from the global table in `measure.py`
   > 2. Remove `SearchTask.AddTaskInput` interface to make `SearchTask` immutable. We do not have the need to dynamically update task inputs, so we can provide all arguments to the constructors.
   > 3. Make sure we can use the same interface to support the use case where we want to match the special buffers by name
   
   @comaniac @merrymercy Comments all addressed:
   1/2: Removed the `add_task_input` API, and only provide them in constructor. Now, SearchTask only keeps the name of each special buffer.
   3: Add a extra case in `measure.py:_prepare_input_map` to check the placeholder name, as well as a unit test in `test_auto_scheduler_measure.py:test_measure_special_inputs_map_by_name`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org