You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Steve Rowe (JIRA)" <ji...@apache.org> on 2017/05/12 22:40:04 UTC
[jira] [Updated] (SOLR-10400) refactor "instanceof TrieFooField ||
instanceof FooPointsField" to use "FooValueFieldType" marker interface
[ https://issues.apache.org/jira/browse/SOLR-10400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Rowe updated SOLR-10400:
------------------------------
Attachment: SOLR-10400.patch
Updated patch to ensure all modified components test points fields.
bq. As things stand, there are a few nocommits in the patch because I'm concerned about some edge cases that were ignored in the "instanceof" code that should probably throw errors.
The nocommits were all in the expand component, concerning field types that weren't handled. I actually simplified this code to only handle 32-bit numeric field types, and not worry about/throw erros for other field types, because the collapse qparser, which is required before the expand component runs, already validates the fields used; I added a collapse qparser test that explicitly tests that using 64-bit numeric fields causes exceptions to be thrown.
I think it's ready to go. I'll commit once precommit and Solr tests pass.
> refactor "instanceof TrieFooField || instanceof FooPointsField" to use "FooValueFieldType" marker interface
> -----------------------------------------------------------------------------------------------------------
>
> Key: SOLR-10400
> URL: https://issues.apache.org/jira/browse/SOLR-10400
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Hoss Man
> Assignee: Hoss Man
> Attachments: SOLR-10400.patch, SOLR-10400.patch
>
>
> See previous comment from smiley in SOLR-9994...
> https://issues.apache.org/jira/browse/SOLR-9994?focusedCommentId=15875390&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15875390
> ...we already have the NumericValueFieldType marker interface and children.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org