You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Mirko Friedenhagen <mf...@apache.org> on 2015/03/24 21:15:20 UTC

maven-release-plugin: consolidating release:perform and release:stage

Hello everybody,

today I stumbled upon a difference between perform and stage:
- while perform takes an parameter localCheckout, stage does not
- I opened "MRELEASE-901Goal stage should take parameter localCheckout
as well" [1].
- while inspecting the code I found lot of duplicates.
- so my idea is to pull up most of the code to AbstractReleaseMojo and
consolidate most of the execute block and only differ while adding
default goals resp. setting the alternativeDeployRepository.
- one problem I see is, however, that some parameters were introduced
later on, so how to handle the @since annotations here?

Best Regards
Mirko

[1] http://jira.codehaus.org/browse/MRELEASE-901

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: maven-release-plugin: consolidating release:perform and release:stage

Posted by Mirko Friedenhagen <mf...@gmail.com>.
Concerning. @since, that's really easy then.

I had another thought: while pushChanges  does allow to defer pushing, you
have to do an extra execution of e.g. git push; git push --tags. What about
having a property pushChangesAfterDeploy in prepare and stage which would
do this in the release plugin?

Regards
Mirko
-- 
Sent from my mobile
On Mar 28, 2015 11:04 AM, "Hervé BOUTEMY" <he...@free.fr> wrote:

> the annotation takes free text, then let's try a descrptive text:
>
> @since xxx in release:perform, yyy in release:stage
>
> Regards,
>
> Hervé
>
> Le mardi 24 mars 2015 21:15:20 Mirko Friedenhagen a écrit :
> > Hello everybody,
> >
> > today I stumbled upon a difference between perform and stage:
> > - while perform takes an parameter localCheckout, stage does not
> > - I opened "MRELEASE-901Goal stage should take parameter localCheckout
> > as well" [1].
> > - while inspecting the code I found lot of duplicates.
> > - so my idea is to pull up most of the code to AbstractReleaseMojo and
> > consolidate most of the execute block and only differ while adding
> > default goals resp. setting the alternativeDeployRepository.
> > - one problem I see is, however, that some parameters were introduced
> > later on, so how to handle the @since annotations here?
> >
> > Best Regards
> > Mirko
> >
> > [1] http://jira.codehaus.org/browse/MRELEASE-901
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: maven-release-plugin: consolidating release:perform and release:stage

Posted by Hervé BOUTEMY <he...@free.fr>.
the annotation takes free text, then let's try a descrptive text:

@since xxx in release:perform, yyy in release:stage

Regards,

Hervé

Le mardi 24 mars 2015 21:15:20 Mirko Friedenhagen a écrit :
> Hello everybody,
> 
> today I stumbled upon a difference between perform and stage:
> - while perform takes an parameter localCheckout, stage does not
> - I opened "MRELEASE-901Goal stage should take parameter localCheckout
> as well" [1].
> - while inspecting the code I found lot of duplicates.
> - so my idea is to pull up most of the code to AbstractReleaseMojo and
> consolidate most of the execute block and only differ while adding
> default goals resp. setting the alternativeDeployRepository.
> - one problem I see is, however, that some parameters were introduced
> later on, so how to handle the @since annotations here?
> 
> Best Regards
> Mirko
> 
> [1] http://jira.codehaus.org/browse/MRELEASE-901
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org