You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "DL1231 (via GitHub)" <gi...@apache.org> on 2026/01/10 04:32:53 UTC
[PR] Kafka-19590: Add prefix to TopicBasedRemoteLogMetadataManagerConfig to enable setting admin configs [kafka]
DL1231 opened a new pull request, #21277:
URL: https://github.com/apache/kafka/pull/21277
Currently, `TopicBasedRemoteLogMetadataManager` creates the Admin client
using `commonProperties()`, which prevents users from setting admin-specific
configurations (e.g., custom timeouts, retry policies).
This commit adds a new configuration prefix `remote.log.metadata.admin.*` to
allow separate configuration for the Admin client, similar to the existing producer
and consumer prefixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19590: Add prefix to TopicBasedRemoteLogMetadataManagerConfig to enable setting admin configs [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #21277:
URL: https://github.com/apache/kafka/pull/21277#discussion_r2679496870
##########
docs/configuration/tiered-storage-configs.md:
##########
@@ -43,6 +43,9 @@ Additional configurations can be provided for different types of clients using t
# Configs for admin, producer, and consumer clients
<rlmm.prefix>.remote.log.metadata.common.client.<kafka.property> = <value>
+
+ # Configs only for admin client
+ <rlmm.prefix>.remote.log.metadata.admin.<kafka.property> = <value>
Review Comment:
Could you please document this fantastic feature in `upgrade.md`?
##########
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerConfig.java:
##########
@@ -246,6 +264,7 @@ public String toString() {
", commonProps=" + configMapToRedactedString(commonProps, AdminClientConfig.configDef()) +
Review Comment:
Since `commonProps` has been replaced by `adminProps`, do we still need to expose it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19590: Add prefix to TopicBasedRemoteLogMetadataManagerConfig to enable setting admin configs [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #21277:
URL: https://github.com/apache/kafka/pull/21277#discussion_r2683099951
##########
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerConfig.java:
##########
@@ -232,6 +245,12 @@ private Map<String, Object> createProducerProps(Map<String, Object> allProducerC
return Collections.unmodifiableMap(props);
}
+ private Map<String, Object> createAdminProps(Map<String, Object> allAdminConfigs) {
+ Map<String, Object> props = new HashMap<>(allAdminConfigs);
+ props.put(ProducerConfig.CLIENT_ID_CONFIG, clientIdPrefix + "_admin");
Review Comment:
`ProducerConfig` -> `AdminClientConfig`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19590: Add prefix to TopicBasedRemoteLogMetadataManagerConfig to enable setting admin configs [kafka]
Posted by "DL1231 (via GitHub)" <gi...@apache.org>.
DL1231 commented on code in PR #21277:
URL: https://github.com/apache/kafka/pull/21277#discussion_r2681379196
##########
docs/configuration/tiered-storage-configs.md:
##########
@@ -43,6 +43,9 @@ Additional configurations can be provided for different types of clients using t
# Configs for admin, producer, and consumer clients
<rlmm.prefix>.remote.log.metadata.common.client.<kafka.property> = <value>
+
+ # Configs only for admin client
+ <rlmm.prefix>.remote.log.metadata.admin.<kafka.property> = <value>
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19590: Add prefix to TopicBasedRemoteLogMetadataManagerConfig to enable setting admin configs [kafka]
Posted by "DL1231 (via GitHub)" <gi...@apache.org>.
DL1231 commented on code in PR #21277:
URL: https://github.com/apache/kafka/pull/21277#discussion_r2681378457
##########
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerConfig.java:
##########
@@ -246,6 +264,7 @@ public String toString() {
", commonProps=" + configMapToRedactedString(commonProps, AdminClientConfig.configDef()) +
Review Comment:
Good catch, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19590: Add prefix to TopicBasedRemoteLogMetadataManagerConfig to enable setting admin configs [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #21277:
URL: https://github.com/apache/kafka/pull/21277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org