You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Kenneth Giusti <kg...@apache.org> on 2015/10/29 15:57:16 UTC
Review Request 39759: 0.9.x - do not call super() on exception classes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39759/
-----------------------------------------------------------
Review request for qpid and Justin Ross.
Bugs: PROTON-1032
https://issues.apache.org/jira/browse/PROTON-1032
Repository: qpid-proton-git
Description
-------
Python 2.4 (which is supported by 0.9.x, but not 0.10+) fails if super is called on a class derived from Exception
Diffs
-----
proton-c/bindings/python/proton/utils.py b5ecdf7
Diff: https://reviews.apache.org/r/39759/diff/
Testing
-------
Unit tests
Manually instantiated affected classes in python 2.4 environment.
Thanks,
Kenneth Giusti
Re: Review Request 39759: 0.9.x - do not call super() on exception
classes
Posted by Justin Ross <jr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39759/#review104446
-----------------------------------------------------------
Ship it!
Ship It!
- Justin Ross
On Oct. 29, 2015, 2:57 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39759/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2015, 2:57 p.m.)
>
>
> Review request for qpid and Justin Ross.
>
>
> Bugs: PROTON-1032
> https://issues.apache.org/jira/browse/PROTON-1032
>
>
> Repository: qpid-proton-git
>
>
> Description
> -------
>
> Python 2.4 (which is supported by 0.9.x, but not 0.10+) fails if super is called on a class derived from Exception
>
>
> Diffs
> -----
>
> proton-c/bindings/python/proton/utils.py b5ecdf7
>
> Diff: https://reviews.apache.org/r/39759/diff/
>
>
> Testing
> -------
>
> Unit tests
> Manually instantiated affected classes in python 2.4 environment.
>
>
> Thanks,
>
> Kenneth Giusti
>
>