You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/15 10:55:08 UTC
[GitHub] [incubator-mxnet] liuzh91 opened a new pull request #17322: Add
event handlers in validation handler
liuzh91 opened a new pull request #17322: Add event handlers in validation handler
URL: https://github.com/apache/incubator-mxnet/pull/17322
## Description ##
Add customized event handlers in `ValidationHandler`, fixes #17320
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- [ ] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] roywei merged pull request #17322: Add event
handlers in validation handler
Posted by GitBox <gi...@apache.org>.
roywei merged pull request #17322: Add event handlers in validation handler
URL: https://github.com/apache/incubator-mxnet/pull/17322
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #17322: Add event
handlers in validation handler
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17322: Add event handlers in validation handler
URL: https://github.com/apache/incubator-mxnet/pull/17322#issuecomment-577419739
Restarted failing CI run http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-gpu/detail/PR-17322/4/pipeline/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] liuzh91 commented on a change in pull request
#17322: Add event handlers in validation handler
Posted by GitBox <gi...@apache.org>.
liuzh91 commented on a change in pull request #17322: Add event handlers in validation handler
URL: https://github.com/apache/incubator-mxnet/pull/17322#discussion_r367217067
##########
File path: python/mxnet/gluon/contrib/estimator/event_handler.py
##########
@@ -181,14 +181,17 @@ class ValidationHandler(TrainBegin, BatchEnd, EpochEnd):
Priority level of the ValidationHandler. Priority level is sorted in
ascending order. The lower the number is, the higher priority level the
handler is.
+ event_handlers : EventHandler or list of EventHandlers
Review comment:
doc string added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] roywei commented on a change in pull request
#17322: Add event handlers in validation handler
Posted by GitBox <gi...@apache.org>.
roywei commented on a change in pull request #17322: Add event handlers in validation handler
URL: https://github.com/apache/incubator-mxnet/pull/17322#discussion_r367176134
##########
File path: python/mxnet/gluon/contrib/estimator/event_handler.py
##########
@@ -181,14 +181,17 @@ class ValidationHandler(TrainBegin, BatchEnd, EpochEnd):
Priority level of the ValidationHandler. Priority level is sorted in
ascending order. The lower the number is, the higher priority level the
handler is.
+ event_handlers : EventHandler or list of EventHandlers
Review comment:
Could you add more detailed doc? Something like " EventHandler or list of EventHandlers to be used by the `eval_fn`". Otherwise, it will be confusing for users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] liuzh91 commented on issue #17322: Add event
handlers in validation handler
Posted by GitBox <gi...@apache.org>.
liuzh91 commented on issue #17322: Add event handlers in validation handler
URL: https://github.com/apache/incubator-mxnet/pull/17322#issuecomment-577022008
> @liuzh91 could you rebase so we can merge this. Thanks
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] roywei commented on issue #17322: Add event
handlers in validation handler
Posted by GitBox <gi...@apache.org>.
roywei commented on issue #17322: Add event handlers in validation handler
URL: https://github.com/apache/incubator-mxnet/pull/17322#issuecomment-576807895
@liuzh91 could you rebase so we can merge this. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services