You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/04/29 11:14:18 UTC

[GitHub] [skywalking] dmsolr commented on a change in pull request #4716: support user to customize an endpoint

dmsolr commented on a change in pull request #4716:
URL: https://github.com/apache/skywalking/pull/4716#discussion_r417237693



##########
File path: test/plugin/scenarios/apm-toolkit-trace-scenario/config/expectedData.yaml
##########
@@ -51,6 +51,18 @@ segmentItems:
       tags:
       - {key: testTag, value: testInfoParam}
       skipAnalysis: 'true'
+    - operationName: tool-kit-set-operation-name
+      operationId: 0,

Review comment:
       I will fix it. 
   The `operationId` has been removed since protocol V3.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org