You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/05/25 01:09:24 UTC
[GitHub] [hbase] apurtell opened a new pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
apurtell opened a new pull request #3302:
URL: https://github.com/apache/hbase/pull/3302
We introduced EnvironmentEdgeManager a long time ago as a way to inject
alternate clocks (gettimeofday() aka System.currentTimeMillis()) for
unit tests. In order for this to be effective, all callers that would
otherwise use System.currentTimeMillis() must call
EnvironmentEdgeManager.currentTime() instead, except obviously the
implementors of EnvironmentEdge.
It's common for contributors to be unaware of this practice and
reviewers might not catch it. On another subtask I will introduce a
build enforcer that bans System.currentTimeMillis() except where
we annotate to allow it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell edited a comment on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
apurtell edited a comment on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-850569022
> But sometimes we use System.currentTimeMillis just for calculating elapsed time, not for getting system clock, I'm not sure if this is also our goal here, to also replace these usages.
@Apache9 This is not the goal.
> We introduced EnvironmentEdgeManager a long time ago as a way to inject alternate clocks (gettimeofday() aka System.currentTimeMillis()) for unit tests. In order for this to be effective, all callers that would otherwise use System.currentTimeMillis() must call EnvironmentEdgeManager.currentTime() instead, except obviously the implementors of EnvironmentEdge.
>
> It's common for contributors to be unaware of this practice and reviewers might not catch it.
The goal is to fix the code is out of practice with EnvironmentEdgeManager#currentTime.
We can also do something about nanotime, but under another JIRA, please. Should we file a JIRA to discuss what to do, if anything, about nanotime?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-847548849
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 38s | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 21s | master passed |
| +1 :green_heart: | compile | 7m 14s | master passed |
| +1 :green_heart: | shadedjars | 9m 36s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 5m 19s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 5s | the patch passed |
| +1 :green_heart: | compile | 7m 21s | the patch passed |
| +1 :green_heart: | javac | 7m 21s | the patch passed |
| +1 :green_heart: | shadedjars | 9m 32s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 5m 17s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 50s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 1m 14s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 0m 45s | hbase-zookeeper in the patch passed. |
| +1 :green_heart: | unit | 0m 28s | hbase-balancer in the patch passed. |
| +1 :green_heart: | unit | 0m 49s | hbase-http in the patch passed. |
| +1 :green_heart: | unit | 1m 52s | hbase-procedure in the patch passed. |
| -1 :x: | unit | 152m 56s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 10m 37s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 7m 40s | hbase-thrift in the patch passed. |
| +1 :green_heart: | unit | 3m 5s | hbase-endpoint in the patch passed. |
| -1 :x: | unit | 17m 2s | hbase-backup in the patch failed. |
| +1 :green_heart: | unit | 1m 17s | hbase-it in the patch passed. |
| +1 :green_heart: | unit | 4m 12s | hbase-rest in the patch passed. |
| +1 :green_heart: | unit | 2m 11s | hbase-examples in the patch passed. |
| +1 :green_heart: | unit | 0m 52s | hbase-hbtop in the patch passed. |
| | | 266m 40s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3302 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 0e3f8bb6bc40 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 21aa553bc1 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-backup.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/1/testReport/ |
| Max. process+thread count | 5096 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-client hbase-zookeeper hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/1/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-848374865
Update fixes TestSimpleRpcScheduler and TestBackupDelete and checkstyle and javadoc nits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-848453843
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 1s | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 22s | master passed |
| +1 :green_heart: | compile | 7m 15s | master passed |
| +1 :green_heart: | shadedjars | 8m 15s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 5m 54s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 13s | the patch passed |
| +1 :green_heart: | compile | 7m 12s | the patch passed |
| +1 :green_heart: | javac | 7m 12s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 7s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 5m 48s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 51s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 1m 18s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 0m 46s | hbase-zookeeper in the patch passed. |
| +1 :green_heart: | unit | 5m 58s | hbase-balancer in the patch passed. |
| +1 :green_heart: | unit | 0m 47s | hbase-http in the patch passed. |
| +1 :green_heart: | unit | 1m 46s | hbase-procedure in the patch passed. |
| -1 :x: | unit | 145m 48s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 10m 33s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 7m 27s | hbase-thrift in the patch passed. |
| +1 :green_heart: | unit | 2m 56s | hbase-endpoint in the patch passed. |
| +1 :green_heart: | unit | 8m 55s | hbase-backup in the patch passed. |
| +1 :green_heart: | unit | 1m 15s | hbase-it in the patch passed. |
| +1 :green_heart: | unit | 3m 9s | hbase-rest in the patch passed. |
| +1 :green_heart: | unit | 1m 59s | hbase-examples in the patch passed. |
| +1 :green_heart: | unit | 0m 56s | hbase-hbtop in the patch passed. |
| | | 254m 33s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3302 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 51029fb4b05a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 19fd42b1dc |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/2/testReport/ |
| Max. process+thread count | 5050 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-client hbase-zookeeper hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-849297546
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 47s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 5s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 28s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 0s | master passed |
| +1 :green_heart: | compile | 13m 7s | master passed |
| +1 :green_heart: | checkstyle | 6m 10s | master passed |
| +1 :green_heart: | spotbugs | 11m 34s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 38s | the patch passed |
| +1 :green_heart: | compile | 12m 18s | the patch passed |
| +1 :green_heart: | javac | 12m 18s | the patch passed |
| -0 :warning: | checkstyle | 1m 31s | hbase-server: The patch generated 1 new + 1256 unchanged - 6 fixed = 1257 total (was 1262) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 17m 56s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 15m 41s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 3m 12s | The patch does not generate ASF License warnings. |
| | | 108m 34s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3302 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux a2c922bfb671 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a22e418cf6 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| Max. process+thread count | 96 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-client hbase-zookeeper hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/4/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-850571678
> It looks like, unless we are too specific about elapsed time that we want only nanosecond level elapsed time, we should prefer System#currentTimeMillis for the perf benefit.
@virajjasani I think this is something best discussed in a different context. Should we file a JIRA to discuss what to do, if anything, about nanotime?
Also, please read [Nanotrusting The Nanotime](https://shipilev.net/blog/2014/nanotrusting-nanotime/).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-852462312
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 28s | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 27s | master passed |
| +1 :green_heart: | compile | 7m 59s | master passed |
| +1 :green_heart: | shadedjars | 11m 1s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 5m 48s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 48s | the patch passed |
| +1 :green_heart: | compile | 8m 3s | the patch passed |
| +1 :green_heart: | javac | 8m 3s | the patch passed |
| +1 :green_heart: | shadedjars | 11m 6s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 6m 13s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 5s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 1m 28s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 0m 52s | hbase-zookeeper in the patch passed. |
| +1 :green_heart: | unit | 7m 23s | hbase-balancer in the patch passed. |
| +1 :green_heart: | unit | 0m 54s | hbase-http in the patch passed. |
| +1 :green_heart: | unit | 2m 13s | hbase-procedure in the patch passed. |
| +1 :green_heart: | unit | 160m 29s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 10m 30s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 7m 44s | hbase-thrift in the patch passed. |
| +1 :green_heart: | unit | 3m 4s | hbase-endpoint in the patch passed. |
| +1 :green_heart: | unit | 10m 10s | hbase-backup in the patch passed. |
| +1 :green_heart: | unit | 1m 19s | hbase-it in the patch passed. |
| +1 :green_heart: | unit | 4m 15s | hbase-rest in the patch passed. |
| +1 :green_heart: | unit | 2m 10s | hbase-examples in the patch passed. |
| +1 :green_heart: | unit | 0m 52s | hbase-hbtop in the patch passed. |
| | | 281m 50s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3302 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 00bacfb605a0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / e9f595307a |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/5/testReport/ |
| Max. process+thread count | 5132 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-client hbase-zookeeper hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/5/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-849872794
> What about System.nanoTime?
@Apache9 System.nanotime is not used to get the system clock. I don't mind bringing it into EnvironmentEdge but I don't care about it here. It is out of scope for all of this work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-852459174
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 5s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 30s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 14s | master passed |
| +1 :green_heart: | compile | 8m 25s | master passed |
| +1 :green_heart: | shadedjars | 9m 24s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 5m 56s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 56s | the patch passed |
| +1 :green_heart: | compile | 8m 15s | the patch passed |
| +1 :green_heart: | javac | 8m 15s | the patch passed |
| +1 :green_heart: | shadedjars | 9m 44s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 5m 56s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 58s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 1m 30s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 0m 48s | hbase-zookeeper in the patch passed. |
| +1 :green_heart: | unit | 7m 6s | hbase-balancer in the patch passed. |
| +1 :green_heart: | unit | 0m 54s | hbase-http in the patch passed. |
| +1 :green_heart: | unit | 1m 56s | hbase-procedure in the patch passed. |
| +1 :green_heart: | unit | 156m 50s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 12m 22s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 7m 25s | hbase-thrift in the patch passed. |
| +1 :green_heart: | unit | 2m 58s | hbase-endpoint in the patch passed. |
| +1 :green_heart: | unit | 8m 58s | hbase-backup in the patch passed. |
| +1 :green_heart: | unit | 1m 17s | hbase-it in the patch passed. |
| +1 :green_heart: | unit | 3m 37s | hbase-rest in the patch passed. |
| +1 :green_heart: | unit | 2m 3s | hbase-examples in the patch passed. |
| +1 :green_heart: | unit | 0m 59s | hbase-hbtop in the patch passed. |
| | | 275m 33s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3302 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux bfe9cd1a1b5c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / e9f595307a |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/5/testReport/ |
| Max. process+thread count | 4842 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-client hbase-zookeeper hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/5/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-848192638
Two test failures were relevant. Updating patch soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-850572028
Thanks for the approvals. I'm going to rebase, run tests locally, and merge if things look good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-850502504
> https://stackoverflow.com/questions/19052316/why-is-system-nanotime-way-slower-in-performance-than-system-currenttimemill
As per the Oracle blog (link to blog is obsolete): If you are interested in measuring/calculating elapsed time, then always use System.nanoTime(). On most systems it will give a resolution on the order of microseconds. Be aware though, this call can also take microseconds to execute on some platforms.
It looks like, unless we are too specific about elapsed time that we want only nanosecond level elapsed time, we should prefer System#currentTimeMillis for the perf benefit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-848410480
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 4s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 4s | master passed |
| +1 :green_heart: | compile | 12m 58s | master passed |
| +1 :green_heart: | checkstyle | 6m 2s | master passed |
| +1 :green_heart: | spotbugs | 12m 18s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 55s | the patch passed |
| +1 :green_heart: | compile | 13m 6s | the patch passed |
| +1 :green_heart: | javac | 13m 6s | the patch passed |
| -0 :warning: | checkstyle | 1m 31s | hbase-server: The patch generated 2 new + 1256 unchanged - 6 fixed = 1258 total (was 1262) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 19m 32s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 15m 0s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 3m 0s | The patch does not generate ASF License warnings. |
| | | 110m 36s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3302 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 68f17e7937aa 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 19fd42b1dc |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| Max. process+thread count | 96 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-client hbase-zookeeper hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/2/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-849215410
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 30s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 42s | master passed |
| +1 :green_heart: | compile | 6m 34s | master passed |
| +1 :green_heart: | shadedjars | 8m 24s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 5m 4s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 38s | the patch passed |
| +1 :green_heart: | compile | 6m 37s | the patch passed |
| +1 :green_heart: | javac | 6m 37s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 13s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 5m 3s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 47s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 1m 11s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 0m 45s | hbase-zookeeper in the patch passed. |
| +1 :green_heart: | unit | 6m 5s | hbase-balancer in the patch passed. |
| +1 :green_heart: | unit | 0m 48s | hbase-http in the patch passed. |
| +1 :green_heart: | unit | 1m 50s | hbase-procedure in the patch passed. |
| -1 :x: | unit | 146m 25s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 10m 45s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 7m 45s | hbase-thrift in the patch passed. |
| +1 :green_heart: | unit | 3m 3s | hbase-endpoint in the patch passed. |
| +1 :green_heart: | unit | 10m 9s | hbase-backup in the patch passed. |
| +1 :green_heart: | unit | 1m 19s | hbase-it in the patch passed. |
| +1 :green_heart: | unit | 4m 15s | hbase-rest in the patch passed. |
| +1 :green_heart: | unit | 2m 12s | hbase-examples in the patch passed. |
| +1 :green_heart: | unit | 0m 54s | hbase-hbtop in the patch passed. |
| | | 253m 57s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3302 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux f73fdff255ae 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a22e418cf6 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/3/testReport/ |
| Max. process+thread count | 5090 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-client hbase-zookeeper hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/3/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-849355716
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 37s | master passed |
| +1 :green_heart: | compile | 6m 35s | master passed |
| +1 :green_heart: | shadedjars | 8m 13s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 5m 4s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 35s | the patch passed |
| +1 :green_heart: | compile | 6m 38s | the patch passed |
| +1 :green_heart: | javac | 6m 38s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 18s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 5m 3s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 46s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 1m 10s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 0m 46s | hbase-zookeeper in the patch passed. |
| +1 :green_heart: | unit | 5m 44s | hbase-balancer in the patch passed. |
| +1 :green_heart: | unit | 0m 47s | hbase-http in the patch passed. |
| +1 :green_heart: | unit | 1m 50s | hbase-procedure in the patch passed. |
| -1 :x: | unit | 145m 37s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 10m 33s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 7m 40s | hbase-thrift in the patch passed. |
| +1 :green_heart: | unit | 3m 2s | hbase-endpoint in the patch passed. |
| +1 :green_heart: | unit | 10m 14s | hbase-backup in the patch passed. |
| +1 :green_heart: | unit | 1m 18s | hbase-it in the patch passed. |
| +1 :green_heart: | unit | 4m 14s | hbase-rest in the patch passed. |
| +1 :green_heart: | unit | 2m 11s | hbase-examples in the patch passed. |
| +1 :green_heart: | unit | 0m 52s | hbase-hbtop in the patch passed. |
| | | 252m 2s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3302 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux f398fd849413 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a22e418cf6 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/4/testReport/ |
| Max. process+thread count | 5087 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-client hbase-zookeeper hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/4/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-852358769
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 5s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 28s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 40s | master passed |
| +1 :green_heart: | compile | 12m 21s | master passed |
| +1 :green_heart: | checkstyle | 6m 10s | master passed |
| +1 :green_heart: | spotbugs | 11m 24s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 37s | the patch passed |
| +1 :green_heart: | compile | 12m 19s | the patch passed |
| +1 :green_heart: | javac | 12m 19s | the patch passed |
| -0 :warning: | checkstyle | 1m 35s | hbase-server: The patch generated 1 new + 1257 unchanged - 6 fixed = 1258 total (was 1263) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 18m 2s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 14m 30s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 3m 1s | The patch does not generate ASF License warnings. |
| | | 105m 54s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/5/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3302 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 58d98f4ec49e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / e9f595307a |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| Max. process+thread count | 96 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-client hbase-zookeeper hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/5/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-848459191
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 54s | master passed |
| +1 :green_heart: | compile | 6m 41s | master passed |
| +1 :green_heart: | shadedjars | 8m 5s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 5m 7s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 35s | the patch passed |
| +1 :green_heart: | compile | 6m 38s | the patch passed |
| +1 :green_heart: | javac | 6m 38s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 9s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 5m 6s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 48s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 1m 11s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 0m 47s | hbase-zookeeper in the patch passed. |
| +1 :green_heart: | unit | 5m 42s | hbase-balancer in the patch passed. |
| +1 :green_heart: | unit | 0m 48s | hbase-http in the patch passed. |
| +1 :green_heart: | unit | 1m 51s | hbase-procedure in the patch passed. |
| -1 :x: | unit | 155m 5s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 12m 17s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 7m 42s | hbase-thrift in the patch passed. |
| +1 :green_heart: | unit | 3m 8s | hbase-endpoint in the patch passed. |
| +1 :green_heart: | unit | 10m 26s | hbase-backup in the patch passed. |
| +1 :green_heart: | unit | 1m 25s | hbase-it in the patch passed. |
| +1 :green_heart: | unit | 4m 38s | hbase-rest in the patch passed. |
| +1 :green_heart: | unit | 2m 27s | hbase-examples in the patch passed. |
| +1 :green_heart: | unit | 0m 53s | hbase-hbtop in the patch passed. |
| | | 264m 41s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3302 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 3b082b4b4cef 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 19fd42b1dc |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/2/testReport/ |
| Max. process+thread count | 5110 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-client hbase-zookeeper hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-849094550
Rebase and fix TestRegionServerReportForDuty#testReportForDutyWithEnvironmentEdge.
This test injected ManualEnvironmentEdge and never incremented the time. It doesn't matter what the intent of the test was, this was never valid. The only reason it passed was EnvironmentEdge was not used in all places to get the time, as it should have been. Inject IncrementingEnvironmentEdge instead, now the test passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-849871673
TestWALEntryStream failure is not related. It is because of HBASE-25924, which I have reopened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-850442580
> In general we should all use System.nanoTime for calculating elapsed time, but System.nanoTime is usually slower than System.currentTimeMillis
@Apache9 do you have any ref for this? I was not aware of slowness in nanoTime. Is it negligible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-847491257
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 32s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 5s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 52s | master passed |
| +1 :green_heart: | compile | 12m 19s | master passed |
| +1 :green_heart: | checkstyle | 6m 12s | master passed |
| +1 :green_heart: | spotbugs | 11m 30s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 34s | the patch passed |
| +1 :green_heart: | compile | 12m 23s | the patch passed |
| -0 :warning: | javac | 0m 48s | hbase-mapreduce generated 1 new + 197 unchanged - 1 fixed = 198 total (was 198) |
| -0 :warning: | checkstyle | 0m 28s | hbase-client: The patch generated 2 new + 12 unchanged - 0 fixed = 14 total (was 12) |
| -0 :warning: | checkstyle | 1m 37s | hbase-server: The patch generated 19 new + 1257 unchanged - 5 fixed = 1276 total (was 1262) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 18m 5s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 14m 25s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 3m 4s | The patch does not generate ASF License warnings. |
| | | 106m 9s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3302 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 4ebfc877c1be 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 21aa553bc1 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-mapreduce.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| Max. process+thread count | 96 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-client hbase-zookeeper hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/1/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-850043118
> > What about System.nanoTime?
>
> @Apache9 System.nanotime is not used to get the system clock. I don't mind bringing it into EnvironmentEdge but I don't care about it here. It is out of scope for all of this work.
>
> Feel free to file a follow up JIRA, to add it to EnvironmentEdge in the future, if you would like.
But sometimes we use System.currentTimeMillis just for calculating elapsed time, not for getting system clock, I'm not sure if this is also our goal here, to also replace these usages.
In general we should all use System.nanoTime for calculating elapsed time, but System.nanoTime is usually slower than System.currentTimeMillis...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-847547207
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 33s | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 27s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 5s | master passed |
| +1 :green_heart: | compile | 7m 55s | master passed |
| +1 :green_heart: | shadedjars | 9m 32s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 6m 6s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 30s | the patch passed |
| +1 :green_heart: | compile | 7m 39s | the patch passed |
| +1 :green_heart: | javac | 7m 39s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 23s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 5m 51s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 51s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 1m 17s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 0m 46s | hbase-zookeeper in the patch passed. |
| +1 :green_heart: | unit | 0m 30s | hbase-balancer in the patch passed. |
| +1 :green_heart: | unit | 0m 47s | hbase-http in the patch passed. |
| +1 :green_heart: | unit | 1m 43s | hbase-procedure in the patch passed. |
| -1 :x: | unit | 149m 55s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 10m 33s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 7m 26s | hbase-thrift in the patch passed. |
| +1 :green_heart: | unit | 2m 59s | hbase-endpoint in the patch passed. |
| -1 :x: | unit | 14m 39s | hbase-backup in the patch failed. |
| +1 :green_heart: | unit | 1m 16s | hbase-it in the patch passed. |
| +1 :green_heart: | unit | 3m 11s | hbase-rest in the patch passed. |
| +1 :green_heart: | unit | 1m 58s | hbase-examples in the patch passed. |
| +1 :green_heart: | unit | 0m 56s | hbase-hbtop in the patch passed. |
| | | 263m 21s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3302 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 463cc188fecf 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 21aa553bc1 |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-backup.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/1/testReport/ |
| Max. process+thread count | 4986 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-client hbase-zookeeper hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/1/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-849360194
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 8s | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 27s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 10s | master passed |
| +1 :green_heart: | compile | 7m 15s | master passed |
| +1 :green_heart: | shadedjars | 8m 14s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 5m 47s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 11s | the patch passed |
| +1 :green_heart: | compile | 7m 12s | the patch passed |
| +1 :green_heart: | javac | 7m 12s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 10s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 5m 49s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 49s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 1m 18s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 0m 48s | hbase-zookeeper in the patch passed. |
| +1 :green_heart: | unit | 5m 55s | hbase-balancer in the patch passed. |
| +1 :green_heart: | unit | 0m 47s | hbase-http in the patch passed. |
| +1 :green_heart: | unit | 1m 43s | hbase-procedure in the patch passed. |
| -1 :x: | unit | 150m 20s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 11m 16s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 7m 24s | hbase-thrift in the patch passed. |
| +1 :green_heart: | unit | 2m 55s | hbase-endpoint in the patch passed. |
| +1 :green_heart: | unit | 9m 9s | hbase-backup in the patch passed. |
| +1 :green_heart: | unit | 1m 10s | hbase-it in the patch passed. |
| +1 :green_heart: | unit | 3m 48s | hbase-rest in the patch passed. |
| +1 :green_heart: | unit | 1m 59s | hbase-examples in the patch passed. |
| +1 :green_heart: | unit | 0m 50s | hbase-hbtop in the patch passed. |
| | | 259m 47s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3302 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux d7938c7e8336 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a22e418cf6 |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/4/testReport/ |
| Max. process+thread count | 4858 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-client hbase-zookeeper hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/4/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell merged pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
apurtell merged pull request #3302:
URL: https://github.com/apache/hbase/pull/3302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-849192021
Update fixes a checkstyle nit in SimpleServerRpcConnection. The rest of them aren't mine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-850445909
https://stackoverflow.com/questions/19052316/why-is-system-nanotime-way-slower-in-performance-than-system-currenttimemill
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-850751391
I'm still waiting for tests to finish. Things look fine so far, want to be sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-849257102
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 22s | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 58s | master passed |
| +1 :green_heart: | compile | 7m 25s | master passed |
| +1 :green_heart: | shadedjars | 9m 8s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 5m 49s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 43s | the patch passed |
| +1 :green_heart: | compile | 7m 26s | the patch passed |
| +1 :green_heart: | javac | 7m 26s | the patch passed |
| +1 :green_heart: | shadedjars | 9m 0s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 5m 48s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 33s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 1m 37s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 0m 50s | hbase-zookeeper in the patch passed. |
| +1 :green_heart: | unit | 9m 28s | hbase-balancer in the patch passed. |
| +1 :green_heart: | unit | 0m 54s | hbase-http in the patch passed. |
| +1 :green_heart: | unit | 1m 52s | hbase-procedure in the patch passed. |
| -1 :x: | unit | 205m 59s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 13m 54s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 7m 39s | hbase-thrift in the patch passed. |
| +1 :green_heart: | unit | 3m 45s | hbase-endpoint in the patch passed. |
| +1 :green_heart: | unit | 12m 9s | hbase-backup in the patch passed. |
| +1 :green_heart: | unit | 1m 11s | hbase-it in the patch passed. |
| +1 :green_heart: | unit | 4m 8s | hbase-rest in the patch passed. |
| +1 :green_heart: | unit | 2m 9s | hbase-examples in the patch passed. |
| +1 :green_heart: | unit | 0m 56s | hbase-hbtop in the patch passed. |
| | | 330m 44s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3302 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 83b954bea610 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a22e418cf6 |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/3/testReport/ |
| Max. process+thread count | 3239 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-client hbase-zookeeper hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/3/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell edited a comment on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
apurtell edited a comment on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-849872794
> What about System.nanoTime?
@Apache9 System.nanotime is not used to get the system clock. I don't mind bringing it into EnvironmentEdge but I don't care about it here. It is out of scope for all of this work.
Feel free to file a follow up JIRA, to add it to EnvironmentEdge in the future, if you would like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-850569022
> But sometimes we use System.currentTimeMillis just for calculating elapsed time, not for getting system clock, I'm not sure if this is also our goal here, to also replace these usages.
@Apache9 This is not the goal.
> We introduced EnvironmentEdgeManager a long time ago as a way to inject alternate clocks (gettimeofday() aka System.currentTimeMillis()) for unit tests. In order for this to be effective, all callers that would otherwise use System.currentTimeMillis() must call EnvironmentEdgeManager.currentTime() instead, except obviously the implementors of EnvironmentEdge.
>
> It's common for contributors to be unaware of this practice and reviewers might not catch it.
The goal is to fix the code is out of practice with EnvironmentEdgeManager#currentTime.
We can also do something about nanotime, but under another JIRA, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani edited a comment on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
virajjasani edited a comment on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-850442580
> In general we should all use System.nanoTime for calculating elapsed time, but System.nanoTime is usually slower than System.currentTimeMillis
@Apache9 do you have any ref for this? I was not aware of slowness in nanoTime. I hope it is negligible considering it has to be more precise than millis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-849157911
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 38s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 4s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 37s | master passed |
| +1 :green_heart: | compile | 12m 38s | master passed |
| +1 :green_heart: | checkstyle | 5m 55s | master passed |
| +1 :green_heart: | spotbugs | 12m 31s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 42s | the patch passed |
| +1 :green_heart: | compile | 13m 14s | the patch passed |
| -0 :warning: | javac | 0m 49s | hbase-mapreduce generated 1 new + 197 unchanged - 1 fixed = 198 total (was 198) |
| -0 :warning: | checkstyle | 1m 32s | hbase-server: The patch generated 2 new + 1256 unchanged - 6 fixed = 1258 total (was 1262) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 18m 59s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 15m 22s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 2m 51s | The patch does not generate ASF License warnings. |
| | | 109m 12s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3302 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 11f02e258695 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a22e418cf6 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-mapreduce.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| Max. process+thread count | 96 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-client hbase-zookeeper hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/3/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-847463261
What about System.nanoTime?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani edited a comment on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime
Posted by GitBox <gi...@apache.org>.
virajjasani edited a comment on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-850502504
> https://stackoverflow.com/questions/19052316/why-is-system-nanotime-way-slower-in-performance-than-system-currenttimemill
As per the Oracle blog (link to blog is obsolete): _If you are interested in measuring/calculating elapsed time, then always use System.nanoTime(). On most systems it will give a resolution on the order of microseconds. Be aware though, this call can also take microseconds to execute on some platforms._
It looks like, unless we are too specific about elapsed time that we want only nanosecond level elapsed time, we should prefer System#currentTimeMillis for the perf benefit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org