You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Alexandra Sava <al...@gmail.com> on 2014/07/07 21:05:43 UTC

Re: Review Request 23147: Rename slaves/frameworks activated/deactivated

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23147/
-----------------------------------------------------------

(Updated July 7, 2014, 7:05 p.m.)


Review request for mesos, Adam B and Ben Mahler.


Bugs: MESOS-1188
    https://issues.apache.org/jira/browse/MESOS-1188


Repository: mesos-git


Description
-------

The existing terminology is confusing both for "slaves.deactivated" and "frameworks.activated". Currently a deactivated slave actually represents a removed/shutdown slave and "frameworks.activated" map holds both activated and deactivated frameworks.
In order to make things look clear, rename the following:
* master.slaves.deactivated -> master.slaves.removed
* master.slaves.activated -> master.slaves.registered
* master.frameworks.activated -> master.frameworks.registered
* allocator.slaveDisconnect -> allocator.slaveDeactivate
* allocator.slaveReconnected -> allocator.slaveReactivated


Diffs (updated)
-----

  src/master/allocator.hpp 1cd573477b609bb69264f16156a4004ecac672a7 
  src/master/constants.hpp 2daa9b004ab0cc79773730350369f66315356cad 
  src/master/constants.cpp e9e5e67f890f3399c24637c0f021d656dfe51118 
  src/master/hierarchical_allocator_process.hpp 1765e7035bdda4c28e79d74c92e77dcc99759001 
  src/master/http.cpp 5d869767cd3ed48aae1e702e8d014a37ef371123 
  src/master/master.hpp 5fef35406c2ce2ad11e030aa7752eb691aab5857 
  src/master/master.cpp 251b699ef971d69190bb2269ec8679067383e546 
  src/tests/fault_tolerance_tests.cpp ac65050bec5720b982f53d4dd6797cc3dee285dc 
  src/tests/master_authorization_tests.cpp 0fdf464cc4a562afec276ec604205af3b56636de 
  src/tests/mesos.hpp ae38a13d8b329f6e27813776e0d2f2b56605d0eb 
  src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e 
  src/webui/master/static/home.html ce8ca192235c224715c01fef0b8ddb187dc0a827 
  src/webui/master/static/js/controllers.js 41a70a80442501a2bf7b217939dbe504662941d2 

Diff: https://reviews.apache.org/r/23147/diff/


Testing
-------


Thanks,

Alexandra Sava


Re: Review Request 23147: Rename slaves/frameworks activated/deactivated

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23147/#review47751
-----------------------------------------------------------

Ship it!


Thanks Alexandra, this looks good to me. I am ok with this correcting the old metric values and leaving the names as they are.

I will let Adam get this committed for you!

Adam, feel free to pull down her patch and add the names in the TODOs to avoid another unnecessary review cycle.

- Ben Mahler


On July 11, 2014, 1:28 p.m., Alexandra Sava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23147/
> -----------------------------------------------------------
> 
> (Updated July 11, 2014, 1:28 p.m.)
> 
> 
> Review request for mesos, Adam B and Ben Mahler.
> 
> 
> Bugs: MESOS-1188
>     https://issues.apache.org/jira/browse/MESOS-1188
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The existing terminology is confusing both for "slaves.deactivated" and "frameworks.activated". Currently a deactivated slave actually represents a removed/shutdown slave and "frameworks.activated" map holds both activated and deactivated frameworks.
> In order to make things look clear, rename the following:
> * master.slaves.deactivated -> master.slaves.removed
> * master.slaves.activated -> master.slaves.registered
> * master.frameworks.activated -> master.frameworks.registered
> * allocator.slaveDisconnect -> allocator.slaveDeactivate
> * allocator.slaveReconnected -> allocator.slaveReactivated
> 
> 
> Diffs
> -----
> 
>   src/master/allocator.hpp 1cd573477b609bb69264f16156a4004ecac672a7 
>   src/master/constants.hpp 2daa9b004ab0cc79773730350369f66315356cad 
>   src/master/constants.cpp e9e5e67f890f3399c24637c0f021d656dfe51118 
>   src/master/hierarchical_allocator_process.hpp 1765e7035bdda4c28e79d74c92e77dcc99759001 
>   src/master/http.cpp 4fba007bfb9909056dc85f9dc04483994d662740 
>   src/master/master.hpp 8641f2dfe711481133869f876715b56728dc1bc0 
>   src/master/master.cpp 86b147fce153fe3a241dbd841e033f2b7ca07b01 
>   src/tests/fault_tolerance_tests.cpp ac65050bec5720b982f53d4dd6797cc3dee285dc 
>   src/tests/master_authorization_tests.cpp 0fdf464cc4a562afec276ec604205af3b56636de 
>   src/tests/mesos.hpp ae38a13d8b329f6e27813776e0d2f2b56605d0eb 
>   src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e 
> 
> Diff: https://reviews.apache.org/r/23147/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexandra Sava
> 
>


Re: Review Request 23147: Rename slaves/frameworks activated/deactivated

Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23147/#review47691
-----------------------------------------------------------

Ship it!


Looks great! Please add your id to the TODOs and rebase against the latest master (if you haven't already), and I would be happy to commit this for you.


src/master/http.cpp
<https://reviews.apache.org/r/23147/#comment83838>

    Please add your userid to the TODO: // TODO(alexandra.sava) Add... (Same for the other TODOs in here.)



src/master/http.cpp
<https://reviews.apache.org/r/23147/#comment83839>

    While I agree that these are the correct new values for the new interpretations of the activated/deactivated terms, I hope nobody was depending on the old meanings of these stats.
    I could imagine keeping activated|deactivated_slaves to the old meaning (registered/removed) and adding new active|inactive_slaves stats, but that would be too confusing to a first-time stats viewer. Better to change them and document.
    That said, I don't know if it would be better to document it in docs/upgrades.md (mostly about the upgrade process) or just put a note in the CHANGELOG or release notes blog. I'll ask around, but that shouldn't stop us from committing this.



src/master/http.cpp
<https://reviews.apache.org/r/23147/#comment83840>

    Ditto.



src/master/master.cpp
<https://reviews.apache.org/r/23147/#comment83841>

    // TODO(alexandra.sava): Count...



src/master/master.cpp
<https://reviews.apache.org/r/23147/#comment83842>

    // TODO(alexandra.sava): Add...


- Adam B


On July 11, 2014, 6:28 a.m., Alexandra Sava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23147/
> -----------------------------------------------------------
> 
> (Updated July 11, 2014, 6:28 a.m.)
> 
> 
> Review request for mesos, Adam B and Ben Mahler.
> 
> 
> Bugs: MESOS-1188
>     https://issues.apache.org/jira/browse/MESOS-1188
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The existing terminology is confusing both for "slaves.deactivated" and "frameworks.activated". Currently a deactivated slave actually represents a removed/shutdown slave and "frameworks.activated" map holds both activated and deactivated frameworks.
> In order to make things look clear, rename the following:
> * master.slaves.deactivated -> master.slaves.removed
> * master.slaves.activated -> master.slaves.registered
> * master.frameworks.activated -> master.frameworks.registered
> * allocator.slaveDisconnect -> allocator.slaveDeactivate
> * allocator.slaveReconnected -> allocator.slaveReactivated
> 
> 
> Diffs
> -----
> 
>   src/master/allocator.hpp 1cd573477b609bb69264f16156a4004ecac672a7 
>   src/master/constants.hpp 2daa9b004ab0cc79773730350369f66315356cad 
>   src/master/constants.cpp e9e5e67f890f3399c24637c0f021d656dfe51118 
>   src/master/hierarchical_allocator_process.hpp 1765e7035bdda4c28e79d74c92e77dcc99759001 
>   src/master/http.cpp 4fba007bfb9909056dc85f9dc04483994d662740 
>   src/master/master.hpp 8641f2dfe711481133869f876715b56728dc1bc0 
>   src/master/master.cpp 86b147fce153fe3a241dbd841e033f2b7ca07b01 
>   src/tests/fault_tolerance_tests.cpp ac65050bec5720b982f53d4dd6797cc3dee285dc 
>   src/tests/master_authorization_tests.cpp 0fdf464cc4a562afec276ec604205af3b56636de 
>   src/tests/mesos.hpp ae38a13d8b329f6e27813776e0d2f2b56605d0eb 
>   src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e 
> 
> Diff: https://reviews.apache.org/r/23147/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexandra Sava
> 
>


Re: Review Request 23147: Rename slaves/frameworks activated/deactivated

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23147/#review47649
-----------------------------------------------------------


Patch looks great!

Reviews applied: [23147]

All tests passed.

- Mesos ReviewBot


On July 11, 2014, 1:28 p.m., Alexandra Sava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23147/
> -----------------------------------------------------------
> 
> (Updated July 11, 2014, 1:28 p.m.)
> 
> 
> Review request for mesos, Adam B and Ben Mahler.
> 
> 
> Bugs: MESOS-1188
>     https://issues.apache.org/jira/browse/MESOS-1188
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The existing terminology is confusing both for "slaves.deactivated" and "frameworks.activated". Currently a deactivated slave actually represents a removed/shutdown slave and "frameworks.activated" map holds both activated and deactivated frameworks.
> In order to make things look clear, rename the following:
> * master.slaves.deactivated -> master.slaves.removed
> * master.slaves.activated -> master.slaves.registered
> * master.frameworks.activated -> master.frameworks.registered
> * allocator.slaveDisconnect -> allocator.slaveDeactivate
> * allocator.slaveReconnected -> allocator.slaveReactivated
> 
> 
> Diffs
> -----
> 
>   src/master/allocator.hpp 1cd573477b609bb69264f16156a4004ecac672a7 
>   src/master/constants.hpp 2daa9b004ab0cc79773730350369f66315356cad 
>   src/master/constants.cpp e9e5e67f890f3399c24637c0f021d656dfe51118 
>   src/master/hierarchical_allocator_process.hpp 1765e7035bdda4c28e79d74c92e77dcc99759001 
>   src/master/http.cpp 4fba007bfb9909056dc85f9dc04483994d662740 
>   src/master/master.hpp 8641f2dfe711481133869f876715b56728dc1bc0 
>   src/master/master.cpp 86b147fce153fe3a241dbd841e033f2b7ca07b01 
>   src/tests/fault_tolerance_tests.cpp ac65050bec5720b982f53d4dd6797cc3dee285dc 
>   src/tests/master_authorization_tests.cpp 0fdf464cc4a562afec276ec604205af3b56636de 
>   src/tests/mesos.hpp ae38a13d8b329f6e27813776e0d2f2b56605d0eb 
>   src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e 
> 
> Diff: https://reviews.apache.org/r/23147/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexandra Sava
> 
>


Re: Review Request 23147: Rename slaves/frameworks activated/deactivated

Posted by Alexandra Sava <al...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23147/
-----------------------------------------------------------

(Updated July 11, 2014, 1:28 p.m.)


Review request for mesos, Adam B and Ben Mahler.


Bugs: MESOS-1188
    https://issues.apache.org/jira/browse/MESOS-1188


Repository: mesos-git


Description
-------

The existing terminology is confusing both for "slaves.deactivated" and "frameworks.activated". Currently a deactivated slave actually represents a removed/shutdown slave and "frameworks.activated" map holds both activated and deactivated frameworks.
In order to make things look clear, rename the following:
* master.slaves.deactivated -> master.slaves.removed
* master.slaves.activated -> master.slaves.registered
* master.frameworks.activated -> master.frameworks.registered
* allocator.slaveDisconnect -> allocator.slaveDeactivate
* allocator.slaveReconnected -> allocator.slaveReactivated


Diffs (updated)
-----

  src/master/allocator.hpp 1cd573477b609bb69264f16156a4004ecac672a7 
  src/master/constants.hpp 2daa9b004ab0cc79773730350369f66315356cad 
  src/master/constants.cpp e9e5e67f890f3399c24637c0f021d656dfe51118 
  src/master/hierarchical_allocator_process.hpp 1765e7035bdda4c28e79d74c92e77dcc99759001 
  src/master/http.cpp 4fba007bfb9909056dc85f9dc04483994d662740 
  src/master/master.hpp 8641f2dfe711481133869f876715b56728dc1bc0 
  src/master/master.cpp 86b147fce153fe3a241dbd841e033f2b7ca07b01 
  src/tests/fault_tolerance_tests.cpp ac65050bec5720b982f53d4dd6797cc3dee285dc 
  src/tests/master_authorization_tests.cpp 0fdf464cc4a562afec276ec604205af3b56636de 
  src/tests/mesos.hpp ae38a13d8b329f6e27813776e0d2f2b56605d0eb 
  src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e 

Diff: https://reviews.apache.org/r/23147/diff/


Testing
-------


Thanks,

Alexandra Sava


Re: Review Request 23147: Rename slaves/frameworks activated/deactivated

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23147/#review47421
-----------------------------------------------------------


Bad patch!

Reviews applied: [23147]

Failed command: git apply --index 23147.patch

Error:
 error: patch failed: src/master/http.cpp:351
error: src/master/http.cpp: patch does not apply


- Mesos ReviewBot


On July 7, 2014, 7:05 p.m., Alexandra Sava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23147/
> -----------------------------------------------------------
> 
> (Updated July 7, 2014, 7:05 p.m.)
> 
> 
> Review request for mesos, Adam B and Ben Mahler.
> 
> 
> Bugs: MESOS-1188
>     https://issues.apache.org/jira/browse/MESOS-1188
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The existing terminology is confusing both for "slaves.deactivated" and "frameworks.activated". Currently a deactivated slave actually represents a removed/shutdown slave and "frameworks.activated" map holds both activated and deactivated frameworks.
> In order to make things look clear, rename the following:
> * master.slaves.deactivated -> master.slaves.removed
> * master.slaves.activated -> master.slaves.registered
> * master.frameworks.activated -> master.frameworks.registered
> * allocator.slaveDisconnect -> allocator.slaveDeactivate
> * allocator.slaveReconnected -> allocator.slaveReactivated
> 
> 
> Diffs
> -----
> 
>   src/master/allocator.hpp 1cd573477b609bb69264f16156a4004ecac672a7 
>   src/master/constants.hpp 2daa9b004ab0cc79773730350369f66315356cad 
>   src/master/constants.cpp e9e5e67f890f3399c24637c0f021d656dfe51118 
>   src/master/hierarchical_allocator_process.hpp 1765e7035bdda4c28e79d74c92e77dcc99759001 
>   src/master/http.cpp 5d869767cd3ed48aae1e702e8d014a37ef371123 
>   src/master/master.hpp 5fef35406c2ce2ad11e030aa7752eb691aab5857 
>   src/master/master.cpp 251b699ef971d69190bb2269ec8679067383e546 
>   src/tests/fault_tolerance_tests.cpp ac65050bec5720b982f53d4dd6797cc3dee285dc 
>   src/tests/master_authorization_tests.cpp 0fdf464cc4a562afec276ec604205af3b56636de 
>   src/tests/mesos.hpp ae38a13d8b329f6e27813776e0d2f2b56605d0eb 
>   src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e 
>   src/webui/master/static/home.html ce8ca192235c224715c01fef0b8ddb187dc0a827 
>   src/webui/master/static/js/controllers.js 41a70a80442501a2bf7b217939dbe504662941d2 
> 
> Diff: https://reviews.apache.org/r/23147/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexandra Sava
> 
>


Re: Review Request 23147: Rename slaves/frameworks activated/deactivated

Posted by Alexandra Sava <al...@gmail.com>.

> On July 8, 2014, 8:53 a.m., Adam B wrote:
> > src/master/http.cpp, lines 356-358
> > <https://reviews.apache.org/r/23147/diff/2/?file=624768#file624768line356>
> >
> >     Add a comment here for when we can remove them (0.21 if this goes into 0.20?)

Ok so since I'm currently working on MESOS-1476 and I plan to name 'active slaves'/'deactive slaves' the slaves for which resource offers are / are not sent, we will need a statistic for that as well. Since we already have it but it's not counting the right thing, I will change it to count the right thing: the number of active slaves (slaves for which resource offers are sent). Currently, the only way slaves can get deactivated is when they are disconnected (please have a look @ Master::disconnect method). So, in order to count the deactivated slaves it's enough to count the disconnected slaves (there already is a method that counts this: Master::_slaves_inactive()).

Once MESOS-1476 gets commited, I will change _slaves_active method (which currently counts the disconnected slaves - which are also deactivated slaves) to also count the slaves that have been deactivated via HTTP POSTs. I will add a TODO for that.

Also, we need metrics and stats for "registered_slaves"/"removed_slaves". I will create a separate review for that. I will add just a TODO now.


- Alexandra


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23147/#review47434
-----------------------------------------------------------


On July 11, 2014, 1:28 p.m., Alexandra Sava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23147/
> -----------------------------------------------------------
> 
> (Updated July 11, 2014, 1:28 p.m.)
> 
> 
> Review request for mesos, Adam B and Ben Mahler.
> 
> 
> Bugs: MESOS-1188
>     https://issues.apache.org/jira/browse/MESOS-1188
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The existing terminology is confusing both for "slaves.deactivated" and "frameworks.activated". Currently a deactivated slave actually represents a removed/shutdown slave and "frameworks.activated" map holds both activated and deactivated frameworks.
> In order to make things look clear, rename the following:
> * master.slaves.deactivated -> master.slaves.removed
> * master.slaves.activated -> master.slaves.registered
> * master.frameworks.activated -> master.frameworks.registered
> * allocator.slaveDisconnect -> allocator.slaveDeactivate
> * allocator.slaveReconnected -> allocator.slaveReactivated
> 
> 
> Diffs
> -----
> 
>   src/master/allocator.hpp 1cd573477b609bb69264f16156a4004ecac672a7 
>   src/master/constants.hpp 2daa9b004ab0cc79773730350369f66315356cad 
>   src/master/constants.cpp e9e5e67f890f3399c24637c0f021d656dfe51118 
>   src/master/hierarchical_allocator_process.hpp 1765e7035bdda4c28e79d74c92e77dcc99759001 
>   src/master/http.cpp 4fba007bfb9909056dc85f9dc04483994d662740 
>   src/master/master.hpp 8641f2dfe711481133869f876715b56728dc1bc0 
>   src/master/master.cpp 86b147fce153fe3a241dbd841e033f2b7ca07b01 
>   src/tests/fault_tolerance_tests.cpp ac65050bec5720b982f53d4dd6797cc3dee285dc 
>   src/tests/master_authorization_tests.cpp 0fdf464cc4a562afec276ec604205af3b56636de 
>   src/tests/mesos.hpp ae38a13d8b329f6e27813776e0d2f2b56605d0eb 
>   src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e 
> 
> Diff: https://reviews.apache.org/r/23147/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexandra Sava
> 
>


Re: Review Request 23147: Rename slaves/frameworks activated/deactivated

Posted by Adam B <ad...@mesosphere.io>.

> On July 8, 2014, 1:53 a.m., Adam B wrote:
> > src/master/http.cpp, lines 356-358
> > <https://reviews.apache.org/r/23147/diff/2/?file=624768#file624768line356>
> >
> >     Add a comment here for when we can remove them (0.21 if this goes into 0.20?)
> 
> Alexandra Sava wrote:
>     Ok so since I'm currently working on MESOS-1476 and I plan to name 'active slaves'/'deactive slaves' the slaves for which resource offers are / are not sent, we will need a statistic for that as well. Since we already have it but it's not counting the right thing, I will change it to count the right thing: the number of active slaves (slaves for which resource offers are sent). Currently, the only way slaves can get deactivated is when they are disconnected (please have a look @ Master::disconnect method). So, in order to count the deactivated slaves it's enough to count the disconnected slaves (there already is a method that counts this: Master::_slaves_inactive()).
>     
>     Once MESOS-1476 gets commited, I will change _slaves_active method (which currently counts the disconnected slaves - which are also deactivated slaves) to also count the slaves that have been deactivated via HTTP POSTs. I will add a TODO for that.
>     
>     Also, we need metrics and stats for "registered_slaves"/"removed_slaves". I will create a separate review for that. I will add just a TODO now.
>

Sounds great!


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23147/#review47434
-----------------------------------------------------------


On July 11, 2014, 6:28 a.m., Alexandra Sava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23147/
> -----------------------------------------------------------
> 
> (Updated July 11, 2014, 6:28 a.m.)
> 
> 
> Review request for mesos, Adam B and Ben Mahler.
> 
> 
> Bugs: MESOS-1188
>     https://issues.apache.org/jira/browse/MESOS-1188
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The existing terminology is confusing both for "slaves.deactivated" and "frameworks.activated". Currently a deactivated slave actually represents a removed/shutdown slave and "frameworks.activated" map holds both activated and deactivated frameworks.
> In order to make things look clear, rename the following:
> * master.slaves.deactivated -> master.slaves.removed
> * master.slaves.activated -> master.slaves.registered
> * master.frameworks.activated -> master.frameworks.registered
> * allocator.slaveDisconnect -> allocator.slaveDeactivate
> * allocator.slaveReconnected -> allocator.slaveReactivated
> 
> 
> Diffs
> -----
> 
>   src/master/allocator.hpp 1cd573477b609bb69264f16156a4004ecac672a7 
>   src/master/constants.hpp 2daa9b004ab0cc79773730350369f66315356cad 
>   src/master/constants.cpp e9e5e67f890f3399c24637c0f021d656dfe51118 
>   src/master/hierarchical_allocator_process.hpp 1765e7035bdda4c28e79d74c92e77dcc99759001 
>   src/master/http.cpp 4fba007bfb9909056dc85f9dc04483994d662740 
>   src/master/master.hpp 8641f2dfe711481133869f876715b56728dc1bc0 
>   src/master/master.cpp 86b147fce153fe3a241dbd841e033f2b7ca07b01 
>   src/tests/fault_tolerance_tests.cpp ac65050bec5720b982f53d4dd6797cc3dee285dc 
>   src/tests/master_authorization_tests.cpp 0fdf464cc4a562afec276ec604205af3b56636de 
>   src/tests/mesos.hpp ae38a13d8b329f6e27813776e0d2f2b56605d0eb 
>   src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e 
> 
> Diff: https://reviews.apache.org/r/23147/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexandra Sava
> 
>


Re: Review Request 23147: Rename slaves/frameworks activated/deactivated

Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23147/#review47434
-----------------------------------------------------------



src/master/allocator.hpp
<https://reviews.apache.org/r/23147/#comment83252>

    Why not slaveActivated(), like frameworkActivated() above?



src/master/http.cpp
<https://reviews.apache.org/r/23147/#comment83253>

    Add a comment here for when we can remove them (0.21 if this goes into 0.20?)



src/master/master.cpp
<https://reviews.apache.org/r/23147/#comment83254>

    and deactivate it in the allocator


- Adam B


On July 7, 2014, 12:05 p.m., Alexandra Sava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23147/
> -----------------------------------------------------------
> 
> (Updated July 7, 2014, 12:05 p.m.)
> 
> 
> Review request for mesos, Adam B and Ben Mahler.
> 
> 
> Bugs: MESOS-1188
>     https://issues.apache.org/jira/browse/MESOS-1188
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The existing terminology is confusing both for "slaves.deactivated" and "frameworks.activated". Currently a deactivated slave actually represents a removed/shutdown slave and "frameworks.activated" map holds both activated and deactivated frameworks.
> In order to make things look clear, rename the following:
> * master.slaves.deactivated -> master.slaves.removed
> * master.slaves.activated -> master.slaves.registered
> * master.frameworks.activated -> master.frameworks.registered
> * allocator.slaveDisconnect -> allocator.slaveDeactivate
> * allocator.slaveReconnected -> allocator.slaveReactivated
> 
> 
> Diffs
> -----
> 
>   src/master/allocator.hpp 1cd573477b609bb69264f16156a4004ecac672a7 
>   src/master/constants.hpp 2daa9b004ab0cc79773730350369f66315356cad 
>   src/master/constants.cpp e9e5e67f890f3399c24637c0f021d656dfe51118 
>   src/master/hierarchical_allocator_process.hpp 1765e7035bdda4c28e79d74c92e77dcc99759001 
>   src/master/http.cpp 5d869767cd3ed48aae1e702e8d014a37ef371123 
>   src/master/master.hpp 5fef35406c2ce2ad11e030aa7752eb691aab5857 
>   src/master/master.cpp 251b699ef971d69190bb2269ec8679067383e546 
>   src/tests/fault_tolerance_tests.cpp ac65050bec5720b982f53d4dd6797cc3dee285dc 
>   src/tests/master_authorization_tests.cpp 0fdf464cc4a562afec276ec604205af3b56636de 
>   src/tests/mesos.hpp ae38a13d8b329f6e27813776e0d2f2b56605d0eb 
>   src/tests/slave_recovery_tests.cpp 582f52d73eba0e3ab089ec573d9a6c43bff0339e 
>   src/webui/master/static/home.html ce8ca192235c224715c01fef0b8ddb187dc0a827 
>   src/webui/master/static/js/controllers.js 41a70a80442501a2bf7b217939dbe504662941d2 
> 
> Diff: https://reviews.apache.org/r/23147/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexandra Sava
> 
>