You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/31 08:18:59 UTC
[jira] [Commented] (WICKET-6264) Form: improve error message for
disabled/invisible IFormSubmittingComponent
[ https://issues.apache.org/jira/browse/WICKET-6264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15621584#comment-15621584 ]
ASF GitHub Bot commented on WICKET-6264:
----------------------------------------
GitHub user barney2k7 opened a pull request:
https://github.com/apache/wicket/pull/186
WICKET-6264: Form: improve error message for disabled/invisible IForm…
…SubmittingComponent
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/barney2k7/wicket WICKET-6264
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/186.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #186
----
commit afe1e333c662d6e15842b8112eedd20ae2223646
Author: barney2k7 <ba...@gmail.com>
Date: 2016-10-31T08:15:43Z
WICKET-6264: Form: improve error message for disabled/invisible IFormSubmittingComponent
----
> Form: improve error message for disabled/invisible IFormSubmittingComponent
> ---------------------------------------------------------------------------
>
> Key: WICKET-6264
> URL: https://issues.apache.org/jira/browse/WICKET-6264
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 7.5.0
> Reporter: Jonas
> Priority: Minor
>
> org.apache.wicket.markup.html.form.Form.onFormSubmitted(IFormSubmitter) throws WicketRuntimeExceptions in case the IFormSubmittingComponent has is not/no longer enabled or visible.
> A logged message looks like this:
> {noformat}
> 2016-10-28 11:49:27,289 ERROR [org.apache.wicket.DefaultExceptionMapper] - Unexpected error occurred
> org.apache.wicket.WicketRuntimeException: Submit Button ok (path=form:ok) is not enabled
> at org.apache.wicket.markup.html.form.Form.onFormSubmitted(Form.java:772)
> at org.apache.wicket.markup.html.form.Form.onFormSubmitted(Form.java:708)
> ...
> {noformat}
> This kind of problem is currently quite hard to fix, as neither the error message nor the stack trace contains any hint what page is affected.
> I would like to propose to add e.g. the pages' class to both error messages, e.g. "Submit Button ok (path=form:ok) on page com.foo.bar.WebPage is not enabled" and "...visible"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)