You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/09/06 01:39:31 UTC
[GitHub] [apisix-ingress-controller] AlinsRan opened a new pull request, #1320: feat: support kubebuilder
AlinsRan opened a new pull request, #1320:
URL: https://github.com/apache/apisix-ingress-controller/pull/1320
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1320: feat: support kubebuilder
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 commented on PR #1320:
URL: https://github.com/apache/apisix-ingress-controller/pull/1320#issuecomment-1700282227
This is a huge PR, but we don't have much time to continue reviewing it. Let me move it to v1.8 and hopefully we can complete it in the next release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] lingsamuel commented on a diff in pull request #1320: feat: support kubebuilder
Posted by GitBox <gi...@apache.org>.
lingsamuel commented on code in PR #1320:
URL: https://github.com/apache/apisix-ingress-controller/pull/1320#discussion_r966784050
##########
.gitignore:
##########
@@ -42,3 +42,5 @@ apisix-ingress-controller
.actions/openwhisk-utilities
.generated
+
+bin/
Review Comment:
Missing EOF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] lingsamuel commented on pull request #1320: feat: support kubebuilder
Posted by GitBox <gi...@apache.org>.
lingsamuel commented on PR #1320:
URL: https://github.com/apache/apisix-ingress-controller/pull/1320#issuecomment-1241683678
We can update the gitattribute file after this PR merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: support kubebuilder [apisix-ingress-controller]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #1320: feat: support kubebuilder
URL: https://github.com/apache/apisix-ingress-controller/pull/1320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] lingsamuel commented on a diff in pull request #1320: feat: support kubebuilder
Posted by GitBox <gi...@apache.org>.
lingsamuel commented on code in PR #1320:
URL: https://github.com/apache/apisix-ingress-controller/pull/1320#discussion_r966793869
##########
pkg/kube/apisix/apis/config/v1/zz_generated.register.go:
##########
@@ -24,7 +24,7 @@ import (
)
// GroupName specifies the group name used to register the objects.
-const GroupName = "apisix.apache.org"
+const GroupName = "config"
Review Comment:
I guess this is wrong. Leave the group option empty to let it use the domain (apisix.apache.org) directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] lingsamuel commented on pull request #1320: feat: support kubebuilder
Posted by GitBox <gi...@apache.org>.
lingsamuel commented on PR #1320:
URL: https://github.com/apache/apisix-ingress-controller/pull/1320#issuecomment-1241676202
/hold
https://github.com/apache/apisix-ingress-controller/issues/515#issuecomment-1235265365 Careful verification is required that the CRD checking rules have been properly ported to the code base.
Also, old CRD files should be deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1320: feat: support kubebuilder
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1320:
URL: https://github.com/apache/apisix-ingress-controller/pull/1320#issuecomment-1237572528
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1320?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1320](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1320?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ccde0bf) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/6b86d2a15f9d1e245ec06d2c8fb1d4c65b7c96b2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b86d2a) will **decrease** coverage by `2.91%`.
> The diff coverage is `22.22%`.
```diff
@@ Coverage Diff @@
## master #1320 +/- ##
==========================================
- Coverage 42.65% 39.73% -2.92%
==========================================
Files 73 75 +2
Lines 6478 6979 +501
==========================================
+ Hits 2763 2773 +10
- Misses 3418 3907 +489
- Partials 297 299 +2
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/providers/apisix/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9hcGlzaXgvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `19.10% <17.39%> (-0.04%)` | :arrow_down: |
| [...viders/apisix/translation/apisix\_cluster\_config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9hcGlzaXgvdHJhbnNsYXRpb24vYXBpc2l4X2NsdXN0ZXJfY29uZmlnLmdv) | `50.00% <50.00%> (ø)` | |
| [...roviders/apisix/translation/apisix\_pluginconfig.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9hcGlzaXgvdHJhbnNsYXRpb24vYXBpc2l4X3BsdWdpbmNvbmZpZy5nbw==) | `36.66% <50.00%> (ø)` | |
| [pkg/providers/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9pbmdyZXNzL2luZ3Jlc3MuZ28=) | `5.14% <0.00%> (-0.08%)` | :arrow_down: |
| [...rs/ingress/translation/annotations/forward\_auth.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9pbmdyZXNzL3RyYW5zbGF0aW9uL2Fubm90YXRpb25zL2ZvcndhcmRfYXV0aC5nbw==) | | |
| [...viders/ingress/translation/annotations/redirect.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9pbmdyZXNzL3RyYW5zbGF0aW9uL2Fubm90YXRpb25zL3JlZGlyZWN0Lmdv) | | |
| [...providers/ingress/translation/annotations/types.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9pbmdyZXNzL3RyYW5zbGF0aW9uL2Fubm90YXRpb25zL3R5cGVzLmdv) | | |
| [...s/ingress/translation/annotations/iprestriction.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9pbmdyZXNzL3RyYW5zbGF0aW9uL2Fubm90YXRpb25zL2lwcmVzdHJpY3Rpb24uZ28=) | | |
| [...oviders/ingress/translation/annotations/rewrite.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9pbmdyZXNzL3RyYW5zbGF0aW9uL2Fubm90YXRpb25zL3Jld3JpdGUuZ28=) | | |
| [...s/ingress/translation/annotations/authorization.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9pbmdyZXNzL3RyYW5zbGF0aW9uL2Fubm90YXRpb25zL2F1dGhvcml6YXRpb24uZ28=) | | |
| ... and [12 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1320/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: support kubebuilder [apisix-ingress-controller]
Posted by "Revolyssup (via GitHub)" <gi...@apache.org>.
Revolyssup commented on PR #1320:
URL: https://github.com/apache/apisix-ingress-controller/pull/1320#issuecomment-1820499646
Removing this from v1.8 milestone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] lingsamuel commented on a diff in pull request #1320: feat: support kubebuilder
Posted by GitBox <gi...@apache.org>.
lingsamuel commented on code in PR #1320:
URL: https://github.com/apache/apisix-ingress-controller/pull/1320#discussion_r966790563
##########
pkg/providers/apisix/translation/apisix_route.go:
##########
@@ -136,8 +137,10 @@ func (t *translator) translateHTTPRouteV2beta2(ctx *translation.TranslateContext
if !plugin.Enable {
continue
}
- if plugin.Config != nil {
- pluginMap[plugin.Name] = plugin.Config
+ if plugin.Config.Size() > 0 {
+ config := map[string]interface{}{}
+ _ = json.Unmarshal(plugin.Config.Raw, &config)
Review Comment:
Why the error is ignored?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: support kubebuilder [apisix-ingress-controller]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1320:
URL: https://github.com/apache/apisix-ingress-controller/pull/1320#issuecomment-1902470754
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: support kubebuilder [apisix-ingress-controller]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1320:
URL: https://github.com/apache/apisix-ingress-controller/pull/1320#issuecomment-1955658353
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1320: feat: support kubebuilder
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1320:
URL: https://github.com/apache/apisix-ingress-controller/pull/1320#issuecomment-1345813153
Since there will be a lot of changes involved here, and there will be a lot of conflicts, I want to put it in the v1.7 version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org