[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #986: IGNITE-17349 Add common UI components

[GitBox <gi...@apache.org>]

sk0x50 commented on code in PR #986:
URL: https://github.com/apache/ignite-3/pull/986#discussion_r951085088


##########
modules/configuration-api/src/main/java/org/apache/ignite/configuration/validation/ConfigurationValidationException.java:
##########
@@ -54,4 +55,9 @@ public ConfigurationValidationException(List<ValidationIssue> issues) {
     public List<ValidationIssue> getIssues() {
         return issues;
     }
+
+    private static String createMessageFromIssues(List<ValidationIssue> issues) {

Review Comment:
   I don't think that this change is fully correct. It just skips error message from a validation issue.
   In case of catching a such exception you need to add additional code to get all information. I mean that the following code will not be enough:
   ```
       try {
           ....
       }
       catch (Exception e) {
           log.("unexpected exception", e);
   ```
   The code above will print: ```Validation did not pass for keys: Key 1, Key 2``. The problem itself will be lost.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org