You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "ifesdjeen (via GitHub)" <gi...@apache.org> on 2024/09/17 07:38:31 UTC
[PR] Cassandra 19869 [cassandra-accord]
ifesdjeen opened a new pull request, #121:
URL: https://github.com/apache/cassandra-accord/pull/121
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19869 [cassandra-accord]
Posted by "ifesdjeen (via GitHub)" <gi...@apache.org>.
ifesdjeen closed pull request #121: Cassandra 19869
URL: https://github.com/apache/cassandra-accord/pull/121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19869 [cassandra-accord]
Posted by "belliottsmith (via GitHub)" <gi...@apache.org>.
belliottsmith commented on code in PR #121:
URL: https://github.com/apache/cassandra-accord/pull/121#discussion_r1762623427
##########
accord-core/src/main/java/accord/local/cfk/SafeCommandsForKey.java:
##########
@@ -55,12 +55,13 @@ void updatePruned(SafeCommandStore safeStore, Command nextCommand, NotifySink no
public void update(SafeCommandStore safeStore, Command nextCommand)
{
CommandsForKey prevCfk = current();
- update(safeStore, nextCommand, prevCfk, prevCfk.update(nextCommand));
+ CommandsForKeyUpdate cfkUpdate = prevCfk.update(nextCommand);
+ update(safeStore, nextCommand, prevCfk, cfkUpdate);
}
private void update(SafeCommandStore safeStore, @Nullable Command command, CommandsForKey prevCfk, CommandsForKeyUpdate updateCfk)
{
- update(safeStore, command, prevCfk, updateCfk, NotifySink.DefaultNotifySink.INSTANCE);
+ update(safeStore, command, prevCfk, updateCfk, safeStore.replay() ? NotifySink.NoOpSink.INSTANCE : NotifySink.DefaultNotifySink.INSTANCE);
Review Comment:
I think we can switch behaviour more cleanly here, but also we need to either capture the notifications OR we need to actually submit them OR we need to avoid updating unmanaged altogether and batch notify them at the end - otherwise they may never be notified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19869 [cassandra-accord]
Posted by "ifesdjeen (via GitHub)" <gi...@apache.org>.
ifesdjeen commented on code in PR #121:
URL: https://github.com/apache/cassandra-accord/pull/121#discussion_r1764651698
##########
accord-core/src/main/java/accord/local/Status.java:
##########
@@ -913,7 +913,7 @@ public static Durability merge(Durability a, Durability b)
public static Durability mergeAtLeast(Durability a, Durability b)
Review Comment:
I think we do not need null checks there. Removed.
##########
accord-core/src/main/java/accord/local/Status.java:
##########
@@ -901,7 +901,7 @@ public static Durability nonNullOrMerge(@Nullable Durability a, @Nullable Durabi
public static Durability merge(Durability a, Durability b)
Review Comment:
I think we do not need null checks there. Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19869 [cassandra-accord]
Posted by "belliottsmith (via GitHub)" <gi...@apache.org>.
belliottsmith commented on code in PR #121:
URL: https://github.com/apache/cassandra-accord/pull/121#discussion_r1762624753
##########
accord-core/src/main/java/accord/local/Status.java:
##########
@@ -901,7 +901,7 @@ public static Durability nonNullOrMerge(@Nullable Durability a, @Nullable Durabi
public static Durability merge(Durability a, Durability b)
Review Comment:
rename or introduce `nonNullOrMerge`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19869 [cassandra-accord]
Posted by "ifesdjeen (via GitHub)" <gi...@apache.org>.
ifesdjeen commented on code in PR #121:
URL: https://github.com/apache/cassandra-accord/pull/121#discussion_r1764641436
##########
accord-core/src/main/java/accord/local/Commands.java:
##########
@@ -868,20 +903,15 @@ public static Command purge(SafeCommandStore safeStore, SafeCommand safeCommand,
case TRUNCATE:
Invariants.checkState(command.saveStatus().compareTo(TruncatedApply) < 0);
- Invariants.checkState(command.hasBeen(PreApplied));
- result = truncatedApply(command, Route.tryCastToFullRoute(maybeFullRoute));
+ if (!command.hasBeen(PreCommitted)) result = Command.Truncated.erasedOrInvalidOrVestigial(command);
Review Comment:
oh yes it is!
##########
accord-core/src/main/java/accord/local/cfk/SafeCommandsForKey.java:
##########
@@ -55,12 +55,13 @@ void updatePruned(SafeCommandStore safeStore, Command nextCommand, NotifySink no
public void update(SafeCommandStore safeStore, Command nextCommand)
{
CommandsForKey prevCfk = current();
- update(safeStore, nextCommand, prevCfk, prevCfk.update(nextCommand));
+ CommandsForKeyUpdate cfkUpdate = prevCfk.update(nextCommand);
+ update(safeStore, nextCommand, prevCfk, cfkUpdate);
}
private void update(SafeCommandStore safeStore, @Nullable Command command, CommandsForKey prevCfk, CommandsForKeyUpdate updateCfk)
{
- update(safeStore, command, prevCfk, updateCfk, NotifySink.DefaultNotifySink.INSTANCE);
+ update(safeStore, command, prevCfk, updateCfk, safeStore.replay() ? NotifySink.NoOpSink.INSTANCE : NotifySink.DefaultNotifySink.INSTANCE);
Review Comment:
Made it that we do submit notifications for now. The problem was that notifications were causing submission of new tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19869 [cassandra-accord]
Posted by "ifesdjeen (via GitHub)" <gi...@apache.org>.
ifesdjeen commented on code in PR #121:
URL: https://github.com/apache/cassandra-accord/pull/121#discussion_r1764646286
##########
accord-core/src/main/java/accord/local/cfk/SafeCommandsForKey.java:
##########
@@ -55,12 +55,13 @@ void updatePruned(SafeCommandStore safeStore, Command nextCommand, NotifySink no
public void update(SafeCommandStore safeStore, Command nextCommand)
{
CommandsForKey prevCfk = current();
- update(safeStore, nextCommand, prevCfk, prevCfk.update(nextCommand));
+ CommandsForKeyUpdate cfkUpdate = prevCfk.update(nextCommand);
+ update(safeStore, nextCommand, prevCfk, cfkUpdate);
}
private void update(SafeCommandStore safeStore, @Nullable Command command, CommandsForKey prevCfk, CommandsForKeyUpdate updateCfk)
{
- update(safeStore, command, prevCfk, updateCfk, NotifySink.DefaultNotifySink.INSTANCE);
+ update(safeStore, command, prevCfk, updateCfk, safeStore.replay() ? NotifySink.NoOpSink.INSTANCE : NotifySink.DefaultNotifySink.INSTANCE);
Review Comment:
Made it that we do submit notifications for now. The problem was that notifications were causing submission of new tasks, which was leading to some exceptions. Should be clean by now thanks to your patches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19869 [cassandra-accord]
Posted by "belliottsmith (via GitHub)" <gi...@apache.org>.
belliottsmith commented on code in PR #121:
URL: https://github.com/apache/cassandra-accord/pull/121#discussion_r1764779768
##########
accord-core/src/test/java/accord/impl/basic/Cluster.java:
##########
@@ -219,18 +220,50 @@ public void processAll()
processNext(next);
}
+ boolean hasNonRecurring()
+ {
+ boolean hasNonRecurring = false;
+ for (Pending p : pending)
+ {
+ if (!(p instanceof RecurringPendingRunnable))
+ continue;
+ RecurringPendingRunnable r = (RecurringPendingRunnable) p;
+ if (r.requeue.hasNonRecurring())
+ {
+ hasNonRecurring = true;
+ break;
+ }
+ }
+
+ return hasNonRecurring;
+ }
+
public boolean processPending()
{
checkFailures.run();
- if (pending.size() == recurring)
+ // All remaining tasks are recurring
+ if (recurring > 0 && pending.size() == recurring && !hasNonRecurring())
return false;
- Object next = pending.poll();
+ Pending next = pending.poll();
if (next == null)
return false;
processNext(next);
+
checkFailures.run();
+
+ // If drain was requested, run until we have no non-recurring tasks are available
+ if (next instanceof RecurringPendingRunnable && ((RecurringPendingRunnable) next).drainAfterRunning)
Review Comment:
by which I mean, instead of making the recurring task say "drain after me", the task submits a one-shot drain task whenever it wants to perform a drain?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19869 [cassandra-accord]
Posted by "ifesdjeen (via GitHub)" <gi...@apache.org>.
ifesdjeen commented on code in PR #121:
URL: https://github.com/apache/cassandra-accord/pull/121#discussion_r1768638023
##########
accord-core/src/test/java/accord/impl/basic/Cluster.java:
##########
@@ -475,11 +513,40 @@ public static Map<MessageType, Stats> run(Id[] nodes, MessageListener messageLis
}, 5L, SECONDS);
Scheduled reconfigure = sinks.recurring(configRandomizer::maybeUpdateTopology, 1, SECONDS);
+
+ Scheduled purge = sinks.recurring(() -> {
+ trace.debug("Triggering purge.");
Review Comment:
Added randomization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19869 [cassandra-accord]
Posted by "belliottsmith (via GitHub)" <gi...@apache.org>.
belliottsmith commented on code in PR #121:
URL: https://github.com/apache/cassandra-accord/pull/121#discussion_r1764725997
##########
accord-core/src/test/java/accord/impl/basic/Cluster.java:
##########
@@ -475,11 +513,40 @@ public static Map<MessageType, Stats> run(Id[] nodes, MessageListener messageLis
}, 5L, SECONDS);
Scheduled reconfigure = sinks.recurring(configRandomizer::maybeUpdateTopology, 1, SECONDS);
+
+ Scheduled purge = sinks.recurring(() -> {
+ trace.debug("Triggering purge.");
Review Comment:
It would be nice to randomise the frequency of these operations (lots of time in tests is now spent on restart, and anyway would be good to change the cycle), and also to randomise the set of nodes we shutdown for this, so that some transactions can carry on being processed (potentially) during this window, and we can exercise more interesting situations.
Or perhaps just randomise each replica independently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19869 [cassandra-accord]
Posted by "belliottsmith (via GitHub)" <gi...@apache.org>.
belliottsmith commented on code in PR #121:
URL: https://github.com/apache/cassandra-accord/pull/121#discussion_r1764725997
##########
accord-core/src/test/java/accord/impl/basic/Cluster.java:
##########
@@ -475,11 +513,40 @@ public static Map<MessageType, Stats> run(Id[] nodes, MessageListener messageLis
}, 5L, SECONDS);
Scheduled reconfigure = sinks.recurring(configRandomizer::maybeUpdateTopology, 1, SECONDS);
+
+ Scheduled purge = sinks.recurring(() -> {
+ trace.debug("Triggering purge.");
Review Comment:
It would be nice to randomise the frequency of this (lots of time in tests is now spent on this), and also to randomise the set of nodes we shutdown for this, so that some transactions can carry on being processed (potentially) during this window, and we can exercise more interesting situations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19869 [cassandra-accord]
Posted by "belliottsmith (via GitHub)" <gi...@apache.org>.
belliottsmith commented on code in PR #121:
URL: https://github.com/apache/cassandra-accord/pull/121#discussion_r1764780971
##########
accord-core/src/test/java/accord/impl/basic/Cluster.java:
##########
@@ -219,18 +220,50 @@ public void processAll()
processNext(next);
}
+ boolean hasNonRecurring()
+ {
+ boolean hasNonRecurring = false;
+ for (Pending p : pending)
+ {
+ if (!(p instanceof RecurringPendingRunnable))
+ continue;
+ RecurringPendingRunnable r = (RecurringPendingRunnable) p;
+ if (r.requeue.hasNonRecurring())
+ {
+ hasNonRecurring = true;
+ break;
+ }
+ }
+
+ return hasNonRecurring;
+ }
+
public boolean processPending()
{
checkFailures.run();
- if (pending.size() == recurring)
+ // All remaining tasks are recurring
+ if (recurring > 0 && pending.size() == recurring && !hasNonRecurring())
return false;
- Object next = pending.poll();
+ Pending next = pending.poll();
if (next == null)
return false;
processNext(next);
+
checkFailures.run();
+
+ // If drain was requested, run until we have no non-recurring tasks are available
+ if (next instanceof RecurringPendingRunnable && ((RecurringPendingRunnable) next).drainAfterRunning)
Review Comment:
This drain task could itself submit some other post-drain task to e.g. re-enable messaging (and schedule the next journal replay task)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19869 [cassandra-accord]
Posted by "belliottsmith (via GitHub)" <gi...@apache.org>.
belliottsmith commented on code in PR #121:
URL: https://github.com/apache/cassandra-accord/pull/121#discussion_r1764779060
##########
accord-core/src/test/java/accord/impl/basic/Cluster.java:
##########
@@ -219,18 +220,50 @@ public void processAll()
processNext(next);
}
+ boolean hasNonRecurring()
+ {
+ boolean hasNonRecurring = false;
+ for (Pending p : pending)
+ {
+ if (!(p instanceof RecurringPendingRunnable))
+ continue;
+ RecurringPendingRunnable r = (RecurringPendingRunnable) p;
+ if (r.requeue.hasNonRecurring())
+ {
+ hasNonRecurring = true;
+ break;
+ }
+ }
+
+ return hasNonRecurring;
+ }
+
public boolean processPending()
{
checkFailures.run();
- if (pending.size() == recurring)
+ // All remaining tasks are recurring
+ if (recurring > 0 && pending.size() == recurring && !hasNonRecurring())
return false;
- Object next = pending.poll();
+ Pending next = pending.poll();
if (next == null)
return false;
processNext(next);
+
checkFailures.run();
+
+ // If drain was requested, run until we have no non-recurring tasks are available
+ if (next instanceof RecurringPendingRunnable && ((RecurringPendingRunnable) next).drainAfterRunning)
Review Comment:
Might it be cleaner to submit a kind of "drain" task?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19869 [cassandra-accord]
Posted by "belliottsmith (via GitHub)" <gi...@apache.org>.
belliottsmith commented on code in PR #121:
URL: https://github.com/apache/cassandra-accord/pull/121#discussion_r1762628232
##########
accord-core/src/main/java/accord/local/Commands.java:
##########
@@ -868,20 +903,15 @@ public static Command purge(SafeCommandStore safeStore, SafeCommand safeCommand,
case TRUNCATE:
Invariants.checkState(command.saveStatus().compareTo(TruncatedApply) < 0);
- Invariants.checkState(command.hasBeen(PreApplied));
- result = truncatedApply(command, Route.tryCastToFullRoute(maybeFullRoute));
+ if (!command.hasBeen(PreCommitted)) result = Command.Truncated.erasedOrInvalidOrVestigial(command);
Review Comment:
I think this is a bad merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19869 [cassandra-accord]
Posted by "belliottsmith (via GitHub)" <gi...@apache.org>.
belliottsmith commented on code in PR #121:
URL: https://github.com/apache/cassandra-accord/pull/121#discussion_r1762631508
##########
accord-core/src/main/java/accord/local/Commands.java:
##########
@@ -568,7 +576,25 @@ private static AsyncChain<Void> applyChain(SafeCommandStore safeStore, PreLoadCo
}));
}
- private static void apply(SafeCommandStore safeStore, Command.Executed command)
+ public static AsyncChain<Void> applyFromReplay(SafeCommandStore safeStore, PreLoadContext context, TxnId txnId)
Review Comment:
unused
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19869 [cassandra-accord]
Posted by "belliottsmith (via GitHub)" <gi...@apache.org>.
belliottsmith commented on code in PR #121:
URL: https://github.com/apache/cassandra-accord/pull/121#discussion_r1762625210
##########
accord-core/src/main/java/accord/local/Status.java:
##########
@@ -913,7 +913,7 @@ public static Durability merge(Durability a, Durability b)
public static Durability mergeAtLeast(Durability a, Durability b)
Review Comment:
rename or introduce `nonNullOrMergeAtLeast`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19869 [cassandra-accord]
Posted by "belliottsmith (via GitHub)" <gi...@apache.org>.
belliottsmith commented on code in PR #121:
URL: https://github.com/apache/cassandra-accord/pull/121#discussion_r1762638723
##########
accord-core/src/test/java/accord/impl/basic/Journal.java:
##########
@@ -49,15 +64,19 @@
import org.agrona.collections.Long2ObjectHashMap;
import org.agrona.collections.LongArrayList;
+import static accord.local.Status.Truncated;
import static accord.utils.Invariants.illegalState;
-
public class Journal implements Runnable
{
+ private static final Logger logger = LoggerFactory.getLogger(Journal.class);
+
private final Queue<RequestContext> unframedRequests = new ArrayDeque<>();
private final LongArrayList waitForEpochs = new LongArrayList();
Review Comment:
do we need this anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org