You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Jeanne Waldman (JIRA)" <de...@myfaces.apache.org> on 2008/11/18 02:50:44 UTC
[jira] Created: (TRINIDAD-1310) use state SAXParserFactory instead
of calling newInstance each time
use state SAXParserFactory instead of calling newInstance each time
-------------------------------------------------------------------
Key: TRINIDAD-1310
URL: https://issues.apache.org/jira/browse/TRINIDAD-1310
Project: MyFaces Trinidad
Issue Type: Improvement
Affects Versions: 1.2.9-core, 1.0.9-core
Reporter: Jeanne Waldman
Assignee: Jeanne Waldman
Priority: Minor
Avoid creating new SAXParserFactory's by using a static variable.
as of J2SE 1.5, the SaxParserFactory is guaranteed to be thread-safe.
Instead of :
SAXParserFactory factory = SAXParserFactory.newInstance();
factory.setNamespaceAware(true);
use:
private static final SAXParserFactory _SAX_PARSER_FACTORY;
static
{
_SAX_PARSER_FACTORY = SAXParserFactory.newInstance();
_SAX_PARSER_FACTORY.setNamespaceAware(true);
}
Searching for SAXParserFactory.newInstance() in the Trinidad code yields:
C:\Trinidad12\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\config\ConfigParser.java
(75,36): SAXParserFactory factory = SAXParserFactory.newInstance();
C:\Trinidad12\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\menu\MenuContentHandlerImpl.java
(506,34): SAXParserFactory factory = SAXParserFactory.newInstance();
C:\Trinidad12\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\metadata\RegionMetadata.java
(184,34): SAXParserFactory factory = SAXParserFactory.newInstance();
C:\Trinidad12\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\share\xml\JaxpXMLProvider.java
(51,34): SAXParserFactory factory = SAXParserFactory.newInstance();
C:\Trinidad12\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\skin\SkinUtils.java
(241,34): SAXParserFactory factory = SAXParserFactory.newInstance();
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-1310) use state SAXParserFactory
instead of calling newInstance each time
Posted by "Jeanne Waldman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648726#action_12648726 ]
Jeanne Waldman commented on TRINIDAD-1310:
------------------------------------------
checked into trunk and trunk1.2
this will be in the 1.x.11 release.
> use state SAXParserFactory instead of calling newInstance each time
> -------------------------------------------------------------------
>
> Key: TRINIDAD-1310
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1310
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Affects Versions: 1.0.9-core, 1.2.9-core
> Reporter: Jeanne Waldman
> Assignee: Jeanne Waldman
> Priority: Minor
> Fix For: 1.0.11-core, 1.2.11-core
>
>
> Avoid creating new SAXParserFactory's by using a static variable.
> as of J2SE 1.5, the SaxParserFactory is guaranteed to be thread-safe.
> Instead of :
> SAXParserFactory factory = SAXParserFactory.newInstance();
> factory.setNamespaceAware(true);
> use:
> private static final SAXParserFactory _SAX_PARSER_FACTORY;
> static
> {
> _SAX_PARSER_FACTORY = SAXParserFactory.newInstance();
> _SAX_PARSER_FACTORY.setNamespaceAware(true);
> }
> Searching for SAXParserFactory.newInstance() in the Trinidad code yields:
> C:\Trinidad12\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\config\ConfigParser.java
> (75,36): SAXParserFactory factory = SAXParserFactory.newInstance();
> C:\Trinidad12\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\menu\MenuContentHandlerImpl.java
> (506,34): SAXParserFactory factory = SAXParserFactory.newInstance();
> C:\Trinidad12\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\metadata\RegionMetadata.java
> (184,34): SAXParserFactory factory = SAXParserFactory.newInstance();
> C:\Trinidad12\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\share\xml\JaxpXMLProvider.java
> (51,34): SAXParserFactory factory = SAXParserFactory.newInstance();
> C:\Trinidad12\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\skin\SkinUtils.java
> (241,34): SAXParserFactory factory = SAXParserFactory.newInstance();
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TRINIDAD-1310) use state SAXParserFactory instead
of calling newInstance each time
Posted by "Jeanne Waldman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeanne Waldman resolved TRINIDAD-1310.
--------------------------------------
Resolution: Fixed
Fix Version/s: 1.2.11-core
1.0.11-core
> use state SAXParserFactory instead of calling newInstance each time
> -------------------------------------------------------------------
>
> Key: TRINIDAD-1310
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1310
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Affects Versions: 1.0.9-core, 1.2.9-core
> Reporter: Jeanne Waldman
> Assignee: Jeanne Waldman
> Priority: Minor
> Fix For: 1.0.11-core, 1.2.11-core
>
>
> Avoid creating new SAXParserFactory's by using a static variable.
> as of J2SE 1.5, the SaxParserFactory is guaranteed to be thread-safe.
> Instead of :
> SAXParserFactory factory = SAXParserFactory.newInstance();
> factory.setNamespaceAware(true);
> use:
> private static final SAXParserFactory _SAX_PARSER_FACTORY;
> static
> {
> _SAX_PARSER_FACTORY = SAXParserFactory.newInstance();
> _SAX_PARSER_FACTORY.setNamespaceAware(true);
> }
> Searching for SAXParserFactory.newInstance() in the Trinidad code yields:
> C:\Trinidad12\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\config\ConfigParser.java
> (75,36): SAXParserFactory factory = SAXParserFactory.newInstance();
> C:\Trinidad12\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\menu\MenuContentHandlerImpl.java
> (506,34): SAXParserFactory factory = SAXParserFactory.newInstance();
> C:\Trinidad12\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\metadata\RegionMetadata.java
> (184,34): SAXParserFactory factory = SAXParserFactory.newInstance();
> C:\Trinidad12\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\share\xml\JaxpXMLProvider.java
> (51,34): SAXParserFactory factory = SAXParserFactory.newInstance();
> C:\Trinidad12\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\skin\SkinUtils.java
> (241,34): SAXParserFactory factory = SAXParserFactory.newInstance();
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.